Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for-in-if expressions #368

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Support for-in-if expressions #368

merged 4 commits into from
Feb 6, 2024

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jan 22, 2024 •
edited
Loading

@radeksimko radeksimko added the enhancement New feature or request label Jan 22, 2024
@radeksimko radeksimko force-pushed the f-for-expression branch 8 times, most recently from 31944f4 to 8a1486e Compare January 26, 2024 11:39
@radeksimko radeksimko force-pushed the f-for-expression branch 2 times, most recently from bd80d03 to 5b6717a Compare January 26, 2024 18:02
@radeksimko radeksimko marked this pull request as ready for review January 26, 2024 20:07
@radeksimko radeksimko requested a review from a team as a code owner January 26, 2024 20:07
@dbanck dbanck mentioned this pull request Feb 5, 2024
Closed
1 task
@radeksimko radeksimko mentioned this pull request Feb 6, 2024
Open
dbanck
dbanck approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Just a question/suggestion that could also be addressed in a follow-up issue.

decoder/expr_any_completion_test.go Show resolved Hide resolved
decoder/expr_any_for.go Show resolved Hide resolved
@radeksimko
Copy link
Member Author

@dbanck I no longer have push/merge permissions here, so I'll have to leave it up to you to merge 😅

@dbanck dbanck merged commit 6a6bede into main Feb 6, 2024
5 checks passed
@dbanck dbanck deleted the f-for-expression branch February 6, 2024 10:58
@dbanck dbanck mentioned this pull request Feb 13, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Feb 13, 2024
Merged
@dbanck dbanck mentioned this pull request Feb 19, 2024
Merged
@lukaabicic
Copy link

Please fix variable declaration not found error in [2.29.4] version (2024-02-13).
The error occurs when the resources are created with a for_each argument whose values are variables of type list(object()).
The error isn't present in the previous versions.

@dbanck
Copy link
Member

dbanck commented Mar 12, 2024

@lukaabicic We just released a new version 2.29.5. This fixes the reported bug. The update should appear automatically in VS Code.

In case you experience any different validation related bug, please do let us know through a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for-in-if expressions
3 participants
@radeksimko @lukaabicic @dbanck