Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for expression collection constraints #375

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Feb 19, 2024

#368 added support for for-in-if expressions. Instead of collecting the reference origins inside for expressions with the allowed input constraints, we used the constraints of the attribute. This PR fixes that subtle bug.

Fixes hashicorp/vscode-terraform#1693

UX Before

CleanShot 2024-02-19 at 17 12 01@2x

UX After

CleanShot 2024-02-19 at 17 13 05@2x

@dbanck dbanck added the bug Something isn't working label Feb 19, 2024
@dbanck dbanck self-assigned this Feb 19, 2024
@dbanck dbanck requested a review from a team as a code owner February 19, 2024 16:09
@dbanck dbanck merged commit 6ff0526 into main Feb 20, 2024
5 checks passed
@dbanck dbanck deleted the b-fix-for-coll-constraints branch February 20, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable declaration error in for expression
2 participants