-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
transform-swagger: fix GoogleRPCStatus case (#138)
When updating cloud-packer-service to grpc-gateway v2, we broke the generated SDK for the service because the error type for all our API calls was changed from #/definitions/grpc.gateway.runtime.Error to \#/definitions/google.rpc.Status. This change then conflicted with the transform-swagger code, as it would invoke `toCamel' on it, rendering the generated type as `*cloud.GoogleRpcStatus', where the real type is `*cloud.GoogleRPCStatus'. To circumvent this problem, we hard-code this special case in the transform command, so we end-up with the expected type in the generated Go code.
- Loading branch information
1 parent
b828063
commit c81b933
Showing
2 changed files
with
18 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:BUG | ||
Added exception for google.rpc.status when generating code since it was mistakenly rendered as `GoogleRpcStatus` instead of `GoogleRPCStatus` | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters