transform-swagger: fix GoogleRPCStatus case #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylviamoss
approved these changes
Nov 28, 2022
itsjaspermilan
approved these changes
Nov 28, 2022
When updating cloud-packer-service to grpc-gateway v2, we broke the generated SDK for the service because the error type for all our API calls was changed from #/definitions/grpc.gateway.runtime.Error to \#/definitions/google.rpc.Status. This change then conflicted with the transform-swagger code, as it would invoke `toCamel' on it, rendering the generated type as `*cloud.GoogleRpcStatus', where the real type is `*cloud.GoogleRPCStatus'. To circumvent this problem, we hard-code this special case in the transform command, so we end-up with the expected type in the generated Go code.
lbajolet-hashicorp
force-pushed
the
fix_transform_grpc_gateway_v2
branch
from
6b8ca7a
to
1f4b7fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
When updating cloud-packer-service to grpc-gateway v2, we broke the generated SDK for the service because the error type for all our API calls was changed from #/definitions/grpc.gateway.runtime.Error to #/definitions/google.rpc.Status.
This change then conflicted with the transform-swagger code, as it would invoke
toCamelon it, rendering the generated type as*cloud.GoogleRpcStatus, where the real type is*cloud.GoogleRPCStatus.To circumvent this problem, we hard-code this special case in the transform command, so we end-up with the expected type in the generated Go code.
🔗 External Links
👍 Definition of Done