transform-swagger: fix GoogleRPCStatus case #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
When updating cloud-packer-service to grpc-gateway v2, we broke the generated SDK for the service because the error type for all our API calls was changed from #/definitions/grpc.gateway.runtime.Error to #/definitions/google.rpc.Status.
This change then conflicted with the transform-swagger code, as it would invoke
toCamel
on it, rendering the generated type as*cloud.GoogleRpcStatus
, where the real type is*cloud.GoogleRPCStatus
.To circumvent this problem, we hard-code this special case in the transform command, so we end-up with the expected type in the generated Go code.
🔗 External Links
👍 Definition of Done