[SSO] Auth Methods and Mock OIDC Flow #15155
Conversation
philrenaud
force-pushed
the
15124-ui-tokens-service-auth-methods
branch
from
0d69dfc to
c883384
Compare
Ember Asset Size actionAs of 696e656 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
philrenaud
changed the title
| .then(async (response) => { | ||
| if (response.ok) { | ||
| let json = await response.json(); | ||
| this.token.set('secret', json.ACLToken); | ||
| this.verifyToken(); | ||
| this.code = null; | ||
| this.state = null; | ||
| } | ||
| }); |
There was a problem hiding this comment.
question: Because we're using .then instead of async/await this callback will be fired once the request resolves and the rest of the thread of execution will resume? However, we have an isValidatingToken that will cause a conditional part of the template to render. I wonder what would happen if we simulate a slow network request. Could we trigger an unhandled error as a result? Would this be a good argument to advocate for async/await instead?
There was a problem hiding this comment.
Great minds think alike! A slow network request is exactly what we're simulating here:
Line 955 in 60f7b60
(timing: 1000 will wait a second before returning our token)
As for .thenning vs async/awaiting, I will make that switch! good suggestion.
* Top nav auth dropdown (#15055) * Basic dropdown styles * Some cleanup * delog * Default nomad hover state styles * Component separation-of-concerns and acceptance tests for auth dropdown * lintfix * [ui, sso] Handle token expiry 500s (#15073) * Handle error states generally * Dont direct, just redirect * no longer need explicit error on controller * Redirect on token-doesnt-exist * Forgot to import our time lib * Linting on _blank * Redirect tests * changelog * [ui, sso] warn user about pending token expiry (#15091) * Handle error states generally * Dont direct, just redirect * no longer need explicit error on controller * Linting on _blank * Custom notification actions and shift the template to within an else block * Lintfix * Make the closeAction optional * changelog * Add a mirage token that will always expire in 11 minutes * Test for token expiry with ember concurrency waiters * concurrency handling for earlier test, and button redirect test * [ui] if ACLs are disabled, remove the Sign In link from the top of the UI (#15114) * Remove top nav link if ACLs disabled * Change to an enabled-by-default model since you get no agent config when ACLs are disabled but you lack a token * PR feedback addressed; down with double negative conditionals * lintfix * ember getter instead of ?.prop * [SSO] Auth Methods and Mock OIDC Flow (#15155) * Big ol first pass at a redirect sign in flow * dont recursively add queryparams on redirect * Passing state and code qps * In which I go off the deep end and embed a faux provider page in the nomad ui * Buggy but self-contained flow * Flow auto-delay added and a little more polish to resetting token * secret passing turned to accessor passing * Handle SSO Failure * General cleanup and test fix * Lintfix * SSO flow acceptance tests * Percy snapshots added * Explicitly note the OIDC test route is mirage only * Handling failure case for complete-auth * Leentfeex * Tokens page styles (#15273) * styling and moving columns around * autofocus and enter press handling * Styles refined * Split up manager and regular tests * Standardizing to a binary status state * Serialize auth-methods response to use "name" as primary key (#15380) * Serializer for unique-by-name * Use @classic because of class extension
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR establishes the OIDC sign-in flow by implementing
auth-methodsand mocking a redirect flow based on which auth methods are present.Running in Mirage, Nomad will generate 3 auth methods which can be used to simulate sign-in or sign-in failure.