Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SSO] Auth Methods and Mock OIDC Flow #15155
[SSO] Auth Methods and Mock OIDC Flow #15155
Changes from 13 commits
c883384
b578271
1fcd7ce
ec4c05b
b848a72
848ed1b
1ed3c23
3166b7a
60f7b60
600b63e
7ef3045
09277c7
b9ee146
4f5d18f
696e656
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question
: Because we're using.then
instead ofasync/await
this callback will be fired once the request resolves and the rest of the thread of execution will resume? However, we have anisValidatingToken
that will cause a conditional part of the template to render. I wonder what would happen if we simulate a slow network request. Could we trigger an unhandled error as a result? Would this be a good argument to advocate forasync/await
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great minds think alike! A slow network request is exactly what we're simulating here:
nomad/ui/mirage/config.js
Line 955 in 60f7b60
(timing: 1000 will wait a second before returning our token)
As for .thenning vs async/awaiting, I will make that switch! good suggestion.