Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Switch from mitchellh/cli to hashicorp/cli #19321

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

angrycub
Copy link
Contributor

@angrycub angrycub commented Dec 5, 2023

Thanks @angrycub!

This PR switches from the achieved mitchellh/cli to the internally maintained hashicorp/cli. A semgrep rule is included to stop usage of this library in the future.

The change is like-for-like, therefore my plan is to backport this to all active release branches. Additionally, backporting CLI bug fixes might be painful without this. If any reviewers think this is a bad idea, please let me know.

The remaining indirect reference is due to github.com/hashicorp/go-secure-stdlib/listenerutil which has migrated the library on main, but not released this version. I have submitted a request for a release via hashicorp/go-secure-stdlib#151. Once released, we can followup with a dependency update PR to remove the indirect dependency.

@shoenig
Copy link
Member

shoenig commented Dec 5, 2023

Should probably also add the old import to the list of forbidden packages semgrep rule
https://github.com/hashicorp/nomad/blob/main/.semgrep/imports.yml

@angrycub angrycub force-pushed the deps/switch_to_hashicorp_cli branch from beeb51a to cc29d36 Compare January 4, 2024 20:50
@tgross tgross added the stage/needs-rebase This PR needs to be rebased on main before it can be backported to pick up new BPA workflows label May 17, 2024
@tgross
Copy link
Member

tgross commented Jul 8, 2024

@jrasell jrasell changed the title [WIP] [deps] Switch from mitchellh/cli to hashicorp/cli deps: Switch from mitchellh/cli to hashicorp/cli Dec 19, 2024
@jrasell jrasell added theme/cli and removed stage/needs-discussion stage/needs-rebase This PR needs to be rebased on main before it can be backported to pick up new BPA workflows labels Dec 19, 2024
@jrasell jrasell assigned jrasell and unassigned angrycub Dec 19, 2024
@jrasell jrasell added backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line labels Dec 19, 2024
@jrasell jrasell marked this pull request as ready for review December 19, 2024 10:49
@jrasell jrasell requested review from a team as code owners December 19, 2024 10:49
pkazmierczak
pkazmierczak previously approved these changes Dec 19, 2024
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jrasell jrasell added the backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent label Dec 19, 2024
@jrasell jrasell merged commit 30ab889 into main Dec 19, 2024
33 checks passed
@jrasell jrasell deleted the deps/switch_to_hashicorp_cli branch December 19, 2024 15:41
jrasell added a commit that referenced this pull request Dec 19, 2024
Co-authored-by: James Rasell <jrasell@hashicorp.com>
jrasell added a commit that referenced this pull request Dec 19, 2024
Co-authored-by: Charlie Voiselle <464492+angrycub@users.noreply.github.com>
Co-authored-by: James Rasell <jrasell@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/1.9.x backport to 1.9.x release line theme/cli theme/dependencies Pull requests that update a dependency file type/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants