Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of deps: Switch from mitchellh/cli to hashicorp/cli into release/1.9.x #24719

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #19321 to be assessed for backporting due to the inclusion of the label backport/1.9.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@jrasell
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/nomad/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Thanks @angrycub!

This PR switches from the achieved mitchellh/cli to the internally maintained hashicorp/cli. A semgrep rule is included to stop usage of this library in the future.

The change is like-for-like, therefore my plan is to backport this to all active release branches. Additionally, backporting CLI bug fixes might be painful without this. If any reviewers think this is a bad idea, please let me know.

The remaining indirect reference is due to github.com/hashicorp/go-secure-stdlib/listenerutil which has migrated the library on main, but not released this version. I have submitted a request for a release via hashicorp/go-secure-stdlib#151. Once released, we can followup with a dependency update PR to remove the indirect dependency.


Overview of commits

Copy link

hashicorp-cla-app bot commented Dec 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Co-authored-by: James Rasell <jrasell@hashicorp.com>
@jrasell jrasell force-pushed the backport/deps/switch_to_hashicorp_cli/randomly-elegant-woodcock branch from a36a5d5 to abefdda Compare December 19, 2024 15:44
@jrasell jrasell marked this pull request as ready for review December 19, 2024 15:45
@jrasell jrasell requested a review from pkazmierczak December 19, 2024 15:45
@jrasell jrasell merged commit 6686dd5 into release/1.9.x Dec 19, 2024
30 checks passed
@jrasell jrasell deleted the backport/deps/switch_to_hashicorp_cli/randomly-elegant-woodcock branch December 19, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants