Dueling-breaking-queries rework of the jobs index page #19778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Test Audit comparison
|
philrenaud
force-pushed
the
bff-job-summary-fe-redux
branch
from
e4834ee to
0fde10d
Compare
philrenaud
force-pushed
the
bff-job-summary-fe-redux
branch
from
0fde10d to
5ea7165
Compare
philrenaud
force-pushed
the
bff-job-summary-fe-redux
branch
from
eedc57c to
35ec0c2
Compare
philrenaud
force-pushed
the
bff-job-summary-fe-redux
branch
from
c18e1b1 to
03596ee
Compare
philrenaud
force-pushed
the
bff-job-summary-fe-redux
branch
from
03596ee to
30dcf7f
Compare
philrenaud
force-pushed
the
bff-job-summary-fe-redux
branch
from
30dcf7f to
6a1ae99
Compare
In #20296 we added a Go tool chain to the AMI we use for E2E tests, so that we can build `consul-cni` for tproxy testing. This is intended to be temporary until `consul-k8s` 1.4.2 is officially released. But the Go cache from building `consul-k8s` uses up roughly 1.5GiB of space and the test machines have fairly small disks. This causes the Nomad clients to aggressively GC client allocations that stop, which breaks tests that run batch workloads and then read their logs.
* add LICENSE(.txt) to zip that goes on releases.hashicorp.com * add LICENSE(.txt) to linux packages and docker image * add some more docker labels (including license)
Ports are a maximum of uint16, but we have a few places in the recent tproxy code where we were parsing them as 64-bit wide integers and then downcasting them to `int`, which is technically unsafe and triggers code scanning alerts. In practice we've validated the range elsewhere and don't build for 32-bit platforms. This changeset fixes the parsing to make everything a bit more robust and silence the alert. Fixes: https://github.com/hashicorp/nomad-enterprise/security/code-scanning/444
Add a standalone section to the Consul integration docs showing how to configure both the Consul agent and the workload to take advantage of Consul DNS. Include a reference to the new transparent proxy feature as well. Fixes: #18305
…ts, which can sometimes be null (#20383)
Adds new metrics to the eval broker that track times of evaluations enqueueing and dequeueing.
The `mock_driver` is an internal task driver used mostly for testing and simulating workloads. During the allocrunner v2 work (#4792) its name changed from `mock_driver` to just `mock` and then back to `mock_driver`, but the fingreprint key was kept as `driver.mock`. This results in tasks configured with `driver = "mock"` to be scheduled (because Nomad thinks the client has a task driver called `mock`), but fail to actually run (because the Nomad client can't find a driver called `mock` in its catalog). Fingerprinting the right name prevents the job from being scheduled in the first place. Also removes mentions of the mock driver from documentation since its an internal driver and not available in any production release.
The "Provision a Nomad cluster in the cloud" works in AWS with these updates: - use an available ubuntu version - uses hashicorp packages where possible - updates Nvidia installation - installs CNI plugins
…20408) * Fix a UI bug where promotion would be asked with no new canaries * Because we now make sure of your allocations, our test cases should more accurately reflect a state of a promotable workflow
* mainly jobs endpoint * update call sites * add new sort helpers * put sorting in a separate file
and move a namespace check and tweak some comments
probably will remove ActiveDeploymentID later
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borked; cherry-picked in #20452