OpenStack: Add ssh agent support #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickard-von-essen
changed the title
|
Thanks for the PR. Looks good, I might have some changes for the docs but I can fix that. Try to test this during the weekend. |
|
There was some pieces missing for this to be complete. I've added those and updated docs a bit, but I also want to port over #4665. I'll do that tonight and then merge. |
This is a port for OpenStack of PR hashicorp#4665
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an Openstack instance where we do not allow for any SSH other than through the certificate authority. This patch allows us to use SSH-CA. I've been using this patch for a couple weeks, and it works well.
If the code looks familiar, it's because I copy-pasted it from the amazon ssh code. If there's a way you'd prefer I refactor the two together, I'll be happy to do so.