builder/amazon: validate ssh key name/file #4665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using ssh_key_name, ssh_private_key file must be given, or ssh_agent_auth enabled. When automatically retrieving the winrm password, if ssh_key_name is given, ssh_private_key_file must also be given.
|
Looks good, the only thing I can see is that this forbids the use of |
oof, this is a mess. we really need a more robust configuration declaration language. |
|
I'll posit for now that if you have the key name and a password, you've probably got a configuration error |
rickard-von-essen
added a commit
to lbordowitz/packer
that referenced
this pull request
Mar 14, 2017
This is a port for OpenStack of PR hashicorp#4665
dacamp
pushed a commit
to dacamp/packer
that referenced
this pull request
Mar 17, 2017
This is a port for OpenStack of PR hashicorp#4665
dayglojesus
pushed a commit
to dayglojesus/packer
that referenced
this pull request
Apr 6, 2017
This is a port for OpenStack of PR hashicorp#4665
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ssh_key_name, ssh_private_key file must be given,
or ssh_agent_auth enabled.
When automatically retrieving the winrm password, if ssh_key_name is
given, ssh_private_key_file must also be given.
Closes #4164