[wip] Add builder hyperv-vhd #5253
Conversation
BSick7
force-pushed
the
hyperv-vhd
branch
2 times, most recently
from
93b8254
to
5f889d5
Compare
|
I am going to merge #4944 this weekend. Is there a good reason I should not? If I do there may be wasted effort on this PR. Could you have a quick look at it. |
|
Sorry I missed this potentially duplicate work. |
builder/hyperv/vhd/builder.go
Outdated
| } | ||
|
|
||
| // Run the steps. | ||
| if b.config.PackerDebug { |
There was a problem hiding this comment.
This is the wrong way of doing it. Check how it's done in virtualbox-iso.
There was a problem hiding this comment.
Good feedback. Thanks!
This was lifted from hyperv-iso.
Think it useful to update that builder as well?
There was a problem hiding this comment.
That was just fixed there.
|
Looks like this has been addressed on in a separate PR; closing this. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
NOTE: This is a work-in-progress. I would like early feedback.
Overview
Packer currently only supports building from an iso. This builder utilizes a source vhd rather than iso to create a hyperv image. This is intended to be similar to vmware vmx or virtualbox ovf.
Alterations
In order to reuse functionality from the iso builder, I have abstracted things from the iso builder.