Hyperv vmcx builder and allow vhd/vhdx instead of ISO #4944

taliesins · 2017-05-30T00:46:39Z

Import virtual machine that has been exported to a folder
Clone an existing virtual machine
Can specify a vhd or vhdx file for iso_url, which will be mounted as hdd instead of creating a new one. This works for both hyperv builders
Add a few more unit tests to hyperv builders

taliesins · 2017-05-30T11:34:54Z

Testers can download binaries from: downloads of my local builds

pvandervelde · 2017-06-07T22:41:27Z

@taliesins Is there any chance you could rebase this one to grab the changes made in #4687? I tried building my own copy yesterday by locally merging your change to master but I only got the Linux binaries, not the windows ones :(

pvandervelde · 2017-06-17T07:00:17Z

Managed to build a copy thanks to the wildly improved build scripts in the Packer repository. So far I've used that version of Packer to build Linux (Ubuntu 16.04) and Windows (2016) images from a previously generated base image. Haven't found any problems so far! All looking good here.

taliesins · 2017-08-16T06:58:18Z

@pvandervelde I assume this branch is working for you. I am going to rebase and merge it.

BSick7 · 2017-08-16T12:14:51Z

I find it confusing that a .vhd could be set as the iso.
These are different constructs and seems to go against the consistency of other providers (vmware, virtualbox, etc.).

pvandervelde · 2017-08-16T14:57:24Z

@taliesins Yeah I did a rebase on master for myself and that was working just fine, so I'd say go for it.

taliesins · 2017-08-16T17:21:30Z

@BSick7 I agree with you on the confusion around iso and vhd. What would your suggestion be?

I would like to specify a remote location for a vhd. So I would like it to go through the same caching that iso would go through.

There was some awkwardness I was avoiding by reusing iso.

BSick7 · 2017-08-17T12:12:20Z

I see 2 ways of bringing clarity to this work.

Each VM source would have its own packer builder (hyperv-iso, hyperv-vhd, etc.).
There would be different source fields (iso_url, source_path_vhd, etc.).

I vote for (1) which prompted my PR #5253.

On a side note, I've always thought that it's weird that the builder includes the logic for sourcing the VM.
I always thought that constructed be abstracted into its own section.

mwhooker · 2017-08-31T23:10:35Z

builder/hyperv/vmcx/builder.go

+	)
+
+	// Run the steps.
+	if b.config.PackerDebug {


this should be changed to b.runner = packerCommon.NewRunner(steps, b.config.PackerConfig, ui). See #5297

mwhooker · 2017-08-31T23:13:18Z

I agree with you on the confusion around iso and vhd. What would your suggestion be?

I think it's too bad, but we already overload the ISO prefix to mean any kind of disk image (hence the iso_target_extension field). Any change to this I think would have to hit anything that uses ISOConfig.

Maybe at the bare minimum, documenting that the iso_url etc are not just for isos, but can be used for VHDs. Maybe an example templating showing such.

This looks pretty good to me. @taliesins Please feel free to merge in when you think it's good to go. Please merge it by 9/5 so it's in the 1.1 release.

Needs a make fmt, too

vijayinvites · 2017-09-01T04:43:28Z

builder/hyperv/iso/builder.go

@@ -314,6 +319,7 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe
 		&common.StepCreateFloppy{
 			Files:       b.config.FloppyConfig.FloppyFiles,
 			Directories: b.config.FloppyConfig.FloppyDirectories,
+			Directories: b.config.FloppyConfig.FloppyDirectories,


These two lines are duplicated.

nebffa · 2017-09-09T08:40:05Z

Any news on this? It would be really nice to have.

vijayinvites · 2017-09-11T11:03:34Z

Yeah, I am also waiting for this to be merged in to master.

mwhooker · 2017-09-11T17:49:54Z

hmm, had to change a few things. would feel more comfortable if this builder incubated for a bit before merging. can anyone report if they've had a successful build with it?

pvandervelde · 2017-09-11T19:26:18Z

@mwhooker I've done a local merge to master and then build that a while ago. I've been building both Linux and Windows images with it for nearly 3 months now without any issues. Works fine on both my home machine and several work machines.

pvandervelde · 2017-09-12T22:04:51Z

@mwhooker Did you want me to try and do a local merge and build it in the current state to test it? Probably won't be till tonight NZ local time earliest.

mwhooker · 2017-09-12T22:13:40Z

@pvandervelde Any testing would be awesome, thanks!

Fix debug messages for cloning Add hyperv-vmcx as a builder from command line

…it is used as the hard drive for spinning up a new machine, importing an exported virtual machine or cloning a virtual machine. Can import a virtual machine from a folder Can clone an existing virtual machine

Add tests for floppy files and comm

…existing hard drive which means that we don't need to specify hard drive size Filepath.ext includes the dot

…ounted in the create vm step

mwhooker · 2017-10-09T22:19:29Z

unfortunately there are some conflicts from #5206

I will do my best to resolve them, but would like @sandersaares and @taliesins to take a look to make sure I didn't break anything

pvandervelde · 2017-10-09T22:23:57Z

@mwhooker Let me know when you have done it and I do a local merge, build and test if you want me to

pvandervelde · 2017-10-09T22:24:55Z

@taliesins Any chance you can have a look at building a VM from just the VHDX? From the documentation I got the impression that it should work but the mandatory parameters make it impossible

mwhooker · 2017-10-09T22:29:34Z

I'm sorry, it's beyond my ability right now to resolve the conflicts.

vijayinvites · 2017-10-10T12:11:58Z

I can try resolving the conflicts. Whats the process to follow. Do I need permissions?

rickard-von-essen · 2017-10-11T11:14:22Z

@vijayinvites just pull these changes and rebase and open a new PR referencing this.

vijayinvites · 2017-10-11T16:24:54Z

@rickard-von-essen @mwhooker , I have resolved the merge conflicts and created a new PR as per your suggestion.

vijayinvites · 2017-10-13T17:43:41Z

I would like to see this gets included in 1.1.1 release.

mwhooker · 2017-10-13T18:54:02Z

Merged in #5444

gurry · 2018-01-16T13:19:00Z

Hi guys. Any idea when this feature will be available in a public release of Packer?

gurry · 2018-01-16T17:11:57Z

Ignore that. I just saw that the feature is available in the current release and is documented here: https://www.packer.io/docs/builders/hyperv-vmcx.html. Don't know why Google didn't throw up this page when I searched for creating vagrant boxes from existing VHDs using Packer. Or may be it was too far down in the results.

ghost · 2020-04-02T02:17:43Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

taliesins mentioned this pull request May 30, 2017

Hyper-v builder based on an existing hyper-v export. #4664

Closed

taliesins added builder/hyperv enhancement labels May 30, 2017

mwhooker added this to the v1.1.0 milestone May 30, 2017

pvandervelde mentioned this pull request Jun 19, 2017

Hyper-V builder assumes that host operating system shares network adapter with VMs #5023

Closed

taliesins mentioned this pull request Jul 1, 2017

builder/hyper-v should have provider to create a packer image from a VHD(X) file #4487

Closed

taliesins mentioned this pull request Aug 16, 2017

[wip] Add builder hyperv-vhd #5253

Closed

taliesins force-pushed the hyperv-vmcx branch from b0052c7 to fd6e37f Compare August 20, 2017 16:38

mwhooker added the need-make-fmt label Aug 31, 2017

mwhooker reviewed Aug 31, 2017

View reviewed changes

vijayinvites reviewed Sep 1, 2017

View reviewed changes

mwhooker force-pushed the hyperv-vmcx branch from a12750d to b76a861 Compare September 11, 2017 17:19

mwhooker modified the milestones: v1.2.0, v1.1.0 Sep 11, 2017

mwhooker removed the need-make-fmt label Sep 12, 2017

taliesins and others added 14 commits October 4, 2017 15:26

Only attach dvd drive if there is one

41473ca

Fix debug messages for cloning Add hyperv-vmcx as a builder from command line

Can specify an iso, vhd or vhdx for download. If it is a vhd or vhdx …

cb54209

…it is used as the hard drive for spinning up a new machine, importing an exported virtual machine or cloning a virtual machine. Can import a virtual machine from a folder Can clone an existing virtual machine

use common floppy_config instead of builder specific one

dc528f7

Add tests for floppy files and comm

If vhd or vhdx extension is specified for ISOUrls, we want to use an …

1db2480

…existing hard drive which means that we don't need to specify hard drive size Filepath.ext includes the dot

Test settings for clone from vm and import vmxc from path

9bef218

Don't try to mount vhd and vhdx files as dvd drive. Hard drives are m…

5efb88f

…ounted in the create vm step

Floppy directories are provided by default with common.floppydrives

7e9b397

make fmt

7802b72

rerun scripts/generate-plugins.go

2b0bd02

remove duplicate line

467325c

reformat docs

34976f1

use new method of building runner

220896c

make it clear that VHDs work as well as ISOs

63d6737

fix tests

51cacd5

taliesins force-pushed the hyperv-vmcx branch from c4698f2 to 51cacd5 Compare October 4, 2017 14:28

vijayinvites mentioned this pull request Oct 11, 2017

Hyperv vmcx builder and allow vhd/vhdx instead of ISO #5444

Merged

mwhooker closed this Oct 13, 2017

ghost locked and limited conversation to collaborators Apr 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hyperv vmcx builder and allow vhd/vhdx instead of ISO #4944

Hyperv vmcx builder and allow vhd/vhdx instead of ISO #4944

taliesins commented May 30, 2017

taliesins commented May 30, 2017

pvandervelde commented Jun 7, 2017

pvandervelde commented Jun 17, 2017

taliesins commented Aug 16, 2017

BSick7 commented Aug 16, 2017

pvandervelde commented Aug 16, 2017

taliesins commented Aug 16, 2017

BSick7 commented Aug 17, 2017

mwhooker Aug 31, 2017

mwhooker commented Aug 31, 2017

vijayinvites Sep 1, 2017

nebffa commented Sep 9, 2017

vijayinvites commented Sep 11, 2017

mwhooker commented Sep 11, 2017

pvandervelde commented Sep 11, 2017

pvandervelde commented Sep 12, 2017

mwhooker commented Sep 12, 2017

mwhooker commented Oct 9, 2017

pvandervelde commented Oct 9, 2017

pvandervelde commented Oct 9, 2017

mwhooker commented Oct 9, 2017

vijayinvites commented Oct 10, 2017

rickard-von-essen commented Oct 11, 2017

vijayinvites commented Oct 11, 2017 •

edited

Loading

vijayinvites commented Oct 13, 2017

mwhooker commented Oct 13, 2017

gurry commented Jan 16, 2018

gurry commented Jan 16, 2018

ghost commented Apr 2, 2020

Hyperv vmcx builder and allow vhd/vhdx instead of ISO #4944

Hyperv vmcx builder and allow vhd/vhdx instead of ISO #4944

Conversation

taliesins commented May 30, 2017

taliesins commented May 30, 2017

pvandervelde commented Jun 7, 2017

pvandervelde commented Jun 17, 2017

taliesins commented Aug 16, 2017

BSick7 commented Aug 16, 2017

pvandervelde commented Aug 16, 2017

taliesins commented Aug 16, 2017

BSick7 commented Aug 17, 2017

mwhooker Aug 31, 2017

Choose a reason for hiding this comment

mwhooker commented Aug 31, 2017

vijayinvites Sep 1, 2017

Choose a reason for hiding this comment

nebffa commented Sep 9, 2017

vijayinvites commented Sep 11, 2017

mwhooker commented Sep 11, 2017

pvandervelde commented Sep 11, 2017

pvandervelde commented Sep 12, 2017

mwhooker commented Sep 12, 2017

mwhooker commented Oct 9, 2017

pvandervelde commented Oct 9, 2017

pvandervelde commented Oct 9, 2017

mwhooker commented Oct 9, 2017

vijayinvites commented Oct 10, 2017

rickard-von-essen commented Oct 11, 2017

vijayinvites commented Oct 11, 2017 • edited Loading

vijayinvites commented Oct 13, 2017

mwhooker commented Oct 13, 2017

gurry commented Jan 16, 2018

gurry commented Jan 16, 2018

ghost commented Apr 2, 2020

vijayinvites commented Oct 11, 2017 •

edited

Loading