Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperv vmcx builder and allow vhd/vhdx instead of ISO #5444

Merged
merged 17 commits into from
Oct 13, 2017

Conversation

vijayinvites
Copy link
Contributor

Fix merge conflicts of the PR: #4944

@vijayinvites vijayinvites force-pushed the packer-vhdx branch 2 times, most recently from ce2da7a to db2d207 Compare October 11, 2017 16:08
Add documentation for hyperv vmcx
Fix debug messages for cloning

Add hyperv-vmcx as a builder from command line
@vijayinvites vijayinvites changed the title Packer vhdx Hyperv vmcx builder and allow vhd/vhdx instead of ISO Oct 11, 2017
@mwhooker
Copy link
Contributor

this is great, thanks!

@vijayinvites
Copy link
Contributor Author

vijayinvites commented Oct 12, 2017

@mwhooker, @rickard-von-essen I want to add some new features to the vmcx builder. This PR has been in incubation for long but not merged to the master. How do i send a separate PR with only my new changes. Ofcourse I need the vmcx PR code. i am new to this process flow, so sorry if this is basic question.

@SwampDragons
Copy link
Contributor

@pvandervelde any chance you can check this out and test this for us?

@mwhooker
Copy link
Contributor

@vijayinvites no problem, happy to help. This can be a bit complicated, so please ask for clarification if you need help.

The best way to do that is to make your new changes off of this branch. Push those new changes to to github, and then make a new PR. Once this PR is merged, we can look at your new PR which will just have your changes.

@pvandervelde
Copy link
Contributor

@SwampDragons Yeah can do. Will build a copy either tonight (NZ time) or sometime during the weekend and run some tests.

@SwampDragons
Copy link
Contributor

If you can do it tonight, we'd appreciate it. We're hoping to do a release tomorrow and want to squeeze this in.

@pvandervelde
Copy link
Contributor

@SwampDragons I will try but I can't promise anything. Might have to be tomorrow morning NZ time

@pvandervelde
Copy link
Contributor

@SwampDragons I managed to merge the change to master on my local machine, build a new version of packer and then run a few tests. I've tested on a Win10 host, building an Ubuntu linux box. I won't be able to test running on Win2016 until monday when I'm back in the office (I don't have a Win2016 box at home). The tests all worked fine so if you're happy with that you can release.

@vijayinvites
Copy link
Contributor Author

I have tested Win7 and Win10 builds on Win10 host. No issues that i know of.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants