-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyperv vmcx builder and allow vhd/vhdx instead of ISO #5444
Conversation
ce2da7a
to
db2d207
Compare
Add documentation for hyperv vmcx
Fix debug messages for cloning Add hyperv-vmcx as a builder from command line
db2d207
to
873e623
Compare
…it is used as the hard drive for spinning up a new machine, importing an exported virtual machine or cloning a virtual machine. Can import a virtual machine from a folder Can clone an existing virtual machine
Add tests for floppy files and comm
…existing hard drive which means that we don't need to specify hard drive size Filepath.ext includes the dot
…ounted in the create vm step
873e623
to
2655cf7
Compare
this is great, thanks! |
@mwhooker, @rickard-von-essen I want to add some new features to the vmcx builder. This PR has been in incubation for long but not merged to the master. How do i send a separate PR with only my new changes. Ofcourse I need the vmcx PR code. i am new to this process flow, so sorry if this is basic question. |
@pvandervelde any chance you can check this out and test this for us? |
@vijayinvites no problem, happy to help. This can be a bit complicated, so please ask for clarification if you need help. The best way to do that is to make your new changes off of this branch. Push those new changes to to github, and then make a new PR. Once this PR is merged, we can look at your new PR which will just have your changes. |
@SwampDragons Yeah can do. Will build a copy either tonight (NZ time) or sometime during the weekend and run some tests. |
If you can do it tonight, we'd appreciate it. We're hoping to do a release tomorrow and want to squeeze this in. |
@SwampDragons I will try but I can't promise anything. Might have to be tomorrow morning NZ time |
@SwampDragons I managed to merge the change to master on my local machine, build a new version of packer and then run a few tests. I've tested on a Win10 host, building an Ubuntu linux box. I won't be able to test running on Win2016 until monday when I'm back in the office (I don't have a Win2016 box at home). The tests all worked fine so if you're happy with that you can release. |
I have tested Win7 and Win10 builds on Win10 host. No issues that i know of. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fix merge conflicts of the PR: #4944