feat(lib): throw error when a token is used in a construct name #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
force-pushed
the
prevent-tokens-as-construct-ids
branch
from
416bb65 to
788496a
Compare
jsteinich
reviewed
Oct 22, 2021
DanielMSchmidt
force-pushed
the
prevent-tokens-as-construct-ids
branch
2 times, most recently
from
d7a5e25 to
2a58d70
Compare
jsteinich
requested changes
Oct 27, 2021
DanielMSchmidt
force-pushed
the
prevent-tokens-as-construct-ids
branch
from
9c4abca to
7e79efd
Compare
ansgarm
approved these changes
Oct 27, 2021
jsteinich
approved these changes
Oct 28, 2021
Co-authored-by: Jon Steinich <jsteinich@gmail.com>
Co-authored-by: Jon Steinich <jsteinich@gmail.com>
DanielMSchmidt
force-pushed
the
prevent-tokens-as-construct-ids
branch
from
7e79efd to
0e4f311
Compare
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1068
This should help folks with a better error message than the current one