chore: Rk/suggestions for error codes #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hashicorp/cdktf! This is a pretty superficial PR(only dealing with the text in error codes), and I'm unfamiliar with the testing practices for CDKTF. Could someone please help advise me on how to pass these PR tests at some point? 🙏 |
rkoron007
requested review from
ansgarm and
DanielMSchmidt
and removed request for
a team
rkoron007
changed the title
ansgarm
reviewed
Jan 22, 2024
Co-authored-by: Ansgar Mertens <ansgar@hashicorp.com>
Merged
ansgarm
pushed a commit
that referenced
this pull request
Jan 23, 2024
## 0.20.2 ### feat - feat(provider-generator): support renaming provider names in order to allow using two providers sharing the same name at the same time [\#3442](#3442) - feat(provider-generator): Ensure we have unique names for modules [\#3439](#3439) - feat(docs): Mention Maven examples in note on project setup page [\#3437](#3437) ### fix - fix(docs): Run prettier [\#3445](#3445) - fix(lib): support dot-seperated nested accessors [\#3444](#3444) - fix(docs): Update CLI docs to refer to Gradle instead of Maven [\#3434](#3434) - fix(lib): Print a warning with manual steps to move a module when UpgradeIds aspect encounters modules [\#3432](#3432) - fix(cli): don't prompt for providers during convert [\#3431](#3431) - fix(lib): inline zip creation [\#3428](#3428) ### chore - chore: Upgrade dependencies for @cdktf/hcl2cdk [\#3452](#3452) - chore: Upgrade dependencies for @cdktf/hcl2json [\#3451](#3451) - chore: Upgrade dependencies for @cdktf/provider-schema [\#3450](#3450) - chore: Upgrade dependencies for @cdktf/commons [\#3449](#3449) - chore: add CodeTabs component [\#3443](#3443) - chore(docs): update stacks documentation [\#3440](#3440) - chore: upgrade registry docs tool [\#3430](#3430) - chore: Upgrade dependencies for @cdktf/commons [\#3424](#3424) - chore(docs): fix currently-404 link to built-in templates [\#3418](#3418) - chore: Rk/suggestions for error codes [\#3417](#3417) - chore: fix updating script [\#3396](#3396)
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a quick surface-level overview of all of the error codes for brevity, tone, and style at Nara's request. Most of these are just small tweaks, but please feel free to push back on anything you don't like! ✨
Checklist