Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix currently-404 link to built-in templates #3418

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

jantman
Copy link
Contributor

@jantman jantman commented Jan 13, 2024

Description

The remote templates docs page has a built-in templates link that's currently 404; the templates were moved in ef76955. This PR updates the link to the new location of the templates.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@jantman jantman requested review from a team as code owners January 13, 2024 14:32
@jantman jantman requested review from DanielMSchmidt and Maed223 and removed request for a team January 13, 2024 14:32
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 13, 2024

CLA assistant check
All committers have signed the CLA.

@xiehan xiehan changed the title chore: Docs: fix currently-404 link to built-in templates chore(docs): fix currently-404 link to built-in templates Jan 17, 2024
@xiehan xiehan merged commit d287e12 into hashicorp:main Jan 18, 2024
417 of 419 checks passed
@DanielMSchmidt
Copy link
Contributor

Thanks for your help!

ansgarm pushed a commit that referenced this pull request Jan 23, 2024
## 0.20.2

### feat

- feat(provider-generator): support renaming provider names in order to
allow using two providers sharing the same name at the same time
[\#3442](#3442)
- feat(provider-generator): Ensure we have unique names for modules
[\#3439](#3439)
- feat(docs): Mention Maven examples in note on project setup page
[\#3437](#3437)

### fix

- fix(docs): Run prettier
[\#3445](#3445)
- fix(lib): support dot-seperated nested accessors
[\#3444](#3444)
- fix(docs): Update CLI docs to refer to Gradle instead of Maven
[\#3434](#3434)
- fix(lib): Print a warning with manual steps to move a module when
UpgradeIds aspect encounters modules
[\#3432](#3432)
- fix(cli): don't prompt for providers during convert
[\#3431](#3431)
- fix(lib): inline zip creation
[\#3428](#3428)

### chore

- chore: Upgrade dependencies for @cdktf/hcl2cdk
[\#3452](#3452)
- chore: Upgrade dependencies for @cdktf/hcl2json
[\#3451](#3451)
- chore: Upgrade dependencies for @cdktf/provider-schema
[\#3450](#3450)
- chore: Upgrade dependencies for @cdktf/commons
[\#3449](#3449)
- chore: add CodeTabs component
[\#3443](#3443)
- chore(docs): update stacks documentation
[\#3440](#3440)
- chore: upgrade registry docs tool
[\#3430](#3430)
- chore: Upgrade dependencies for @cdktf/commons
[\#3424](#3424)
- chore(docs): fix currently-404 link to built-in templates
[\#3418](#3418)
- chore: Rk/suggestions for error codes
[\#3417](#3417)
- chore: fix updating script
[\#3396](#3396)
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants