feat(provider-generator): Skip definition attribute for aws_quicksight_analysis.definition data source #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ansgarm
commented
Sep 9, 2024
ansgarm
commented
- feat(provider-generator): Skip definition attribute for aws_quicksight_analysis.definition data source as it produces too long names for Java to compile
- chore(docs): Document skipped data source
- chore(tests): Add test for skipping attribute type attributes
…t_analysis.definition data source as it produces too long names for Java to compile
ansgarm
requested review from
mutahhir and
DanielMSchmidt
and removed request for
a team
ansgarm
changed the title
ansgarm
commented
Sep 9, 2024
...provider-generator/lib/get/__tests__/generator/__snapshots__/skipped-attributes.test.ts.snap
Outdated
Show resolved
Hide resolved
mutahhir
approved these changes
Sep 9, 2024
…getAnyAttribute for skipped attributes since the latter doesn't actually exist
ansgarm
added a commit
that referenced
this pull request
Sep 23, 2024
## 0.20.9 ### feat - feat(provider-generator): Skip definition attribute for aws_quicksight_analysis.definition data source [\#3725](#3725) ### fix - fix(lib): render empty string as quotes [\#3683](#3683) - fix(lib): Correct types for allowedAccountIds & forbiddenAccountIds in S3Backend [\#3669](#3669) - fix(provider-generator): fix collision for Go for resources named version [\#3670](#3670) - fix(release): Don't validate single commit for semanticity [\#3715](#3715) ### chore - chore(deps): pin trusted workflows based on HashiCorp TSCCR [\#3714](#3714) - chore(deps): pin trusted workflows based on HashiCorp TSCCR [\#3700](#3700) - chore: add extra pr for a catch-all package update [\#3699](#3699) - chore(deps): pin trusted workflows based on HashiCorp TSCCR [\#3693](#3693) - chore: Upgrade dependencies for JSII [\#3692](#3692) - chore: Upgrade dependencies for util [\#3691](#3691) - chore: Upgrade dependencies for cli [\#3690](#3690) - chore: Upgrade dependencies for lib [\#3689](#3689) - chore(deps): pin trusted workflows based on HashiCorp TSCCR [\#3682](#3682) - chore: Upgrade dependencies for JSII [\#3679](#3679) - chore(deps): pin trusted workflows based on HashiCorp TSCCR [\#3672](#3672) - chore: added index pages for each library to the docs [\#3671](#3671) - chore: reorganize API documentation [\#3668](#3668) - chore(deps): pin trusted workflows based on HashiCorp TSCCR [\#3666](#3666) - chore: Upgrade dependencies for util [\#3650](#3650) - chore: Upgrade dependencies for cli [\#3649](#3649) - chore: Upgrade dependencies for JSII [\#3648](#3648) - chore: Upgrade dependencies for lib [\#3647](#3647) - chore(hcl2cdk): fix yarn command in Readme.md [\#3624](#3624) --------- Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com>
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.