Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable go to module output declaration from reference #1007

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Jul 19, 2022

This PR pulls in the latest updates to hcl-lang and terraform-schema:

Enabling go to module output declaration from reference.

UX before

2022-07-18 14 32 48

UX after

2022-07-18 14 34 33

Closes hashicorp/vscode-terraform#706

@dbanck dbanck added the enhancement New feature or request label Jul 19, 2022
@dbanck dbanck added this to the v0.29.0 milestone Jul 19, 2022
@dbanck dbanck requested a review from a team as a code owner July 19, 2022 10:25
@dbanck dbanck self-assigned this Jul 19, 2022
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

The test failures seem unrelated - we can take a look at them as part of #862 and/or #445

Some of the mocking issues I'm temporarily addressing in #1006 but we'll need to revisit the value of Repeatability once all the optimization PRs are in:

@dbanck dbanck merged commit 2c66a8b into main Jul 19, 2022
@dbanck dbanck deleted the d-bump-tfschmea-hcllang branch July 19, 2022 12:02
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go to module output declaration from reference
2 participants