Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump LSP structs to gopls 0.7.0 #608

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Bump LSP structs to gopls 0.7.0 #608

merged 2 commits into from
Aug 4, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Aug 3, 2021

Closes #604

This will also allow us to bump the upstream LSP client library in the VS Code extension which would otherwise make the server crash upon initialization if bumped to 7.0.0 currently:

Error for "initialize" (ID 0): [-32602] invalid parameters: json: cannot unmarshal number into Go struct field RenameClientCapabilities.capabilities.textDocument.rename.prepareSupportDefaultBehavior of type bool

Updated structs seem to work seamlessly with 8.0.0-next.1 version of the upstream LSP client library.

@radeksimko radeksimko added the dependencies Auto-pinning label Aug 3, 2021
@radeksimko radeksimko changed the title Bump LSP structs Bump LSP structs to gopls 0.7.0 Aug 3, 2021
@radeksimko radeksimko merged commit ebb5594 into main Aug 4, 2021
@radeksimko radeksimko deleted the bump-lsp-structs branch August 4, 2021 11:05
@radeksimko radeksimko added this to the v0.21.0 milestone Aug 23, 2021
jpogran added a commit to hashicorp/vscode-terraform that referenced this pull request Sep 16, 2021
This updates the vscode-languageclient library to the 7.0.0 release, which requires the minimum vs code engine to be 1.52.0.

The vscode-languageclient 7.0.0 release is the current supported release, but we pinned to 7.0.0-next.12. We shouldn't be running on the interim releases, but we were waiting on hashicorp/terraform-ls#608 to merge to support the changed jsonrpc constructs in 7.0.0. Now that that is merged, released, and in the wild for a significant amount of time we can move to the 7.0.0 vscode-languageclient version.

This requires us to increment the minimum supported version of VS Code to 1.52.0. This means any user with a VS Code version lower than 1.52.0 will not see an updated extension in the marketplace, but will still receive updated terraform-ls releases through the automatic updater.
jpogran added a commit to hashicorp/vscode-terraform that referenced this pull request Sep 22, 2021
This updates the vscode-languageclient library to the 7.0.0 release, which requires the minimum vs code engine to be 1.52.0.

The vscode-languageclient 7.0.0 release is the current supported release, but we pinned to 7.0.0-next.12. We shouldn't be running on the interim releases, but we were waiting on hashicorp/terraform-ls#608 to merge to support the changed jsonrpc constructs in 7.0.0. Now that that is merged, released, and in the wild for a significant amount of time we can move to the 7.0.0 vscode-languageclient version.

This requires us to increment the minimum supported version of VS Code to 1.52.0. This means any user with a VS Code version lower than 1.52.0 will not see an updated extension in the marketplace, but will still receive updated terraform-ls releases through the automatic updater.
jpogran added a commit to hashicorp/vscode-terraform that referenced this pull request Sep 22, 2021
This updates the vscode-languageclient library to the 7.0.0 release, which requires the minimum vs code engine to be 1.52.0.

The vscode-languageclient 7.0.0 release is the current supported release, but we pinned to 7.0.0-next.12. We shouldn't be running on the interim releases, but we were waiting on hashicorp/terraform-ls#608 to merge to support the changed jsonrpc constructs in 7.0.0. Now that that is merged, released, and in the wild for a significant amount of time we can move to the 7.0.0 vscode-languageclient version.

This requires us to increment the minimum supported version of VS Code to 1.52.0. This means any user with a VS Code version lower than 1.52.0 will not see an updated extension in the marketplace, but will still receive updated terraform-ls releases through the automatic updater.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internal: Update LSP structs
1 participant