Reset npm lock file version to 1 #780
Conversation
jpogran
force-pushed
the
reset-npm-lockfile-version
branch
2 times, most recently
from
91f91f1 to
256247e
Compare
There was a problem hiding this comment.
Just for posterity LS 0.21.0 with the mentioned patch hashicorp/terraform-ls#608 was released on 23rd August, so almost 1 month, which seems like a reasonable time period, but I would probably prefer to first release the existing (already merged) PRs and queue up this change for the next release, just to give folks a little more time.
After all the UX without the patch is not great, so if we can even further reduce the chance of people running into it, it would be nice.
|
Putting this as draft until existing release is completed |
|
2.15.0 is out, so this is now safe for merge, subject to a rebase. |
jpogran
force-pushed
the
reset-npm-lockfile-version
branch
from
256247e to
a4e8cd6
Compare
This updates the vscode-languageclient library to the 7.0.0 release, which requires the minimum vs code engine to be 1.52.0. The vscode-languageclient 7.0.0 release is the current supported release, but we pinned to 7.0.0-next.12. We shouldn't be running on the interim releases, but we were waiting on hashicorp/terraform-ls#608 to merge to support the changed jsonrpc constructs in 7.0.0. Now that that is merged, released, and in the wild for a significant amount of time we can move to the 7.0.0 vscode-languageclient version. This requires us to increment the minimum supported version of VS Code to 1.52.0. This means any user with a VS Code version lower than 1.52.0 will not see an updated extension in the marketplace, but will still receive updated terraform-ls releases through the automatic updater.
jpogran
force-pushed
the
reset-npm-lockfile-version
branch
from
a4e8cd6 to
e619b1f
Compare
|
TODO: fixup commit message |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This sets the npm lockfile version back to 1, which aligns the npm version to the version of node we target and also updates the vscode-languageclient library to the 7.0.0 release, which requires the minimum vs code engine to be 1.52.0.
We currently use node v14.X as the targeted version, which uses npm v6.X. In commit 8bc325c we updated the lockfile to version 2 using npm v7.X. This results in a lockfile mismatch when using node v14.X and npm v6.X to do an
npm install. While the npm v7.X lockfile is compatible with npm 6, this does produce a warning that the wrong dependency version may be downloaded. A future commit will handle the migration to npm 7 when we move off of node v14.X.The vscode-languageclient 7.0.0 release is the current supported release, but we pinned to 7.0.0-next.12. We shouldn't be running on the interim releases, but we were waiting on hashicorp/terraform-ls#608 to merge to support the changed jsonrpc constructs in 7.0.0. Now that that is merged, released, and in the wild for a significant amount of time we can move to the 7.0.0 vscode-languageclient version.
This requires us to increment the minimum supported version of VS Code to 1.52.0. This means any user with a VS Code version lower than 1.52.0 will not see an updated extension in the marketplace, but will still receive updated terraform-ls releases through the automatic updater.
This supersedes #754