Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce list module providers command #712

Merged
merged 7 commits into from
Nov 16, 2021
Merged

Introduce list module providers command #712

merged 7 commits into from
Nov 16, 2021

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Nov 12, 2021

This PR adds a new workspace command module.providers.

@dbanck dbanck force-pushed the f-701-provider-tree-command branch from 821683f to d59691a Compare November 12, 2021 16:18
@dbanck dbanck marked this pull request as ready for review November 12, 2021 16:19
@dbanck dbanck requested a review from a team November 12, 2021 16:21
@dbanck dbanck mentioned this pull request Nov 12, 2021
Merged
radeksimko
radeksimko suggested changes Nov 12, 2021
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments in-line, most are minor - except for the nil check.

All-in-all good work!

internal/langserver/handlers/command/module_providers.go Outdated Show resolved Hide resolved
internal/langserver/handlers/command/module_providers.go Outdated Show resolved Hide resolved
internal/langserver/handlers/execute_command_module_providers_test.go Show resolved Hide resolved
internal/langserver/handlers/execute_command_module_providers_test.go Outdated Show resolved Hide resolved
@dbanck dbanck force-pushed the f-701-provider-tree-command branch from d59691a to f5c3bc5 Compare November 15, 2021 14:57
@dbanck dbanck requested a review from radeksimko November 16, 2021 09:18
radeksimko
radeksimko approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last comment about the docs URL generation, feel free to merge once that is addressed. 🚀

internal/langserver/handlers/command/module_providers.go Outdated Show resolved Hide resolved
@dbanck @radeksimko
Apply suggestions from code review
f580515 
Co-authored-by: Radek Simko <radek.simko@gmail.com>
@dbanck dbanck merged commit 1620784 into main Nov 16, 2021
@dbanck dbanck deleted the f-701-provider-tree-command branch November 16, 2021 12:23
This was referenced Nov 18, 2021
Open
Open
Merged
@radeksimko radeksimko mentioned this pull request Nov 22, 2021
Closed
@radeksimko radeksimko mentioned this pull request Dec 1, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbanck @radeksimko