Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs with new workspace commands #721

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Update docs with new workspace commands #721

merged 3 commits into from
Nov 23, 2021

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Nov 19, 2021

#632 and #712 introduced two new workspace commands. This PR updates the docs for both commands

radeksimko
radeksimko reviewed Nov 22, 2021
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these docs.

I left some mostly minor suggestions with examples etc. to hopefully make it a little easier to understand for future readers.

docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
internal/langserver/handlers/command/module_calls.go Show resolved Hide resolved
@dbanck @radeksimko
Apply suggestions from code review
6dc9b06 
Co-authored-by: Radek Simko <radek.simko@gmail.com>
@dbanck
Copy link
Member Author

dbanck commented Nov 22, 2021

Thanks a lot for your helpful suggestions. I've applied them all.

@dbanck dbanck merged commit cbc8cd2 into main Nov 23, 2021
@dbanck dbanck deleted the f-command-docs branch November 23, 2021 15:24
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbanck @radeksimko