Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
resource/aws_directory_service_directory: Remove deprecated (helper/s…
Browse files Browse the repository at this point in the history
…chema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial()

Reference: #12083
Reference: #12087

Previously:

```
aws/resource_aws_directory_service_directory.go:317:2: R008: deprecated (schema.ResourceData).SetPartial
aws/resource_aws_directory_service_directory.go:391:3: R008: deprecated (schema.ResourceData).SetPartial
```

Output from acceptance testing (failure present on master):

```
--- PASS: TestAccAWSDirectoryServiceDirectory_basic (488.80s)
--- PASS: TestAccAWSDirectoryServiceDirectory_connector (968.66s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoft (1688.96s)
--- PASS: TestAccAWSDirectoryServiceDirectory_microsoftStandard (1824.96s)
--- PASS: TestAccAWSDirectoryServiceDirectory_tags (623.46s)
--- PASS: TestAccAWSDirectoryServiceDirectory_withAliasAndSso (584.98s)
```
bflad committed Mar 19, 2020
1 parent ce824da commit 702e98f
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions aws/resource_aws_directory_service_directory.go
Original file line number Diff line number Diff line change
@@ -314,8 +314,6 @@ func createActiveDirectoryService(dsconn *directoryservice.DirectoryService, d *
}

func enableDirectoryServiceSso(dsconn *directoryservice.DirectoryService, d *schema.ResourceData) error {
d.SetPartial("enable_sso")

if v, ok := d.GetOk("enable_sso"); ok && v.(bool) {
log.Printf("[DEBUG] Enabling SSO for DS directory %q", d.Id())
if _, err := dsconn.EnableSso(&directoryservice.EnableSsoInput{
@@ -388,8 +386,6 @@ func resourceAwsDirectoryServiceDirectoryCreate(d *schema.ResourceData, meta int
}

if v, ok := d.GetOk("alias"); ok {
d.SetPartial("alias")

input := directoryservice.CreateAliasInput{
DirectoryId: aws.String(d.Id()),
Alias: aws.String(v.(string)),

0 comments on commit 702e98f

Please sign in to comment.