-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and enable tfproviderlint R007 and R008 checks: Deprecated d.Partial() and d.SetPartial() #12083
Closed
67 of 68 tasks
Labels
provider
Pertains to the provider itself, rather than any interaction with AWS.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone
Comments
bflad
added
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
provider
Pertains to the provider itself, rather than any interaction with AWS.
labels
Feb 19, 2020
github-actions
bot
added
the
needs-triage
Waiting for first response or review from a maintainer.
label
Feb 19, 2020
bflad
removed
the
needs-triage
Waiting for first response or review from a maintainer.
label
Feb 19, 2020
bflad
added a commit
that referenced
this issue
Feb 19, 2020
Reference: #12074 Gaps in `tfproviderlint`/`awsproviderlint` checking are covered by the following issues: Reference: #11888 (fix and enable AWSAT001) Reference: #9950 (fix and enable AT003) Reference: #11862 (fix and enable AT005) Reference: #9951 (fix and enable R001) Reference: #9952 (fix and enable R002) Reference: #9953 (fix and enable R003) Reference: #11863 (fix and enable R005) Reference: #11864 (fix and enable R006) Reference: #12083 (fix and enable R007, R008) Reference: #9955 (fix and enable S006) Reference: #9956 (fix and enable S018) Reference: #11865 (fix and enable S020) Reference: #11866 (fix and enable S022) Reference: #11867 (fix and enable S023) Reference: #11868 (fix and enable S024) Reference: #11869 (fix and enable S031) Reference: #11870 (fix and enable S032) Reference: #11871 (fix and enable S033) Reference: #11872 (fix and enable V001) Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
|
bflad
added a commit
that referenced
this issue
Mar 10, 2020
Reference: #12074 Gaps in `tfproviderlint`/`awsproviderlint` checking are covered by the following issues: Reference: #11888 (fix and enable AWSAT001) Reference: #9950 (fix and enable AT003) Reference: #11862 (fix and enable AT005) Reference: #9951 (fix and enable R001) Reference: #9952 (fix and enable R002) Reference: #9953 (fix and enable R003) Reference: #11863 (fix and enable R005) Reference: #11864 (fix and enable R006) Reference: #12083 (fix and enable R007, R008) Reference: #9955 (fix and enable S006) Reference: #9956 (fix and enable S018) Reference: #11865 (fix and enable S020) Reference: #11866 (fix and enable S022) Reference: #11867 (fix and enable S023) Reference: #11868 (fix and enable S024) Reference: #11869 (fix and enable S031) Reference: #11870 (fix and enable S032) Reference: #11871 (fix and enable S033) Reference: #11872 (fix and enable V001) Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
bflad
added a commit
that referenced
this issue
Mar 19, 2020
…() and (helper/schema.ResourceData).SetPartial() Reference: #12083 Reference: #12087 Previously: ``` aws/resource_aws_docdb_cluster.go:620:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster.go:626:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster.go:672:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:345:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:351:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:357:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:363:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:413:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_parameter_group.go:185:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_docdb_cluster_parameter_group.go:230:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_parameter_group.go:241:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_parameter_group.go:244:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_docdb_subnet_group.go:179:3: R008: deprecated (schema.ResourceData).SetPartial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSDocDBCluster_backupsUpdate (260.19s) --- PASS: TestAccAWSDocDBCluster_basic (130.28s) --- PASS: TestAccAWSDocDBCluster_encrypted (203.87s) --- PASS: TestAccAWSDocDBCluster_generatedName (130.17s) --- PASS: TestAccAWSDocDBCluster_kmsKey (233.75s) --- PASS: TestAccAWSDocDBCluster_missingUserNameCausesError (4.93s) --- PASS: TestAccAWSDocDBCluster_namePrefix (129.97s) --- PASS: TestAccAWSDocDBCluster_Port (369.93s) --- PASS: TestAccAWSDocDBCluster_takeFinalSnapshot (252.47s) --- PASS: TestAccAWSDocDBCluster_updateCloudwatchLogsExports (227.06s) --- PASS: TestAccAWSDocDBCluster_updateTags (235.10s) --- PASS: TestAccAWSDocDBClusterInstance_az (714.97s) --- PASS: TestAccAWSDocDBClusterInstance_basic (1416.43s) --- PASS: TestAccAWSDocDBClusterInstance_disappears (748.64s) --- PASS: TestAccAWSDocDBClusterInstance_generatedName (753.18s) --- PASS: TestAccAWSDocDBClusterInstance_kmsKey (821.87s) --- PASS: TestAccAWSDocDBClusterInstance_namePrefix (764.04s) --- PASS: TestAccAWSDocDBClusterParameterGroup_basic (43.89s) --- PASS: TestAccAWSDocDBClusterParameterGroup_Description (31.42s) --- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (13.72s) --- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (27.74s) --- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (48.18s) --- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (50.36s) --- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (65.89s) --- PASS: TestAccAWSDocDBSubnetGroup_basic (57.22s) --- PASS: TestAccAWSDocDBSubnetGroup_disappears (31.33s) --- PASS: TestAccAWSDocDBSubnetGroup_generatedName (44.49s) --- PASS: TestAccAWSDocDBSubnetGroup_namePrefix (46.41s) --- PASS: TestAccAWSDocDBSubnetGroup_updateDescription (67.20s) ```
bflad
added a commit
that referenced
this issue
Mar 19, 2020
…al() and (helper/schema.ResourceData).SetPartial() Reference: #12083 Reference: #12087 Previously: ``` aws/resource_aws_neptune_cluster.go:597:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster.go:684:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_instance.go:384:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_instance.go:390:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_instance.go:396:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_instance.go:402:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_instance.go:451:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_parameter_group.go:185:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_cluster_parameter_group.go:226:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_parameter_group.go:237:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_parameter_group.go:240:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_event_subscription.go:209:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_event_subscription.go:265:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_event_subscription.go:266:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_event_subscription.go:267:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_event_subscription.go:268:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_event_subscription.go:278:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_event_subscription.go:320:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_event_subscription.go:323:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_parameter_group.go:100:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_parameter_group.go:101:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_parameter_group.go:102:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_parameter_group.go:103:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_parameter_group.go:104:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_parameter_group.go:181:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_parameter_group.go:259:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_parameter_group.go:269:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_parameter_group.go:272:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_subnet_group.go:195:3: R008: deprecated (schema.ResourceData).SetPartial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSNeptuneCluster_backupsUpdate (297.92s) --- PASS: TestAccAWSNeptuneCluster_basic (168.78s) --- PASS: TestAccAWSNeptuneCluster_deleteProtection (212.60s) --- PASS: TestAccAWSNeptuneCluster_encrypted (175.61s) --- PASS: TestAccAWSNeptuneCluster_iamAuth (193.62s) --- PASS: TestAccAWSNeptuneCluster_kmsKey (195.57s) --- PASS: TestAccAWSNeptuneCluster_namePrefix (154.44s) --- PASS: TestAccAWSNeptuneCluster_tags (209.12s) --- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (254.53s) --- PASS: TestAccAWSNeptuneCluster_updateCloudwatchLogsExports (233.15s) --- PASS: TestAccAWSNeptuneCluster_updateIamRoles (195.20s) --- PASS: TestAccAWSNeptuneClusterInstance_basic (1755.23s) --- PASS: TestAccAWSNeptuneClusterInstance_generatedName (785.56s) --- PASS: TestAccAWSNeptuneClusterInstance_kmsKey (835.57s) --- PASS: TestAccAWSNeptuneClusterInstance_namePrefix (807.49s) --- PASS: TestAccAWSNeptuneClusterInstance_withaz (925.05s) --- PASS: TestAccAWSNeptuneClusterInstance_withSubnetGroup (783.88s) --- PASS: TestAccAWSNeptuneClusterParameterGroup_basic (17.40s) --- PASS: TestAccAWSNeptuneClusterParameterGroup_Description (17.46s) --- PASS: TestAccAWSNeptuneClusterParameterGroup_generatedName (17.68s) --- PASS: TestAccAWSNeptuneClusterParameterGroup_namePrefix (20.77s) --- PASS: TestAccAWSNeptuneClusterParameterGroup_Parameter (31.24s) --- PASS: TestAccAWSNeptuneClusterParameterGroup_Tags (64.82s) --- PASS: TestAccAWSNeptuneEventSubscription_basic (150.00s) --- PASS: TestAccAWSNeptuneEventSubscription_withCategories (124.64s) --- PASS: TestAccAWSNeptuneEventSubscription_withPrefix (123.58s) --- PASS: TestAccAWSNeptuneEventSubscription_withSourceIds (97.81s) --- PASS: TestAccAWSNeptuneParameterGroup_basic (28.51s) --- PASS: TestAccAWSNeptuneParameterGroup_Description (22.30s) --- PASS: TestAccAWSNeptuneParameterGroup_Parameter (114.91s) --- PASS: TestAccAWSNeptuneParameterGroup_Tags (60.91s) --- PASS: TestAccAWSNeptuneSubnetGroup_basic (46.02s) --- PASS: TestAccAWSNeptuneSubnetGroup_generatedName (49.96s) --- PASS: TestAccAWSNeptuneSubnetGroup_namePrefix (48.39s) --- PASS: TestAccAWSNeptuneSubnetGroup_updateDescription (76.13s) ```
bflad
added a commit
that referenced
this issue
Mar 19, 2020
… and (helper/schema.ResourceData).SetPartial() Reference: #12083 Reference: #12087 Previously: ``` aws/resource_aws_elb.go:331:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_elb.go:332:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:333:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:334:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:335:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:336:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:337:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:479:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_elb.go:545:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:581:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:619:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:620:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:621:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:647:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:667:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:688:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:705:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:742:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:794:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:810:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_proxy_protocol_policy.go:122:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_proxy_protocol_policy.go:151:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_proxy_protocol_policy.go:63:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_proxy_protocol_policy.go:65:2: R008: deprecated (schema.ResourceData).SetPartial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSELB_AccessLogs_disabled (275.08s) --- PASS: TestAccAWSELB_AccessLogs_enabled (88.33s) --- PASS: TestAccAWSELB_availabilityZones (67.63s) --- PASS: TestAccAWSELB_basic (40.56s) --- PASS: TestAccAWSELB_ConnectionDraining (222.97s) --- PASS: TestAccAWSELB_disappears (132.48s) --- PASS: TestAccAWSELB_fullCharacterRange (33.99s) --- PASS: TestAccAWSELB_generatedName (26.07s) --- PASS: TestAccAWSELB_generatesNameForZeroValue (84.50s) --- PASS: TestAccAWSELB_HealthCheck (219.59s) --- PASS: TestAccAWSELB_InstanceAttaching (173.37s) --- PASS: TestAccAWSELB_listener (101.85s) --- PASS: TestAccAWSELB_Listener_SSLCertificateID_IAMServerCertificate (42.66s) --- PASS: TestAccAWSELB_namePrefix (59.05s) --- PASS: TestAccAWSELB_SecurityGroups (171.23s) --- PASS: TestAccAWSELB_swap_subnets (276.60s) --- PASS: TestAccAWSELB_tags (95.49s) --- PASS: TestAccAWSELB_Timeout (141.20s) --- PASS: TestAccAWSProxyProtocolPolicy_basic (40.72s) ```
bflad
added a commit
that referenced
this issue
Mar 19, 2020
…a).Partial() and (helper/schema.ResourceData).SetPartial() Reference: #12083 Reference: #12087 Previously: ``` aws/resource_aws_route53_resolver_endpoint.go:199:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_route53_resolver_endpoint.go:219:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_endpoint.go:264:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_endpoint.go:272:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_endpoint.go:275:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_route53_resolver_rule.go:191:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_route53_resolver_rule.go:220:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_rule.go:221:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_rule.go:222:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_rule.go:230:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_rule.go:233:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAwsRoute53ResolverEndpoint_basicInbound (102.08s) --- PASS: TestAccAwsRoute53ResolverEndpoint_updateOutbound (446.81s) --- PASS: TestAccAwsRoute53ResolverRule_basic (39.84s) --- PASS: TestAccAwsRoute53ResolverRule_forward (316.33s) --- PASS: TestAccAwsRoute53ResolverRule_forwardEndpointRecreate (448.03s) --- PASS: TestAccAwsRoute53ResolverRule_tags (66.35s) --- PASS: TestAccAwsRoute53ResolverRule_updateName (62.64s) ```
bflad
added a commit
that referenced
this issue
Mar 19, 2020
…ial() and (helper/schema.ResourceData).SetPartial() Reference: #12083 Reference: #12087 Previously: ``` aws/resource_aws_redshift_cluster.go:644:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_cluster.go:653:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_cluster.go:774:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_cluster.go:828:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_event_subscription.go:191:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_event_subscription.go:216:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_event_subscription.go:219:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_parameter_group.go:168:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_parameter_group.go:200:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_parameter_group.go:210:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_parameter_group.go:213:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_snapshot_copy_grant.go:118:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_snapshot_copy_grant.go:127:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_snapshot_copy_grant.go:130:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_snapshot_schedule.go:142:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_snapshot_schedule.go:151:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_snapshot_schedule.go:168:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_subnet_group.go:127:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_subnet_group.go:136:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_subnet_group.go:162:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing (failure present on master): ``` --- PASS: TestAccAWSRedshiftCluster_basic (374.33s) --- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (664.68s) --- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (2088.45s) --- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (1868.48s) --- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (959.29s) --- PASS: TestAccAWSRedshiftCluster_forceNewUsername (1672.20s) --- PASS: TestAccAWSRedshiftCluster_iamRoles (824.30s) --- PASS: TestAccAWSRedshiftCluster_kmsKey (1387.64s) --- PASS: TestAccAWSRedshiftCluster_loggingEnabled (1178.50s) --- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (1435.60s) --- PASS: TestAccAWSRedshiftCluster_snapshotCopy (434.54s) --- PASS: TestAccAWSRedshiftCluster_tags (476.81s) --- PASS: TestAccAWSRedshiftCluster_updateNodeCount (3699.47s) --- PASS: TestAccAWSRedshiftCluster_updateNodeType (1911.25s) --- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (1449.68s) --- PASS: TestAccAWSRedshiftEventSubscription_basicUpdate (41.61s) --- PASS: TestAccAWSRedshiftEventSubscription_categoryUpdate (51.13s) --- PASS: TestAccAWSRedshiftEventSubscription_tagsUpdate (145.74s) --- PASS: TestAccAWSRedshiftEventSubscription_withPrefix (44.47s) --- PASS: TestAccAWSRedshiftEventSubscription_withSourceIds (84.82s) --- PASS: TestAccAWSRedshiftParameterGroup_basic (44.40s) --- PASS: TestAccAWSRedshiftParameterGroup_withoutParameters (76.56s) --- PASS: TestAccAWSRedshiftParameterGroup_withParameters (27.47s) --- PASS: TestAccAWSRedshiftParameterGroup_withTags (101.82s) --- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Basic (34.09s) --- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Update (74.12s) --- FAIL: TestAccAWSRedshiftSnapshotSchedule_withForceDestroy (314.27s) --- PASS: TestAccAWSRedshiftSnapshotSchedule_basic (55.17s) --- PASS: TestAccAWSRedshiftSnapshotSchedule_withDescription (48.15s) --- PASS: TestAccAWSRedshiftSnapshotSchedule_withIdentifierPrefix (44.69s) --- PASS: TestAccAWSRedshiftSnapshotSchedule_withMultipleDefinition (37.15s) --- PASS: TestAccAWSRedshiftSnapshotSchedule_withTags (97.33s) --- PASS: TestAccAWSRedshiftSubnetGroup_basic (41.15s) --- PASS: TestAccAWSRedshiftSubnetGroup_tags (64.37s) --- PASS: TestAccAWSRedshiftSubnetGroup_updateDescription (67.68s) --- PASS: TestAccAWSRedshiftSubnetGroup_updateSubnetIds (59.10s) ```
bflad
added a commit
that referenced
this issue
Mar 19, 2020
…tial() and (helper/schema.ResourceData).SetPartial() Reference: #12083 Reference: #12087 Previously: ``` aws/resource_aws_sagemaker_endpoint.go:135:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_endpoint.go:144:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_sagemaker_endpoint.go:156:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_sagemaker_endpoint.go:168:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_model.go:284:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_model.go:294:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_notebook_instance.go:217:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_notebook_instance.go:226:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_sagemaker_notebook_instance.go:328:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSSagemakerEndpoint_basic (485.91s) --- PASS: TestAccAWSSagemakerEndpoint_EndpointConfigName (852.16s) --- PASS: TestAccAWSSagemakerEndpoint_Tags (525.67s) --- PASS: TestAccAWSSagemakerModel_basic (47.36s) --- PASS: TestAccAWSSagemakerModel_containers (35.84s) --- PASS: TestAccAWSSagemakerModel_networkIsolation (59.84s) --- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (33.08s) --- PASS: TestAccAWSSagemakerModel_primaryContainerHostname (30.86s) --- PASS: TestAccAWSSagemakerModel_primaryContainerModelDataUrl (57.54s) --- PASS: TestAccAWSSagemakerModel_tags (42.35s) --- PASS: TestAccAWSSagemakerModel_vpcConfig (62.13s) --- PASS: TestAccAWSSagemakerNotebookInstance_basic (359.34s) --- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (714.40s) --- PASS: TestAccAWSSagemakerNotebookInstance_disappears (396.62s) --- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (296.66s) --- PASS: TestAccAWSSagemakerNotebookInstance_tags (411.90s) --- PASS: TestAccAWSSagemakerNotebookInstance_update (625.72s) ```
bflad
added a commit
that referenced
this issue
Mar 19, 2020
…chema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() Reference: #12083 Reference: #12087 Previously: ``` aws/resource_aws_directory_service_directory.go:317:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_directory_service_directory.go:391:3: R008: deprecated (schema.ResourceData).SetPartial ``` Output from acceptance testing (failure present on master): ``` --- PASS: TestAccAWSDirectoryServiceDirectory_basic (488.80s) --- PASS: TestAccAWSDirectoryServiceDirectory_connector (968.66s) --- PASS: TestAccAWSDirectoryServiceDirectory_microsoft (1688.96s) --- PASS: TestAccAWSDirectoryServiceDirectory_microsoftStandard (1824.96s) --- PASS: TestAccAWSDirectoryServiceDirectory_tags (623.46s) --- PASS: TestAccAWSDirectoryServiceDirectory_withAliasAndSso (584.98s) ```
bflad
added a commit
that referenced
this issue
Mar 19, 2020
…urceData).Partial() and (helper/schema.ResourceData).SetPartial() Reference: #12083 Reference: #12087 Previously: ``` aws/resource_aws_autoscaling_group.go:949:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_autoscaling_group.go:953:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_autoscaling_group.go:959:3: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (221.26s) --- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (300.96s) --- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (82.26s) --- PASS: TestAccAWSAutoScalingGroup_basic (385.26s) --- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (78.87s) --- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (96.80s) --- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (193.31s) --- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (360.02s) --- PASS: TestAccAWSAutoScalingGroup_launchTemplate (73.68s) --- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (55.71s) --- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (170.76s) --- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (569.35s) --- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (111.74s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (52.49s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (48.81s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (145.14s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (80.84s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (45.67s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (106.02s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (110.26s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (109.23s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (81.39s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (81.21s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (167.25s) --- PASS: TestAccAWSAutoScalingGroup_namePrefix (54.31s) --- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (164.35s) --- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (178.65s) --- PASS: TestAccAWSAutoScalingGroup_tags (215.41s) --- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (291.79s) --- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (113.05s) --- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (79.41s) --- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (372.04s) --- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (353.81s) --- PASS: TestAccAWSAutoScalingGroup_withMetrics (173.70s) --- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (177.06s) ```
bflad
added a commit
that referenced
this issue
Mar 19, 2020
… and (helper/schema.ResourceData).SetPartial() Reference: #12083 Reference: #12087 Previously: ``` aws/resource_aws_ami.go:414:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami.go:434:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_ami.go:437:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami_copy.go:218:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami_copy.go:220:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_ami_copy.go:221:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami_from_instance.go:200:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami_from_instance.go:202:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_ami_from_instance.go:203:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_default_network_acl.go:172:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_default_network_acl.go:244:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ec2_client_vpn_endpoint.go:269:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ec2_client_vpn_endpoint.go:337:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_instance.go:1217:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_instance.go:918:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_instance.go:927:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_instance.go:944:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_acl.go:254:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_network_acl.go:338:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_network_interface.go:264:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_network_interface.go:289:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:330:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:346:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:388:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:403:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:417:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:428:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_spot_fleet_request.go:1200:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_subnet.go:168:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:186:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:201:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:204:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_subnet.go:265:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_subnet.go:274:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:292:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:361:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:379:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:383:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc.go:149:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc.go:150:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:190:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:208:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:220:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:232:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:259:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:262:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc.go:403:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc.go:421:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:442:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:469:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:496:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:537:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:552:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:562:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:565:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc_endpoint_service.go:181:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc_endpoint_service.go:205:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc_endpoint_service.go:218:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc_endpoint_service.go:229:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSAMI_basic (78.71s) --- PASS: TestAccAWSAMI_disappears (57.61s) --- PASS: TestAccAWSAMI_snapshotSize (64.52s) --- PASS: TestAccAWSAMI_tags (93.26s) --- PASS: TestAccAWSAMICopy_basic (365.47s) --- PASS: TestAccAWSAMICopy_Description (405.15s) --- PASS: TestAccAWSAMICopy_EnaSupport (391.75s) --- PASS: TestAccAWSAMICopy_tags (419.90s) --- PASS: TestAccAWSAMIFromInstance_basic (369.65s) --- PASS: TestAccAWSAMIFromInstance_tags (421.26s) --- PASS: TestAccAWSDefaultNetworkAcl_basic (30.84s) --- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (40.38s) --- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (38.32s) --- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (83.61s) --- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (74.22s) --- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (33.89s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_basic (22.69s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_disappears (18.67s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_msAD (1678.33s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_splitTunnel (36.58s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_tags (48.82s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_withDNSServers (36.09s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_withLogGroup (42.49s) --- PASS: TestAccAWSENI_attached (243.84s) --- PASS: TestAccAWSENI_basic (48.62s) --- PASS: TestAccAWSENI_computedIPs (40.94s) --- PASS: TestAccAWSENI_disappears (39.87s) --- PASS: TestAccAWSENI_ignoreExternalAttachment (114.17s) --- PASS: TestAccAWSENI_PrivateIpsCount (112.43s) --- PASS: TestAccAWSENI_sourceDestCheck (44.73s) --- PASS: TestAccAWSENI_updatedDescription (70.49s) --- PASS: TestAccAWSInstance_addSecondaryInterface (101.85s) --- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (119.12s) --- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (72.41s) --- PASS: TestAccAWSInstance_associatePublic_defaultPublic (82.27s) --- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (89.32s) --- PASS: TestAccAWSInstance_associatePublic_explicitPublic (80.62s) --- PASS: TestAccAWSInstance_associatePublic_overridePrivate (91.49s) --- PASS: TestAccAWSInstance_associatePublic_overridePublic (72.13s) --- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (81.44s) --- PASS: TestAccAWSInstance_basic (183.70s) --- PASS: TestAccAWSInstance_blockDevices (109.47s) --- PASS: TestAccAWSInstance_changeInstanceType (162.79s) --- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (325.46s) --- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (101.10s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (103.72s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (400.62s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (92.50s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (285.59s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (103.30s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (379.85s) --- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (82.16s) --- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (125.59s) --- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (96.78s) --- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (84.68s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (62.70s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (326.84s) --- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (106.79s) --- PASS: TestAccAWSInstance_disableApiTermination (115.81s) --- PASS: TestAccAWSInstance_disappears (241.97s) --- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (148.32s) --- PASS: TestAccAWSInstance_forceNewAndTagsDrift (120.55s) --- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (223.75s) --- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (241.06s) --- PASS: TestAccAWSInstance_GP2IopsDevice (90.09s) --- PASS: TestAccAWSInstance_GP2WithIopsValue (113.39s) --- PASS: TestAccAWSInstance_hibernation (169.65s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgId (77.63s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgName (79.23s) --- PASS: TestAccAWSInstance_instanceProfileChange (208.56s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCount (81.76s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (91.39s) --- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (13.22s) --- PASS: TestAccAWSInstance_keyPairCheck (67.97s) --- PASS: TestAccAWSInstance_multipleRegions (260.89s) --- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (91.04s) --- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (163.04s) --- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (83.27s) --- PASS: TestAccAWSInstance_noAMIEphemeralDevices (80.32s) --- PASS: TestAccAWSInstance_placementGroup (66.52s) --- PASS: TestAccAWSInstance_primaryNetworkInterface (84.04s) --- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (74.50s) --- PASS: TestAccAWSInstance_privateIP (81.69s) --- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (173.75s) --- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (109.59s) --- PASS: TestAccAWSInstance_rootInstanceStore (150.64s) --- PASS: TestAccAWSInstance_sourceDestCheck (126.46s) --- PASS: TestAccAWSInstance_tags (147.76s) --- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (91.50s) --- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (91.89s) --- PASS: TestAccAWSInstance_userDataBase64 (239.10s) --- PASS: TestAccAWSInstance_volumeTags (152.07s) --- PASS: TestAccAWSInstance_volumeTagsComputed (142.92s) --- PASS: TestAccAWSInstance_volumeTagsComputed (146.73s) --- PASS: TestAccAWSInstance_vpc (79.83s) --- PASS: TestAccAWSInstance_withIamInstanceProfile (117.42s) --- PASS: TestAccAWSNetworkAcl_basic (38.51s) --- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (46.29s) --- PASS: TestAccAWSNetworkAcl_disappears (33.69s) --- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (82.91s) --- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (38.77s) --- PASS: TestAccAWSNetworkAcl_espProtocol (36.38s) --- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (80.27s) --- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (31.10s) --- PASS: TestAccAWSNetworkAcl_ipv6Rules (49.98s) --- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (34.61s) --- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (43.51s) --- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (47.89s) --- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (71.35s) --- PASS: TestAccAWSNetworkAcl_SubnetChange (74.18s) --- PASS: TestAccAWSNetworkAcl_Subnets (74.71s) --- PASS: TestAccAWSNetworkAcl_SubnetsDelete (82.26s) --- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (372.99s) --- PASS: TestAccAWSSpotFleetRequest_basic (231.12s) --- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (582.29s) --- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (350.94s) --- PASS: TestAccAWSSpotFleetRequest_fleetType (241.77s) --- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (272.75s) --- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (242.11s) --- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (147.02s) --- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (146.75s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (265.13s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (355.97s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (264.26s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (286.87s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (297.89s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (264.21s) --- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (261.23s) --- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (60.68s) --- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (554.15s) --- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (750.82s) --- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (333.68s) --- PASS: TestAccAWSSpotFleetRequest_WithELBs (345.96s) --- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (266.18s) --- PASS: TestAccAWSSpotFleetRequest_withTags (254.92s) --- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (430.77s) --- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (295.99s) --- PASS: TestAccAWSSubnet_availabilityZoneId (30.67s) --- PASS: TestAccAWSSubnet_basic (30.59s) --- PASS: TestAccAWSSubnet_enableIpv6 (50.96s) --- PASS: TestAccAWSSubnet_ignoreTags (56.29s) --- PASS: TestAccAWSSubnet_ipv6 (77.14s) --- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (73.30s) --- PASS: TestAccAWSVpc_basic (29.97s) --- PASS: TestAccAWSVpc_bothDnsOptionsSet (33.54s) --- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (31.49s) --- PASS: TestAccAWSVpc_classiclinkOptionSet (32.05s) --- PASS: TestAccAWSVpc_coreMismatchedDiffs (25.26s) --- PASS: TestAccAWSVpc_DisabledDnsSupport (31.22s) --- PASS: TestAccAWSVpc_disappears (16.78s) --- PASS: TestAccAWSVpc_ignoreTags (50.85s) --- PASS: TestAccAWSVpc_tags (51.10s) --- PASS: TestAccAWSVpc_Tenancy (74.07s) --- PASS: TestAccAWSVpc_update (44.39s) --- PASS: TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags (286.82s) --- PASS: TestAccAWSVpcEndpointService_basic (266.19s) --- PASS: TestAccAWSVpcEndpointService_removed (303.85s) ```
twitty-rival
pushed a commit
to twitty-rival/terraform-provider-aws
that referenced
this issue
May 6, 2020
…urceData).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12464) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_autoscaling_group.go:949:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_autoscaling_group.go:953:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_autoscaling_group.go:959:3: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (221.26s) --- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (300.96s) --- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (82.26s) --- PASS: TestAccAWSAutoScalingGroup_basic (385.26s) --- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (78.87s) --- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (96.80s) --- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (193.31s) --- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (360.02s) --- PASS: TestAccAWSAutoScalingGroup_launchTemplate (73.68s) --- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (55.71s) --- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (170.76s) --- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (569.35s) --- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (111.74s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (52.49s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (48.81s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (145.14s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (80.84s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (45.67s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (106.02s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (110.26s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (109.23s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (81.39s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (81.21s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (167.25s) --- PASS: TestAccAWSAutoScalingGroup_namePrefix (54.31s) --- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (164.35s) --- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (178.65s) --- PASS: TestAccAWSAutoScalingGroup_tags (215.41s) --- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (291.79s) --- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (113.05s) --- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (79.41s) --- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (372.04s) --- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (353.81s) --- PASS: TestAccAWSAutoScalingGroup_withMetrics (173.70s) --- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (177.06s) ```
twitty-rival
pushed a commit
to twitty-rival/terraform-provider-aws
that referenced
this issue
May 6, 2020
… and (helper/schema.ResourceData).SetPartial() (hashicorp#12465) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_ami.go:414:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami.go:434:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_ami.go:437:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami_copy.go:218:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami_copy.go:220:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_ami_copy.go:221:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami_from_instance.go:200:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami_from_instance.go:202:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_ami_from_instance.go:203:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_default_network_acl.go:172:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_default_network_acl.go:244:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ec2_client_vpn_endpoint.go:269:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ec2_client_vpn_endpoint.go:337:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_instance.go:1217:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_instance.go:918:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_instance.go:927:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_instance.go:944:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_acl.go:254:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_network_acl.go:338:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_network_interface.go:264:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_network_interface.go:289:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:330:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:346:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:388:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:403:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:417:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:428:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_spot_fleet_request.go:1200:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_subnet.go:168:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:186:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:201:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:204:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_subnet.go:265:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_subnet.go:274:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:292:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:361:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:379:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:383:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc.go:149:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc.go:150:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:190:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:208:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:220:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:232:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:259:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:262:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc.go:403:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc.go:421:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:442:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:469:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:496:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:537:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:552:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:562:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:565:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc_endpoint_service.go:181:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc_endpoint_service.go:205:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc_endpoint_service.go:218:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc_endpoint_service.go:229:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSAMI_basic (78.71s) --- PASS: TestAccAWSAMI_disappears (57.61s) --- PASS: TestAccAWSAMI_snapshotSize (64.52s) --- PASS: TestAccAWSAMI_tags (93.26s) --- PASS: TestAccAWSAMICopy_basic (365.47s) --- PASS: TestAccAWSAMICopy_Description (405.15s) --- PASS: TestAccAWSAMICopy_EnaSupport (391.75s) --- PASS: TestAccAWSAMICopy_tags (419.90s) --- PASS: TestAccAWSAMIFromInstance_basic (369.65s) --- PASS: TestAccAWSAMIFromInstance_tags (421.26s) --- PASS: TestAccAWSDefaultNetworkAcl_basic (30.84s) --- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (40.38s) --- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (38.32s) --- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (83.61s) --- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (74.22s) --- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (33.89s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_basic (22.69s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_disappears (18.67s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_msAD (1678.33s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_splitTunnel (36.58s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_tags (48.82s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_withDNSServers (36.09s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_withLogGroup (42.49s) --- PASS: TestAccAWSENI_attached (243.84s) --- PASS: TestAccAWSENI_basic (48.62s) --- PASS: TestAccAWSENI_computedIPs (40.94s) --- PASS: TestAccAWSENI_disappears (39.87s) --- PASS: TestAccAWSENI_ignoreExternalAttachment (114.17s) --- PASS: TestAccAWSENI_PrivateIpsCount (112.43s) --- PASS: TestAccAWSENI_sourceDestCheck (44.73s) --- PASS: TestAccAWSENI_updatedDescription (70.49s) --- PASS: TestAccAWSInstance_addSecondaryInterface (101.85s) --- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (119.12s) --- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (72.41s) --- PASS: TestAccAWSInstance_associatePublic_defaultPublic (82.27s) --- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (89.32s) --- PASS: TestAccAWSInstance_associatePublic_explicitPublic (80.62s) --- PASS: TestAccAWSInstance_associatePublic_overridePrivate (91.49s) --- PASS: TestAccAWSInstance_associatePublic_overridePublic (72.13s) --- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (81.44s) --- PASS: TestAccAWSInstance_basic (183.70s) --- PASS: TestAccAWSInstance_blockDevices (109.47s) --- PASS: TestAccAWSInstance_changeInstanceType (162.79s) --- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (325.46s) --- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (101.10s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (103.72s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (400.62s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (92.50s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (285.59s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (103.30s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (379.85s) --- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (82.16s) --- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (125.59s) --- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (96.78s) --- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (84.68s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (62.70s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (326.84s) --- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (106.79s) --- PASS: TestAccAWSInstance_disableApiTermination (115.81s) --- PASS: TestAccAWSInstance_disappears (241.97s) --- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (148.32s) --- PASS: TestAccAWSInstance_forceNewAndTagsDrift (120.55s) --- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (223.75s) --- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (241.06s) --- PASS: TestAccAWSInstance_GP2IopsDevice (90.09s) --- PASS: TestAccAWSInstance_GP2WithIopsValue (113.39s) --- PASS: TestAccAWSInstance_hibernation (169.65s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgId (77.63s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgName (79.23s) --- PASS: TestAccAWSInstance_instanceProfileChange (208.56s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCount (81.76s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (91.39s) --- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (13.22s) --- PASS: TestAccAWSInstance_keyPairCheck (67.97s) --- PASS: TestAccAWSInstance_multipleRegions (260.89s) --- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (91.04s) --- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (163.04s) --- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (83.27s) --- PASS: TestAccAWSInstance_noAMIEphemeralDevices (80.32s) --- PASS: TestAccAWSInstance_placementGroup (66.52s) --- PASS: TestAccAWSInstance_primaryNetworkInterface (84.04s) --- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (74.50s) --- PASS: TestAccAWSInstance_privateIP (81.69s) --- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (173.75s) --- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (109.59s) --- PASS: TestAccAWSInstance_rootInstanceStore (150.64s) --- PASS: TestAccAWSInstance_sourceDestCheck (126.46s) --- PASS: TestAccAWSInstance_tags (147.76s) --- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (91.50s) --- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (91.89s) --- PASS: TestAccAWSInstance_userDataBase64 (239.10s) --- PASS: TestAccAWSInstance_volumeTags (152.07s) --- PASS: TestAccAWSInstance_volumeTagsComputed (142.92s) --- PASS: TestAccAWSInstance_volumeTagsComputed (146.73s) --- PASS: TestAccAWSInstance_vpc (79.83s) --- PASS: TestAccAWSInstance_withIamInstanceProfile (117.42s) --- PASS: TestAccAWSNetworkAcl_basic (38.51s) --- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (46.29s) --- PASS: TestAccAWSNetworkAcl_disappears (33.69s) --- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (82.91s) --- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (38.77s) --- PASS: TestAccAWSNetworkAcl_espProtocol (36.38s) --- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (80.27s) --- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (31.10s) --- PASS: TestAccAWSNetworkAcl_ipv6Rules (49.98s) --- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (34.61s) --- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (43.51s) --- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (47.89s) --- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (71.35s) --- PASS: TestAccAWSNetworkAcl_SubnetChange (74.18s) --- PASS: TestAccAWSNetworkAcl_Subnets (74.71s) --- PASS: TestAccAWSNetworkAcl_SubnetsDelete (82.26s) --- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (372.99s) --- PASS: TestAccAWSSpotFleetRequest_basic (231.12s) --- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (582.29s) --- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (350.94s) --- PASS: TestAccAWSSpotFleetRequest_fleetType (241.77s) --- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (272.75s) --- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (242.11s) --- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (147.02s) --- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (146.75s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (265.13s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (355.97s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (264.26s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (286.87s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (297.89s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (264.21s) --- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (261.23s) --- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (60.68s) --- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (554.15s) --- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (750.82s) --- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (333.68s) --- PASS: TestAccAWSSpotFleetRequest_WithELBs (345.96s) --- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (266.18s) --- PASS: TestAccAWSSpotFleetRequest_withTags (254.92s) --- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (430.77s) --- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (295.99s) --- PASS: TestAccAWSSubnet_availabilityZoneId (30.67s) --- PASS: TestAccAWSSubnet_basic (30.59s) --- PASS: TestAccAWSSubnet_enableIpv6 (50.96s) --- PASS: TestAccAWSSubnet_ignoreTags (56.29s) --- PASS: TestAccAWSSubnet_ipv6 (77.14s) --- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (73.30s) --- PASS: TestAccAWSVpc_basic (29.97s) --- PASS: TestAccAWSVpc_bothDnsOptionsSet (33.54s) --- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (31.49s) --- PASS: TestAccAWSVpc_classiclinkOptionSet (32.05s) --- PASS: TestAccAWSVpc_coreMismatchedDiffs (25.26s) --- PASS: TestAccAWSVpc_DisabledDnsSupport (31.22s) --- PASS: TestAccAWSVpc_disappears (16.78s) --- PASS: TestAccAWSVpc_ignoreTags (50.85s) --- PASS: TestAccAWSVpc_tags (51.10s) --- PASS: TestAccAWSVpc_Tenancy (74.07s) --- PASS: TestAccAWSVpc_update (44.39s) --- PASS: TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags (286.82s) --- PASS: TestAccAWSVpcEndpointService_basic (266.19s) --- PASS: TestAccAWSVpcEndpointService_removed (303.85s) ```
twitty-rival
pushed a commit
to twitty-rival/terraform-provider-aws
that referenced
this issue
May 6, 2020
…ceData).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12466) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_lambda_function.go:674:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_lambda_function.go:841:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:842:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:843:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:844:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:845:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:884:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:885:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:886:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:887:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:888:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:931:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSLambdaFunction_basic (64.06s) --- PASS: TestAccAWSLambdaFunction_concurrency (493.45s) --- PASS: TestAccAWSLambdaFunction_concurrencyCycle (529.28s) --- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (536.23s) --- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (148.43s) --- PASS: TestAccAWSLambdaFunction_disappears (94.71s) --- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (68.70s) --- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (561.28s) --- PASS: TestAccAWSLambdaFunction_envVariables (579.67s) --- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (24.88s) --- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (151.22s) --- PASS: TestAccAWSLambdaFunction_Layers (514.42s) --- PASS: TestAccAWSLambdaFunction_LayersUpdate (170.54s) --- PASS: TestAccAWSLambdaFunction_localUpdate (523.11s) --- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (486.27s) --- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (492.13s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_java11 (83.49s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (78.16s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x (514.99s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs12x (513.46s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (2.32s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (71.48s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (56.73s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (97.54s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (50.94s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_python38 (89.93s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby25 (109.39s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby27 (117.27s) --- PASS: TestAccAWSLambdaFunction_s3 (44.11s) --- PASS: TestAccAWSLambdaFunction_s3Update_basic (74.22s) --- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (68.76s) --- PASS: TestAccAWSLambdaFunction_tags (140.89s) --- PASS: TestAccAWSLambdaFunction_tracingConfig (535.70s) --- PASS: TestAccAWSLambdaFunction_updateRuntime (511.04s) --- PASS: TestAccAWSLambdaFunction_versioned (514.26s) --- PASS: TestAccAWSLambdaFunction_versionedUpdate (607.45s) --- PASS: TestAccAWSLambdaFunction_VPC (2148.53s) --- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (1848.27s) --- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (1568.41s) --- PASS: TestAccAWSLambdaFunction_VPCRemoval (2046.17s) --- PASS: TestAccAWSLambdaFunction_VPCUpdate (2526.06s) ```
twitty-rival
pushed a commit
to twitty-rival/terraform-provider-aws
that referenced
this issue
May 6, 2020
…urceData).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12467) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_api_gateway_stage.go:134:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_api_gateway_stage.go:178:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:179:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:180:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:181:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:182:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:183:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:205:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:206:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:207:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_api_gateway_stage.go:291:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_api_gateway_stage.go:398:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:399:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:400:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:401:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:402:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:428:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:429:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:430:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSAPIGatewayStage_accessLogSettings (260.87s) --- PASS: TestAccAWSAPIGatewayStage_accessLogSettings_kinesis (388.36s) --- PASS: TestAccAWSAPIGatewayStage_basic (469.04s) ```
twitty-rival
pushed a commit
to twitty-rival/terraform-provider-aws
that referenced
this issue
May 6, 2020
…ta).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12468) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_lb_listener_rule.go:1083:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lb_listener_rule.go:1093:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lb_listener_rule.go:1107:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_lb_listener_rule.go:931:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_lb_listener_rule.go:948:3: R008: deprecated (schema.ResourceData).SetPartial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSLBListenerRule_Action_Order (192.70s) --- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (223.40s) --- PASS: TestAccAWSLBListenerRule_basic (267.91s) --- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (216.77s) --- PASS: TestAccAWSLBListenerRule_cognito (211.46s) --- PASS: TestAccAWSLBListenerRule_conditionAttributesCount (29.28s) --- PASS: TestAccAWSLBListenerRule_conditionHostHeader (191.30s) --- PASS: TestAccAWSLBListenerRule_conditionHostHeader_deprecated (190.31s) --- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (181.36s) --- PASS: TestAccAWSLBListenerRule_conditionHttpHeader_invalid (2.67s) --- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (180.78s) --- PASS: TestAccAWSLBListenerRule_conditionMultiple (219.93s) --- PASS: TestAccAWSLBListenerRule_conditionPathPattern (221.77s) --- PASS: TestAccAWSLBListenerRule_conditionPathPattern_deprecated (220.00s) --- PASS: TestAccAWSLBListenerRule_conditionQueryString (191.65s) --- PASS: TestAccAWSLBListenerRule_conditionSourceIp (275.03s) --- PASS: TestAccAWSLBListenerRule_conditionUpdateMixed (284.65s) --- PASS: TestAccAWSLBListenerRule_conditionUpdateMultiple (258.87s) --- PASS: TestAccAWSLBListenerRule_conditionUpdatePathPattern_deprecated (355.25s) --- PASS: TestAccAWSLBListenerRule_fixedResponse (217.28s) --- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (2.66s) --- PASS: TestAccAWSLBListenerRule_oidc (188.46s) --- PASS: TestAccAWSLBListenerRule_priority (406.08s) --- PASS: TestAccAWSLBListenerRule_redirect (189.54s) --- PASS: TestAccAWSLBListenerRule_updateFixedResponse (222.80s) --- PASS: TestAccAWSLBListenerRule_updateRulePriority (225.24s) ```
twitty-rival
pushed a commit
to twitty-rival/terraform-provider-aws
that referenced
this issue
May 6, 2020
…ed (helper/schema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12469) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_codestarnotifications_notification_rule.go:236:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_codestarnotifications_notification_rule.go:251:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_codestarnotifications_notification_rule.go:252:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_codestarnotifications_notification_rule.go:253:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_codestarnotifications_notification_rule.go:254:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_codestarnotifications_notification_rule.go:270:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSCodeStarNotificationsNotificationRule_Basic (26.58s) --- PASS: TestAccAWSCodeStarNotificationsNotificationRule_EventTypeIds (49.15s) --- PASS: TestAccAWSCodeStarNotificationsNotificationRule_Status (61.55s) --- PASS: TestAccAWSCodeStarNotificationsNotificationRule_Tags (49.81s) --- PASS: TestAccAWSCodeStarNotificationsNotificationRule_Targets (48.94s) ```
twitty-rival
pushed a commit
to twitty-rival/terraform-provider-aws
that referenced
this issue
May 6, 2020
…tial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12462) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_sagemaker_endpoint.go:135:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_endpoint.go:144:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_sagemaker_endpoint.go:156:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_sagemaker_endpoint.go:168:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_model.go:284:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_model.go:294:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_notebook_instance.go:217:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_notebook_instance.go:226:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_sagemaker_notebook_instance.go:328:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSSagemakerEndpoint_basic (485.91s) --- PASS: TestAccAWSSagemakerEndpoint_EndpointConfigName (852.16s) --- PASS: TestAccAWSSagemakerEndpoint_Tags (525.67s) --- PASS: TestAccAWSSagemakerModel_basic (47.36s) --- PASS: TestAccAWSSagemakerModel_containers (35.84s) --- PASS: TestAccAWSSagemakerModel_networkIsolation (59.84s) --- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (33.08s) --- PASS: TestAccAWSSagemakerModel_primaryContainerHostname (30.86s) --- PASS: TestAccAWSSagemakerModel_primaryContainerModelDataUrl (57.54s) --- PASS: TestAccAWSSagemakerModel_tags (42.35s) --- PASS: TestAccAWSSagemakerModel_vpcConfig (62.13s) --- PASS: TestAccAWSSagemakerNotebookInstance_basic (359.34s) --- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (714.40s) --- PASS: TestAccAWSSagemakerNotebookInstance_disappears (396.62s) --- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (296.66s) --- PASS: TestAccAWSSagemakerNotebookInstance_tags (411.90s) --- PASS: TestAccAWSSagemakerNotebookInstance_update (625.72s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…al() and (helper/schema.ResourceData).SetPartial() Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_neptune_cluster.go:597:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster.go:684:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_instance.go:384:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_instance.go:390:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_instance.go:396:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_instance.go:402:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_instance.go:451:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_parameter_group.go:185:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_cluster_parameter_group.go:226:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_parameter_group.go:237:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_cluster_parameter_group.go:240:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_event_subscription.go:209:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_event_subscription.go:265:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_event_subscription.go:266:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_event_subscription.go:267:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_event_subscription.go:268:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_event_subscription.go:278:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_event_subscription.go:320:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_event_subscription.go:323:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_parameter_group.go:100:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_parameter_group.go:101:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_parameter_group.go:102:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_parameter_group.go:103:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_parameter_group.go:104:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_parameter_group.go:181:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_parameter_group.go:259:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_parameter_group.go:269:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_neptune_parameter_group.go:272:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_neptune_subnet_group.go:195:3: R008: deprecated (schema.ResourceData).SetPartial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSNeptuneCluster_backupsUpdate (297.92s) --- PASS: TestAccAWSNeptuneCluster_basic (168.78s) --- PASS: TestAccAWSNeptuneCluster_deleteProtection (212.60s) --- PASS: TestAccAWSNeptuneCluster_encrypted (175.61s) --- PASS: TestAccAWSNeptuneCluster_iamAuth (193.62s) --- PASS: TestAccAWSNeptuneCluster_kmsKey (195.57s) --- PASS: TestAccAWSNeptuneCluster_namePrefix (154.44s) --- PASS: TestAccAWSNeptuneCluster_tags (209.12s) --- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (254.53s) --- PASS: TestAccAWSNeptuneCluster_updateCloudwatchLogsExports (233.15s) --- PASS: TestAccAWSNeptuneCluster_updateIamRoles (195.20s) --- PASS: TestAccAWSNeptuneClusterInstance_basic (1755.23s) --- PASS: TestAccAWSNeptuneClusterInstance_generatedName (785.56s) --- PASS: TestAccAWSNeptuneClusterInstance_kmsKey (835.57s) --- PASS: TestAccAWSNeptuneClusterInstance_namePrefix (807.49s) --- PASS: TestAccAWSNeptuneClusterInstance_withaz (925.05s) --- PASS: TestAccAWSNeptuneClusterInstance_withSubnetGroup (783.88s) --- PASS: TestAccAWSNeptuneClusterParameterGroup_basic (17.40s) --- PASS: TestAccAWSNeptuneClusterParameterGroup_Description (17.46s) --- PASS: TestAccAWSNeptuneClusterParameterGroup_generatedName (17.68s) --- PASS: TestAccAWSNeptuneClusterParameterGroup_namePrefix (20.77s) --- PASS: TestAccAWSNeptuneClusterParameterGroup_Parameter (31.24s) --- PASS: TestAccAWSNeptuneClusterParameterGroup_Tags (64.82s) --- PASS: TestAccAWSNeptuneEventSubscription_basic (150.00s) --- PASS: TestAccAWSNeptuneEventSubscription_withCategories (124.64s) --- PASS: TestAccAWSNeptuneEventSubscription_withPrefix (123.58s) --- PASS: TestAccAWSNeptuneEventSubscription_withSourceIds (97.81s) --- PASS: TestAccAWSNeptuneParameterGroup_basic (28.51s) --- PASS: TestAccAWSNeptuneParameterGroup_Description (22.30s) --- PASS: TestAccAWSNeptuneParameterGroup_Parameter (114.91s) --- PASS: TestAccAWSNeptuneParameterGroup_Tags (60.91s) --- PASS: TestAccAWSNeptuneSubnetGroup_basic (46.02s) --- PASS: TestAccAWSNeptuneSubnetGroup_generatedName (49.96s) --- PASS: TestAccAWSNeptuneSubnetGroup_namePrefix (48.39s) --- PASS: TestAccAWSNeptuneSubnetGroup_updateDescription (76.13s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…esourceData).Partial() and (helper/schema.ResourceData).SetPartial() Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_iam_instance_profile.go:200:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_iam_instance_profile.go:209:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_iam_instance_profile.go:219:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_iam_instance_profile.go:222:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_iam_instance_profile.go:249:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_iam_instance_profile.go:268:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_iam_instance_profile.go:275:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSIAMInstanceProfile_withoutRole (13.88s) --- PASS: TestAccAWSIAMInstanceProfile_basic (14.58s) --- PASS: TestAccAWSIAMInstanceProfile_withRoleNotRoles (14.64s) --- PASS: TestAccAWSIAMInstanceProfile_namePrefix (14.70s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…(helper/schema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12470) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_licensemanager_license_configuration.go:141:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_licensemanager_license_configuration.go:150:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_licensemanager_license_configuration.go:153:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSLicenseManagerLicenseConfiguration_basic (16.06s) --- PASS: TestAccAWSLicenseManagerLicenseConfiguration_update (25.54s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…chema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12471) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_elasticache_parameter_group.go:136:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_elasticache_parameter_group.go:310:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elasticache_parameter_group.go:313:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_elasticache_parameter_group.go:84:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_elasticache_parameter_group.go:85:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elasticache_parameter_group.go:86:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elasticache_parameter_group.go:87:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elasticache_parameter_group.go:88:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSElasticacheParameterGroup_Description (23.39s) --- PASS: TestAccAWSElasticacheParameterGroup_basic (25.25s) --- PASS: TestAccAWSElasticacheParameterGroup_UppercaseName (25.32s) --- PASS: TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter (42.06s) --- PASS: TestAccAWSElasticacheParameterGroup_removeAllParameters (44.50s) --- PASS: TestAccAWSElasticacheParameterGroup_addParameter (44.70s) --- PASS: TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter (90.73s) --- PASS: TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter (91.11s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…/schema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12472) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_globalaccelerator_accelerator.go:265:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_globalaccelerator_accelerator.go:285:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_globalaccelerator_accelerator.go:286:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_globalaccelerator_accelerator.go:287:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_globalaccelerator_accelerator.go:304:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_globalaccelerator_accelerator.go:314:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_globalaccelerator_accelerator.go:317:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (55.91s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (84.82s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (92.89s) --- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (97.79s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…ta).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12474) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_qldb_ledger.go:159:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_qldb_ledger.go:175:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_qldb_ledger.go:185:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSQLDBLedger_basic (47.45s) --- PASS: TestAccAWSQLDBLedger_Tags (69.25s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…ata).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12475) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_route53_zone.go:245:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_route53_zone.go:259:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_zone.go:302:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_zone.go:305:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSRoute53Zone_disappears (46.86s) --- PASS: TestAccAWSRoute53Zone_basic (51.82s) --- PASS: TestAccAWSRoute53Zone_DelegationSetID (54.36s) --- PASS: TestAccAWSRoute53Zone_multiple (55.84s) --- PASS: TestAccAWSRoute53Zone_Comment (63.72s) --- PASS: TestAccAWSRoute53Zone_Tags (76.39s) --- PASS: TestAccAWSRoute53Zone_VPC_Single (100.74s) --- PASS: TestAccAWSRoute53Zone_VPC_Multiple (162.98s) --- PASS: TestAccAWSRoute53Zone_ForceDestroy (183.10s) --- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (184.32s) --- PASS: TestAccAWSRoute53Zone_VPC_Updates (238.08s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…ma.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12476) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_opsworks_rds_db_instance.go:46:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_opsworks_rds_db_instance.go:48:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_opsworks_rds_db_instance.go:55:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_opsworks_rds_db_instance.go:60:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_opsworks_rds_db_instance.go:74:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSOpsworksRdsDbInstance (971.17s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
… and (helper/schema.ResourceData).SetPartial() (hashicorp#12477) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_db_cluster_snapshot.go:197:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:239:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_event_subscription.go:296:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:297:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:298:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:299:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:309:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:351:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:354:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_instance.go:1473:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_instance.go:1480:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1488:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1489:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1495:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1501:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1506:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1511:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1516:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1521:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1526:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1531:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1537:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1542:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1547:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1561:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1566:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1571:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1576:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1585:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1591:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1597:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1617:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1623:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1628:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1634:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1645:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1646:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1653:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1657:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1662:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1732:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1735:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_option_group.go:288:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_option_group.go:299:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_parameter_group.go:116:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_parameter_group.go:117:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_parameter_group.go:118:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_parameter_group.go:119:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_parameter_group.go:120:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_parameter_group.go:249:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_parameter_group.go:331:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_parameter_group.go:334:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_security_group.go:199:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_security_group.go:208:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_security_group.go:246:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_snapshot.go:224:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_subnet_group.go:199:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster.go:1121:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster.go:1137:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster.go:1143:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster.go:1149:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster.go:1246:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:493:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:499:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:503:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:511:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:517:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:523:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:529:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:535:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:541:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:547:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:553:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_parameter_group.go:185:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_rds_cluster_parameter_group.go:274:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_parameter_group.go:277:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing (test failures present on master): ``` --- PASS: TestAccAWSDBClusterSnapshot_basic (161.83s) --- PASS: TestAccAWSDBClusterSnapshot_Tags (208.14s) --- PASS: TestAccAWSDBEventSubscription_basicUpdate (127.65s) --- PASS: TestAccAWSDBEventSubscription_categoryUpdate (125.24s) --- PASS: TestAccAWSDBEventSubscription_disappears (78.82s) --- PASS: TestAccAWSDBEventSubscription_withPrefix (81.72s) --- PASS: TestAccAWSDBEventSubscription_withSourceIds (101.26s) --- FAIL: TestAccAWSDBInstance_S3Import (671.95s) --- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (443.80s) --- PASS: TestAccAWSDBInstance_basic (566.04s) --- PASS: TestAccAWSDBInstance_CACertificateIdentifier (623.72s) --- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (530.77s) --- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfigurationUpdate (956.15s) --- PASS: TestAccAWSDBInstance_DeletionProtection (584.27s) --- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (698.62s) --- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (760.80s) --- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (623.55s) --- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (813.02s) --- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (742.11s) --- PASS: TestAccAWSDBInstance_generatedName (473.76s) --- PASS: TestAccAWSDBInstance_iamAuth (423.49s) --- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (539.38s) --- PASS: TestAccAWSDBInstance_kmsKey (462.25s) --- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (625.94s) --- PASS: TestAccAWSDBInstance_MinorVersion (496.98s) --- PASS: TestAccAWSDBInstance_MonitoringInterval (1038.16s) --- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (795.78s) --- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (804.57s) --- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (822.91s) --- PASS: TestAccAWSDBInstance_MSSQL_Domain (3671.81s) --- PASS: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (2811.43s) --- PASS: TestAccAWSDBInstance_MSSQL_TZ (1625.50s) --- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1902.87s) --- PASS: TestAccAWSDBInstance_namePrefix (485.32s) --- PASS: TestAccAWSDBInstance_NoDeleteAutomatedBackups (654.56s) --- PASS: TestAccAWSDBInstance_optionGroup (499.87s) --- PASS: TestAccAWSDBInstance_Password (574.56s) --- PASS: TestAccAWSDBInstance_portUpdate (504.62s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1527.99s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1476.93s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1370.52s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1482.23s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1824.62s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1598.16s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (1454.94s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1538.08s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1582.77s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1594.36s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1753.26s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (2145.53s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1695.43s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (1860.48s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1448.57s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1540.51s) --- PASS: TestAccAWSDBInstance_separate_iops_update (781.70s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1327.39s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1519.07s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (2303.64s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1187.05s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1298.15s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1644.94s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1704.80s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1307.64s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1235.72s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1295.56s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1804.10s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1324.91s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1118.39s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1256.49s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (1893.83s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (3726.44s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1341.16s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (1369.24s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1241.65s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1180.23s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1150.78s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1127.44s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1305.53s) --- PASS: TestAccAWSDBInstance_subnetGroup (1056.41s) --- PASS: TestAccAWSDBOptionGroup_basic (20.09s) --- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (505.73s) --- PASS: TestAccAWSDBOptionGroup_generatedName (25.87s) --- PASS: TestAccAWSDBOptionGroup_multipleOptions (36.35s) --- PASS: TestAccAWSDBOptionGroup_namePrefix (40.96s) --- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings (120.52s) --- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_IAMRole (62.67s) --- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_MultipleNonDefault (67.17s) --- PASS: TestAccAWSDBOptionGroup_OracleOptionsUpdate (110.44s) --- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (82.61s) --- PASS: TestAccAWSDBOptionGroup_Tags (65.48s) --- PASS: TestAccAWSDBOptionGroup_Tags_WithOptions (65.91s) --- PASS: TestAccAWSDBOptionGroup_timeoutBlock (26.29s) --- PASS: TestAccAWSDBParameterGroup_basic (113.24s) --- PASS: TestAccAWSDBParameterGroup_Disappears (17.07s) --- PASS: TestAccAWSDBParameterGroup_generatedName (41.36s) --- PASS: TestAccAWSDBParameterGroup_limit (84.28s) --- PASS: TestAccAWSDBParameterGroup_MatchDefault (61.75s) --- PASS: TestAccAWSDBParameterGroup_namePrefix (48.96s) --- PASS: TestAccAWSDBParameterGroup_Only (39.17s) --- PASS: TestAccAWSDBParameterGroup_withApplyMethod (51.68s) --- PASS: TestAccAWSDBSecurityGroup_basic (13.66s) --- PASS: TestAccAWSDBSnapshot_basic (755.49s) --- PASS: TestAccAWSDBSnapshot_disappears (617.74s) --- PASS: TestAccAWSDBSnapshot_tags (651.91s) --- PASS: TestAccAWSDBSubnetGroup_basic (35.79s) --- PASS: TestAccAWSDBSubnetGroup_generatedName (35.00s) --- PASS: TestAccAWSDBSubnetGroup_namePrefix (35.59s) --- PASS: TestAccAWSDBSubnetGroup_updateDescription (61.68s) --- PASS: TestAccAWSDBSubnetGroup_withUndocumentedCharacters (42.07s) --- FAIL: TestAccAWSRDSCluster_s3Restore (1624.16s) --- PASS: TestAccAWSRDSCluster_AvailabilityZones (240.79s) --- PASS: TestAccAWSRDSCluster_BacktrackWindow (248.08s) --- PASS: TestAccAWSRDSCluster_backupsUpdate (183.26s) --- PASS: TestAccAWSRDSCluster_basic (236.10s) --- PASS: TestAccAWSRDSCluster_ClusterIdentifierPrefix (123.32s) --- PASS: TestAccAWSRDSCluster_copyTagsToSnapshot (224.31s) --- PASS: TestAccAWSRDSCluster_DbSubnetGroupName (214.54s) --- PASS: TestAccAWSRDSCluster_DeletionProtection (164.87s) --- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports (446.46s) --- PASS: TestAccAWSRDSCluster_EnableHttpEndpoint (311.62s) --- PASS: TestAccAWSRDSCluster_encrypted (122.89s) --- PASS: TestAccAWSRDSCluster_EncryptedCrossRegionReplication (1804.90s) --- PASS: TestAccAWSRDSCluster_EngineMode (414.68s) --- PASS: TestAccAWSRDSCluster_EngineMode_Global (132.28s) --- PASS: TestAccAWSRDSCluster_EngineMode_Multimaster (212.05s) --- PASS: TestAccAWSRDSCluster_EngineMode_ParallelQuery (225.62s) --- PASS: TestAccAWSRDSCluster_EngineVersion (136.38s) --- PASS: TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance (1114.96s) --- PASS: TestAccAWSRDSCluster_generatedName (131.15s) --- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier (203.57s) --- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Add (231.16s) --- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Remove (215.27s) --- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Update (210.72s) --- PASS: TestAccAWSRDSCluster_iamAuth (131.99s) --- PASS: TestAccAWSRDSCluster_kmsKey (150.06s) --- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (7.08s) --- PASS: TestAccAWSRDSCluster_Port (362.74s) --- PASS: TestAccAWSRDSCluster_ScalingConfiguration (410.44s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier (419.84s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection (411.50s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore (352.20s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery (455.74s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned (393.86s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different (373.62s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal (373.42s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword (459.57s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername (433.11s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow (407.91s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow (371.35s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_Tags (374.56s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds (414.24s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags (404.15s) --- PASS: TestAccAWSRDSCluster_Tags (152.46s) --- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (152.36s) --- PASS: TestAccAWSRDSCluster_updateIamRoles (173.37s) --- FAIL: TestAccAWSRDSClusterInstance_CACertificateIdentifier (819.09s) --- PASS: TestAccAWSRDSClusterInstance_az (745.73s) --- PASS: TestAccAWSRDSClusterInstance_basic (1460.33s) --- PASS: TestAccAWSRDSClusterInstance_CopyTagsToSnapshot (693.56s) --- PASS: TestAccAWSRDSClusterInstance_disappears (696.91s) --- PASS: TestAccAWSRDSClusterInstance_generatedName (720.86s) --- PASS: TestAccAWSRDSClusterInstance_isAlreadyBeingDeleted (708.46s) --- PASS: TestAccAWSRDSClusterInstance_kmsKey (1376.64s) --- PASS: TestAccAWSRDSClusterInstance_MonitoringInterval (1298.65s) --- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled (941.01s) --- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved (965.68s) --- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled (841.84s) --- PASS: TestAccAWSRDSClusterInstance_namePrefix (1063.96s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1 (858.33s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2 (804.60s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql (794.16s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1 (817.10s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey (764.17s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2 (850.24s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey (847.01s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql (786.92s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey (753.94s) --- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (762.33s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…() and (helper/schema.ResourceData).SetPartial() (hashicorp#12457) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_docdb_cluster.go:620:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster.go:626:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster.go:672:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:345:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:351:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:357:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:363:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:413:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_parameter_group.go:185:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_docdb_cluster_parameter_group.go:230:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_parameter_group.go:241:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_parameter_group.go:244:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_docdb_subnet_group.go:179:3: R008: deprecated (schema.ResourceData).SetPartial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSDocDBCluster_backupsUpdate (260.19s) --- PASS: TestAccAWSDocDBCluster_basic (130.28s) --- PASS: TestAccAWSDocDBCluster_encrypted (203.87s) --- PASS: TestAccAWSDocDBCluster_generatedName (130.17s) --- PASS: TestAccAWSDocDBCluster_kmsKey (233.75s) --- PASS: TestAccAWSDocDBCluster_missingUserNameCausesError (4.93s) --- PASS: TestAccAWSDocDBCluster_namePrefix (129.97s) --- PASS: TestAccAWSDocDBCluster_Port (369.93s) --- PASS: TestAccAWSDocDBCluster_takeFinalSnapshot (252.47s) --- PASS: TestAccAWSDocDBCluster_updateCloudwatchLogsExports (227.06s) --- PASS: TestAccAWSDocDBCluster_updateTags (235.10s) --- PASS: TestAccAWSDocDBClusterInstance_az (714.97s) --- PASS: TestAccAWSDocDBClusterInstance_basic (1416.43s) --- PASS: TestAccAWSDocDBClusterInstance_disappears (748.64s) --- PASS: TestAccAWSDocDBClusterInstance_generatedName (753.18s) --- PASS: TestAccAWSDocDBClusterInstance_kmsKey (821.87s) --- PASS: TestAccAWSDocDBClusterInstance_namePrefix (764.04s) --- PASS: TestAccAWSDocDBClusterParameterGroup_basic (43.89s) --- PASS: TestAccAWSDocDBClusterParameterGroup_Description (31.42s) --- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (13.72s) --- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (27.74s) --- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (48.18s) --- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (50.36s) --- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (65.89s) --- PASS: TestAccAWSDocDBSubnetGroup_basic (57.22s) --- PASS: TestAccAWSDocDBSubnetGroup_disappears (31.33s) --- PASS: TestAccAWSDocDBSubnetGroup_generatedName (44.49s) --- PASS: TestAccAWSDocDBSubnetGroup_namePrefix (46.41s) --- PASS: TestAccAWSDocDBSubnetGroup_updateDescription (67.20s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
… and (helper/schema.ResourceData).SetPartial() (hashicorp#12459) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_elb.go:331:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_elb.go:332:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:333:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:334:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:335:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:336:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:337:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:479:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_elb.go:545:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:581:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:619:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:620:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:621:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:647:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:667:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:688:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:705:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:742:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:794:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_elb.go:810:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_proxy_protocol_policy.go:122:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_proxy_protocol_policy.go:151:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_proxy_protocol_policy.go:63:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_proxy_protocol_policy.go:65:2: R008: deprecated (schema.ResourceData).SetPartial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSELB_AccessLogs_disabled (275.08s) --- PASS: TestAccAWSELB_AccessLogs_enabled (88.33s) --- PASS: TestAccAWSELB_availabilityZones (67.63s) --- PASS: TestAccAWSELB_basic (40.56s) --- PASS: TestAccAWSELB_ConnectionDraining (222.97s) --- PASS: TestAccAWSELB_disappears (132.48s) --- PASS: TestAccAWSELB_fullCharacterRange (33.99s) --- PASS: TestAccAWSELB_generatedName (26.07s) --- PASS: TestAccAWSELB_generatesNameForZeroValue (84.50s) --- PASS: TestAccAWSELB_HealthCheck (219.59s) --- PASS: TestAccAWSELB_InstanceAttaching (173.37s) --- PASS: TestAccAWSELB_listener (101.85s) --- PASS: TestAccAWSELB_Listener_SSLCertificateID_IAMServerCertificate (42.66s) --- PASS: TestAccAWSELB_namePrefix (59.05s) --- PASS: TestAccAWSELB_SecurityGroups (171.23s) --- PASS: TestAccAWSELB_swap_subnets (276.60s) --- PASS: TestAccAWSELB_tags (95.49s) --- PASS: TestAccAWSELB_Timeout (141.20s) --- PASS: TestAccAWSProxyProtocolPolicy_basic (40.72s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…a).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12460) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_route53_resolver_endpoint.go:199:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_route53_resolver_endpoint.go:219:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_endpoint.go:264:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_endpoint.go:272:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_endpoint.go:275:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_route53_resolver_rule.go:191:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_route53_resolver_rule.go:220:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_rule.go:221:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_rule.go:222:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_rule.go:230:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_route53_resolver_rule.go:233:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAwsRoute53ResolverEndpoint_basicInbound (102.08s) --- PASS: TestAccAwsRoute53ResolverEndpoint_updateOutbound (446.81s) --- PASS: TestAccAwsRoute53ResolverRule_basic (39.84s) --- PASS: TestAccAwsRoute53ResolverRule_forward (316.33s) --- PASS: TestAccAwsRoute53ResolverRule_forwardEndpointRecreate (448.03s) --- PASS: TestAccAwsRoute53ResolverRule_tags (66.35s) --- PASS: TestAccAwsRoute53ResolverRule_updateName (62.64s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…ial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12461) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_redshift_cluster.go:644:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_cluster.go:653:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_cluster.go:774:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_cluster.go:828:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_event_subscription.go:191:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_event_subscription.go:216:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_event_subscription.go:219:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_parameter_group.go:168:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_parameter_group.go:200:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_parameter_group.go:210:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_parameter_group.go:213:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_snapshot_copy_grant.go:118:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_snapshot_copy_grant.go:127:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_snapshot_copy_grant.go:130:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_snapshot_schedule.go:142:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_snapshot_schedule.go:151:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_snapshot_schedule.go:168:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_subnet_group.go:127:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_redshift_subnet_group.go:136:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_redshift_subnet_group.go:162:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing (failure present on master): ``` --- PASS: TestAccAWSRedshiftCluster_basic (374.33s) --- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (664.68s) --- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (2088.45s) --- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (1868.48s) --- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (959.29s) --- PASS: TestAccAWSRedshiftCluster_forceNewUsername (1672.20s) --- PASS: TestAccAWSRedshiftCluster_iamRoles (824.30s) --- PASS: TestAccAWSRedshiftCluster_kmsKey (1387.64s) --- PASS: TestAccAWSRedshiftCluster_loggingEnabled (1178.50s) --- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (1435.60s) --- PASS: TestAccAWSRedshiftCluster_snapshotCopy (434.54s) --- PASS: TestAccAWSRedshiftCluster_tags (476.81s) --- PASS: TestAccAWSRedshiftCluster_updateNodeCount (3699.47s) --- PASS: TestAccAWSRedshiftCluster_updateNodeType (1911.25s) --- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (1449.68s) --- PASS: TestAccAWSRedshiftEventSubscription_basicUpdate (41.61s) --- PASS: TestAccAWSRedshiftEventSubscription_categoryUpdate (51.13s) --- PASS: TestAccAWSRedshiftEventSubscription_tagsUpdate (145.74s) --- PASS: TestAccAWSRedshiftEventSubscription_withPrefix (44.47s) --- PASS: TestAccAWSRedshiftEventSubscription_withSourceIds (84.82s) --- PASS: TestAccAWSRedshiftParameterGroup_basic (44.40s) --- PASS: TestAccAWSRedshiftParameterGroup_withoutParameters (76.56s) --- PASS: TestAccAWSRedshiftParameterGroup_withParameters (27.47s) --- PASS: TestAccAWSRedshiftParameterGroup_withTags (101.82s) --- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Basic (34.09s) --- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Update (74.12s) --- FAIL: TestAccAWSRedshiftSnapshotSchedule_withForceDestroy (314.27s) --- PASS: TestAccAWSRedshiftSnapshotSchedule_basic (55.17s) --- PASS: TestAccAWSRedshiftSnapshotSchedule_withDescription (48.15s) --- PASS: TestAccAWSRedshiftSnapshotSchedule_withIdentifierPrefix (44.69s) --- PASS: TestAccAWSRedshiftSnapshotSchedule_withMultipleDefinition (37.15s) --- PASS: TestAccAWSRedshiftSnapshotSchedule_withTags (97.33s) --- PASS: TestAccAWSRedshiftSubnetGroup_basic (41.15s) --- PASS: TestAccAWSRedshiftSubnetGroup_tags (64.37s) --- PASS: TestAccAWSRedshiftSubnetGroup_updateDescription (67.68s) --- PASS: TestAccAWSRedshiftSubnetGroup_updateSubnetIds (59.10s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…chema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12463) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_directory_service_directory.go:317:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_directory_service_directory.go:391:3: R008: deprecated (schema.ResourceData).SetPartial ``` Output from acceptance testing (failure present on master): ``` --- PASS: TestAccAWSDirectoryServiceDirectory_basic (488.80s) --- PASS: TestAccAWSDirectoryServiceDirectory_connector (968.66s) --- PASS: TestAccAWSDirectoryServiceDirectory_microsoft (1688.96s) --- PASS: TestAccAWSDirectoryServiceDirectory_microsoftStandard (1824.96s) --- PASS: TestAccAWSDirectoryServiceDirectory_tags (623.46s) --- PASS: TestAccAWSDirectoryServiceDirectory_withAliasAndSso (584.98s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…urceData).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12464) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_autoscaling_group.go:949:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_autoscaling_group.go:953:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_autoscaling_group.go:959:3: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (221.26s) --- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (300.96s) --- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (82.26s) --- PASS: TestAccAWSAutoScalingGroup_basic (385.26s) --- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (78.87s) --- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (96.80s) --- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (193.31s) --- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (360.02s) --- PASS: TestAccAWSAutoScalingGroup_launchTemplate (73.68s) --- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (55.71s) --- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (170.76s) --- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (569.35s) --- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (111.74s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (52.49s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (48.81s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (145.14s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (80.84s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (45.67s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (106.02s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (110.26s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (109.23s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (81.39s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (81.21s) --- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (167.25s) --- PASS: TestAccAWSAutoScalingGroup_namePrefix (54.31s) --- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (164.35s) --- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (178.65s) --- PASS: TestAccAWSAutoScalingGroup_tags (215.41s) --- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (291.79s) --- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (113.05s) --- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (79.41s) --- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (372.04s) --- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (353.81s) --- PASS: TestAccAWSAutoScalingGroup_withMetrics (173.70s) --- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (177.06s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
… and (helper/schema.ResourceData).SetPartial() (hashicorp#12465) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_ami.go:414:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami.go:434:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_ami.go:437:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami_copy.go:218:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami_copy.go:220:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_ami_copy.go:221:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami_from_instance.go:200:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ami_from_instance.go:202:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_ami_from_instance.go:203:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_default_network_acl.go:172:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_default_network_acl.go:244:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ec2_client_vpn_endpoint.go:269:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_ec2_client_vpn_endpoint.go:337:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_instance.go:1217:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_instance.go:918:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_instance.go:927:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_instance.go:944:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_acl.go:254:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_network_acl.go:338:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_network_interface.go:264:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_network_interface.go:289:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:330:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:346:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:388:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:403:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:417:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_network_interface.go:428:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_spot_fleet_request.go:1200:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_subnet.go:168:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:186:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:201:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:204:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_subnet.go:265:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_subnet.go:274:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:292:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:361:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:379:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_subnet.go:383:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc.go:149:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc.go:150:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:190:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:208:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:220:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:232:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:259:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:262:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc.go:403:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc.go:421:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:442:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:469:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:496:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:537:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:552:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:562:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc.go:565:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc_endpoint_service.go:181:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_vpc_endpoint_service.go:205:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc_endpoint_service.go:218:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_vpc_endpoint_service.go:229:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSAMI_basic (78.71s) --- PASS: TestAccAWSAMI_disappears (57.61s) --- PASS: TestAccAWSAMI_snapshotSize (64.52s) --- PASS: TestAccAWSAMI_tags (93.26s) --- PASS: TestAccAWSAMICopy_basic (365.47s) --- PASS: TestAccAWSAMICopy_Description (405.15s) --- PASS: TestAccAWSAMICopy_EnaSupport (391.75s) --- PASS: TestAccAWSAMICopy_tags (419.90s) --- PASS: TestAccAWSAMIFromInstance_basic (369.65s) --- PASS: TestAccAWSAMIFromInstance_tags (421.26s) --- PASS: TestAccAWSDefaultNetworkAcl_basic (30.84s) --- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (40.38s) --- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (38.32s) --- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (83.61s) --- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (74.22s) --- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (33.89s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_basic (22.69s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_disappears (18.67s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_msAD (1678.33s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_splitTunnel (36.58s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_tags (48.82s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_withDNSServers (36.09s) --- PASS: TestAccAwsEc2ClientVpnEndpoint_withLogGroup (42.49s) --- PASS: TestAccAWSENI_attached (243.84s) --- PASS: TestAccAWSENI_basic (48.62s) --- PASS: TestAccAWSENI_computedIPs (40.94s) --- PASS: TestAccAWSENI_disappears (39.87s) --- PASS: TestAccAWSENI_ignoreExternalAttachment (114.17s) --- PASS: TestAccAWSENI_PrivateIpsCount (112.43s) --- PASS: TestAccAWSENI_sourceDestCheck (44.73s) --- PASS: TestAccAWSENI_updatedDescription (70.49s) --- PASS: TestAccAWSInstance_addSecondaryInterface (101.85s) --- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (119.12s) --- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (72.41s) --- PASS: TestAccAWSInstance_associatePublic_defaultPublic (82.27s) --- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (89.32s) --- PASS: TestAccAWSInstance_associatePublic_explicitPublic (80.62s) --- PASS: TestAccAWSInstance_associatePublic_overridePrivate (91.49s) --- PASS: TestAccAWSInstance_associatePublic_overridePublic (72.13s) --- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (81.44s) --- PASS: TestAccAWSInstance_basic (183.70s) --- PASS: TestAccAWSInstance_blockDevices (109.47s) --- PASS: TestAccAWSInstance_changeInstanceType (162.79s) --- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (325.46s) --- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (101.10s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (103.72s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (400.62s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (92.50s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (285.59s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (103.30s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (379.85s) --- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (82.16s) --- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (125.59s) --- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (96.78s) --- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (84.68s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (62.70s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (326.84s) --- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (106.79s) --- PASS: TestAccAWSInstance_disableApiTermination (115.81s) --- PASS: TestAccAWSInstance_disappears (241.97s) --- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (148.32s) --- PASS: TestAccAWSInstance_forceNewAndTagsDrift (120.55s) --- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (223.75s) --- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (241.06s) --- PASS: TestAccAWSInstance_GP2IopsDevice (90.09s) --- PASS: TestAccAWSInstance_GP2WithIopsValue (113.39s) --- PASS: TestAccAWSInstance_hibernation (169.65s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgId (77.63s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgName (79.23s) --- PASS: TestAccAWSInstance_instanceProfileChange (208.56s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCount (81.76s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (91.39s) --- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (13.22s) --- PASS: TestAccAWSInstance_keyPairCheck (67.97s) --- PASS: TestAccAWSInstance_multipleRegions (260.89s) --- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (91.04s) --- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (163.04s) --- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (83.27s) --- PASS: TestAccAWSInstance_noAMIEphemeralDevices (80.32s) --- PASS: TestAccAWSInstance_placementGroup (66.52s) --- PASS: TestAccAWSInstance_primaryNetworkInterface (84.04s) --- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (74.50s) --- PASS: TestAccAWSInstance_privateIP (81.69s) --- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (173.75s) --- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (109.59s) --- PASS: TestAccAWSInstance_rootInstanceStore (150.64s) --- PASS: TestAccAWSInstance_sourceDestCheck (126.46s) --- PASS: TestAccAWSInstance_tags (147.76s) --- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (91.50s) --- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (91.89s) --- PASS: TestAccAWSInstance_userDataBase64 (239.10s) --- PASS: TestAccAWSInstance_volumeTags (152.07s) --- PASS: TestAccAWSInstance_volumeTagsComputed (142.92s) --- PASS: TestAccAWSInstance_volumeTagsComputed (146.73s) --- PASS: TestAccAWSInstance_vpc (79.83s) --- PASS: TestAccAWSInstance_withIamInstanceProfile (117.42s) --- PASS: TestAccAWSNetworkAcl_basic (38.51s) --- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (46.29s) --- PASS: TestAccAWSNetworkAcl_disappears (33.69s) --- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (82.91s) --- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (38.77s) --- PASS: TestAccAWSNetworkAcl_espProtocol (36.38s) --- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (80.27s) --- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (31.10s) --- PASS: TestAccAWSNetworkAcl_ipv6Rules (49.98s) --- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (34.61s) --- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (43.51s) --- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (47.89s) --- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (71.35s) --- PASS: TestAccAWSNetworkAcl_SubnetChange (74.18s) --- PASS: TestAccAWSNetworkAcl_Subnets (74.71s) --- PASS: TestAccAWSNetworkAcl_SubnetsDelete (82.26s) --- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (372.99s) --- PASS: TestAccAWSSpotFleetRequest_basic (231.12s) --- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (582.29s) --- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (350.94s) --- PASS: TestAccAWSSpotFleetRequest_fleetType (241.77s) --- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (272.75s) --- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (242.11s) --- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (147.02s) --- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (146.75s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (265.13s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (355.97s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (264.26s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (286.87s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (297.89s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (264.21s) --- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (261.23s) --- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (60.68s) --- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (554.15s) --- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (750.82s) --- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (333.68s) --- PASS: TestAccAWSSpotFleetRequest_WithELBs (345.96s) --- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (266.18s) --- PASS: TestAccAWSSpotFleetRequest_withTags (254.92s) --- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (430.77s) --- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (295.99s) --- PASS: TestAccAWSSubnet_availabilityZoneId (30.67s) --- PASS: TestAccAWSSubnet_basic (30.59s) --- PASS: TestAccAWSSubnet_enableIpv6 (50.96s) --- PASS: TestAccAWSSubnet_ignoreTags (56.29s) --- PASS: TestAccAWSSubnet_ipv6 (77.14s) --- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (73.30s) --- PASS: TestAccAWSVpc_basic (29.97s) --- PASS: TestAccAWSVpc_bothDnsOptionsSet (33.54s) --- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (31.49s) --- PASS: TestAccAWSVpc_classiclinkOptionSet (32.05s) --- PASS: TestAccAWSVpc_coreMismatchedDiffs (25.26s) --- PASS: TestAccAWSVpc_DisabledDnsSupport (31.22s) --- PASS: TestAccAWSVpc_disappears (16.78s) --- PASS: TestAccAWSVpc_ignoreTags (50.85s) --- PASS: TestAccAWSVpc_tags (51.10s) --- PASS: TestAccAWSVpc_Tenancy (74.07s) --- PASS: TestAccAWSVpc_update (44.39s) --- PASS: TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags (286.82s) --- PASS: TestAccAWSVpcEndpointService_basic (266.19s) --- PASS: TestAccAWSVpcEndpointService_removed (303.85s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…ceData).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12466) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_lambda_function.go:674:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_lambda_function.go:841:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:842:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:843:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:844:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:845:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:884:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:885:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:886:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:887:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:888:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lambda_function.go:931:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSLambdaFunction_basic (64.06s) --- PASS: TestAccAWSLambdaFunction_concurrency (493.45s) --- PASS: TestAccAWSLambdaFunction_concurrencyCycle (529.28s) --- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (536.23s) --- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (148.43s) --- PASS: TestAccAWSLambdaFunction_disappears (94.71s) --- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (68.70s) --- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (561.28s) --- PASS: TestAccAWSLambdaFunction_envVariables (579.67s) --- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (24.88s) --- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (151.22s) --- PASS: TestAccAWSLambdaFunction_Layers (514.42s) --- PASS: TestAccAWSLambdaFunction_LayersUpdate (170.54s) --- PASS: TestAccAWSLambdaFunction_localUpdate (523.11s) --- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (486.27s) --- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (492.13s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_java11 (83.49s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (78.16s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x (514.99s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs12x (513.46s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (2.32s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (71.48s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (56.73s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (97.54s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (50.94s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_python38 (89.93s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby25 (109.39s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby27 (117.27s) --- PASS: TestAccAWSLambdaFunction_s3 (44.11s) --- PASS: TestAccAWSLambdaFunction_s3Update_basic (74.22s) --- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (68.76s) --- PASS: TestAccAWSLambdaFunction_tags (140.89s) --- PASS: TestAccAWSLambdaFunction_tracingConfig (535.70s) --- PASS: TestAccAWSLambdaFunction_updateRuntime (511.04s) --- PASS: TestAccAWSLambdaFunction_versioned (514.26s) --- PASS: TestAccAWSLambdaFunction_versionedUpdate (607.45s) --- PASS: TestAccAWSLambdaFunction_VPC (2148.53s) --- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (1848.27s) --- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (1568.41s) --- PASS: TestAccAWSLambdaFunction_VPCRemoval (2046.17s) --- PASS: TestAccAWSLambdaFunction_VPCUpdate (2526.06s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…urceData).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12467) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_api_gateway_stage.go:134:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_api_gateway_stage.go:178:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:179:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:180:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:181:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:182:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:183:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:205:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:206:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:207:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_api_gateway_stage.go:291:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_api_gateway_stage.go:398:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:399:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:400:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:401:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:402:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:428:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:429:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_api_gateway_stage.go:430:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSAPIGatewayStage_accessLogSettings (260.87s) --- PASS: TestAccAWSAPIGatewayStage_accessLogSettings_kinesis (388.36s) --- PASS: TestAccAWSAPIGatewayStage_basic (469.04s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…ta).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12468) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_lb_listener_rule.go:1083:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lb_listener_rule.go:1093:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_lb_listener_rule.go:1107:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_lb_listener_rule.go:931:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_lb_listener_rule.go:948:3: R008: deprecated (schema.ResourceData).SetPartial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSLBListenerRule_Action_Order (192.70s) --- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (223.40s) --- PASS: TestAccAWSLBListenerRule_basic (267.91s) --- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (216.77s) --- PASS: TestAccAWSLBListenerRule_cognito (211.46s) --- PASS: TestAccAWSLBListenerRule_conditionAttributesCount (29.28s) --- PASS: TestAccAWSLBListenerRule_conditionHostHeader (191.30s) --- PASS: TestAccAWSLBListenerRule_conditionHostHeader_deprecated (190.31s) --- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (181.36s) --- PASS: TestAccAWSLBListenerRule_conditionHttpHeader_invalid (2.67s) --- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (180.78s) --- PASS: TestAccAWSLBListenerRule_conditionMultiple (219.93s) --- PASS: TestAccAWSLBListenerRule_conditionPathPattern (221.77s) --- PASS: TestAccAWSLBListenerRule_conditionPathPattern_deprecated (220.00s) --- PASS: TestAccAWSLBListenerRule_conditionQueryString (191.65s) --- PASS: TestAccAWSLBListenerRule_conditionSourceIp (275.03s) --- PASS: TestAccAWSLBListenerRule_conditionUpdateMixed (284.65s) --- PASS: TestAccAWSLBListenerRule_conditionUpdateMultiple (258.87s) --- PASS: TestAccAWSLBListenerRule_conditionUpdatePathPattern_deprecated (355.25s) --- PASS: TestAccAWSLBListenerRule_fixedResponse (217.28s) --- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (2.66s) --- PASS: TestAccAWSLBListenerRule_oidc (188.46s) --- PASS: TestAccAWSLBListenerRule_priority (406.08s) --- PASS: TestAccAWSLBListenerRule_redirect (189.54s) --- PASS: TestAccAWSLBListenerRule_updateFixedResponse (222.80s) --- PASS: TestAccAWSLBListenerRule_updateRulePriority (225.24s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…ed (helper/schema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12469) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_codestarnotifications_notification_rule.go:236:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_codestarnotifications_notification_rule.go:251:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_codestarnotifications_notification_rule.go:252:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_codestarnotifications_notification_rule.go:253:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_codestarnotifications_notification_rule.go:254:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_codestarnotifications_notification_rule.go:270:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSCodeStarNotificationsNotificationRule_Basic (26.58s) --- PASS: TestAccAWSCodeStarNotificationsNotificationRule_EventTypeIds (49.15s) --- PASS: TestAccAWSCodeStarNotificationsNotificationRule_Status (61.55s) --- PASS: TestAccAWSCodeStarNotificationsNotificationRule_Tags (49.81s) --- PASS: TestAccAWSCodeStarNotificationsNotificationRule_Targets (48.94s) ```
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this issue
May 28, 2020
…tial() and (helper/schema.ResourceData).SetPartial() (hashicorp#12462) Reference: hashicorp#12083 Reference: hashicorp#12087 Previously: ``` aws/resource_aws_sagemaker_endpoint.go:135:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_endpoint.go:144:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_sagemaker_endpoint.go:156:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_sagemaker_endpoint.go:168:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_model.go:284:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_model.go:294:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_notebook_instance.go:217:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_sagemaker_notebook_instance.go:226:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_sagemaker_notebook_instance.go:328:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSSagemakerEndpoint_basic (485.91s) --- PASS: TestAccAWSSagemakerEndpoint_EndpointConfigName (852.16s) --- PASS: TestAccAWSSagemakerEndpoint_Tags (525.67s) --- PASS: TestAccAWSSagemakerModel_basic (47.36s) --- PASS: TestAccAWSSagemakerModel_containers (35.84s) --- PASS: TestAccAWSSagemakerModel_networkIsolation (59.84s) --- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (33.08s) --- PASS: TestAccAWSSagemakerModel_primaryContainerHostname (30.86s) --- PASS: TestAccAWSSagemakerModel_primaryContainerModelDataUrl (57.54s) --- PASS: TestAccAWSSagemakerModel_tags (42.35s) --- PASS: TestAccAWSSagemakerModel_vpcConfig (62.13s) --- PASS: TestAccAWSSagemakerNotebookInstance_basic (359.34s) --- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (714.40s) --- PASS: TestAccAWSSagemakerNotebookInstance_disappears (396.62s) --- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (296.66s) --- PASS: TestAccAWSSagemakerNotebookInstance_tags (411.90s) --- PASS: TestAccAWSSagemakerNotebookInstance_update (625.72s) ```
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
May 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
provider
Pertains to the provider itself, rather than any interaction with AWS.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Community Note
Description
As of Terraform Plugin SDK v1.7.0,
(github.com/hashicorp/terraform-plugin-sdk/helper/schema.ResourceData).Partial()
and(github.com/hashicorp/terraform-plugin-sdk/helper/schema.ResourceData).SetPartial()
have been deprecated with no replacement.tfproviderlint check references:
The following files have their usage, which should be removed:
aws/resource_aws_ami.go
aws/resource_aws_ami_copy.go
aws/resource_aws_ami_from_instance.go
aws/resource_aws_api_gateway_stage.go
aws/resource_aws_autoscaling_group.go
aws/resource_aws_codestarnotifications_notification_rule.go
aws/resource_aws_db_cluster_snapshot.go
aws/resource_aws_db_event_subscription.go
aws/resource_aws_db_instance.go
aws/resource_aws_db_option_group.go
aws/resource_aws_db_parameter_group.go
aws/resource_aws_db_security_group.go
aws/resource_aws_db_snapshot.go
aws/resource_aws_db_subnet_group.go
aws/resource_aws_default_network_acl.go
aws/resource_aws_directory_service_directory.go
aws/resource_aws_docdb_cluster.go
aws/resource_aws_docdb_cluster_instance.go
aws/resource_aws_docdb_cluster_parameter_group.go
aws/resource_aws_docdb_subnet_group.go
aws/resource_aws_ec2_client_vpn_endpoint.go
aws/resource_aws_elasticache_parameter_group.go
aws/resource_aws_elb.go
aws/resource_aws_emr_cluster.go
aws/resource_aws_globalaccelerator_accelerator.go
aws/resource_aws_iam_instance_profile.go
aws/resource_aws_instance.go
aws/resource_aws_internet_gateway.go
aws/resource_aws_lambda_function.go
aws/resource_aws_lb_listener_rule.go
aws/resource_aws_licensemanager_license_configuration.go
aws/resource_aws_neptune_cluster.go
aws/resource_aws_neptune_cluster_instance.go
aws/resource_aws_neptune_cluster_parameter_group.go
aws/resource_aws_neptune_event_subscription.go
aws/resource_aws_neptune_parameter_group.go
aws/resource_aws_neptune_subnet_group.go
aws/resource_aws_network_acl.go
aws/resource_aws_network_interface.go
aws/resource_aws_opsworks_rds_db_instance.go
aws/resource_aws_proxy_protocol_policy.go
aws/resource_aws_qldb_ledger.go
aws/resource_aws_rds_cluster.go
aws/resource_aws_rds_cluster_instance.go
aws/resource_aws_rds_cluster_parameter_group.go
aws/resource_aws_redshift_cluster.go
aws/resource_aws_redshift_event_subscription.go
aws/resource_aws_redshift_parameter_group.go
aws/resource_aws_redshift_snapshot_copy_grant.go
aws/resource_aws_redshift_snapshot_schedule.go
aws/resource_aws_redshift_subnet_group.go
aws/resource_aws_route53_resolver_endpoint.go
aws/resource_aws_route53_resolver_rule.go
aws/resource_aws_route53_zone.go
aws/resource_aws_route_table.go
aws/resource_aws_sagemaker_endpoint.go
aws/resource_aws_sagemaker_model.go
aws/resource_aws_sagemaker_notebook_instance.go
aws/resource_aws_security_group.go
aws/resource_aws_spot_fleet_request.go
aws/resource_aws_spot_instance_request.go
aws/resource_aws_subnet.go
aws/resource_aws_vpc.go
aws/resource_aws_vpc_endpoint_service.go
aws/resource_aws_vpc_peering_connection.go
aws/resource_aws_vpn_connection.go
aws/resource_aws_workspaces_directory.go
Definition of Done
-R007
and-R008
flags are added to the tfproviderlint/awsproviderlint command inGNUmakefile
and CI passesThe text was updated successfully, but these errors were encountered: