Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable lint checks R007 and R008 #13087

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Enable lint checks R007 and R008 #13087

merged 1 commit into from
Apr 29, 2020

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Apr 29, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12083

Release note for CHANGELOG:

NONE

Output from acceptance testing:

~/git/go/src/github.com/terraform-providers/terraform-provider-aws appilon/enable-tfproviderlint-r007-r008* 28s
❯ make lint
==> Checking source code against linters...

~/git/go/src/github.com/terraform-providers/terraform-provider-aws appilon/enable-tfproviderlint-r007-r008* 4m 49s
❯ echo $?
0
...

@appilon appilon requested a review from a team April 29, 2020 18:09
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Apr 29, 2020
@bflad bflad added provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 29, 2020
bflad
bflad approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!!! 🚀

@appilon appilon merged commit 7d36028 into master Apr 29, 2020
@appilon appilon deleted the appilon/enable-tfproviderlint-r007-r008 branch April 29, 2020 18:25
@ghost
Copy link

ghost commented May 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 30, 2020
@breathingdust breathingdust added the linter Pertains to changes to or issues with the various linters. label Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix and enable tfproviderlint R007 and R008 checks: Deprecated d.Partial() and d.SetPartial()
3 participants
@appilon @bflad @breathingdust