Fix and enable tfproviderlint R001 check: Use String Literals in Set() Calls

[ryndaniels]

Description

As per tfproviderlint check R001, we want to make sure that we are passing string literals to Set() calls, rather than complex key arguments.

Failing example:

keys := []string{"example1", "example2"}
values := []string{"value1", "value2"}

for idx, key := range keys {
    d.Set(key, values[idx])
}

Should become:

d.Set("example1", "value1")
d.Set("example2", "value2")

Definition of Done

• In GNUmakefile, add -R001 to tfproviderlint command under lint target and have TravisCI testing pass

[bflad]

Snapshot of current reports:

aws/data_source_aws_vpc_dhcp_options.go:114:10: R001: ResourceData.Set() key argument should be string literal
aws/data_source_aws_vpc_dhcp_options.go:116:20: R001: ResourceData.Set() key argument should be string literal
aws/data_source_aws_vpc_dhcp_options.go:120:20: R001: ResourceData.Set() key argument should be string literal
aws/data_source_aws_vpc_dhcp_options.go:124:10: R001: ResourceData.Set() key argument should be string literal
aws/data_source_aws_vpc_dhcp_options.go:126:20: R001: ResourceData.Set() key argument should be string literal
aws/opsworks_layers.go:569:11: R001: ResourceData.Set() key argument should be string literal
aws/opsworks_layers.go:573:12: R001: ResourceData.Set() key argument should be string literal
aws/opsworks_layers.go:576:12: R001: ResourceData.Set() key argument should be string literal
aws/opsworks_layers.go:583:11: R001: ResourceData.Set() key argument should be string literal
aws/opsworks_layers.go:591:10: R001: ResourceData.Set() key argument should be string literal
aws/resource_aws_autoscaling_group_waiting_test.go:126:20: R001: ResourceData.Set() key argument should be string literal
aws/resource_aws_autoscaling_group_waiting_test.go:208:20: R001: ResourceData.Set() key argument should be string literal
aws/resource_aws_flow_log.go:234:9: R001: ResourceData.Set() key argument should be string literal
aws/resource_aws_sns_sms_preferences.go:137:9: R001: ResourceData.Set() key argument should be string literal
aws/resource_aws_sns_sms_preferences.go:144:10: R001: ResourceData.Set() key argument should be string literal
aws/resource_aws_vpc_dhcp_options.go:183:10: R001: ResourceData.Set() key argument should be string literal
aws/resource_aws_vpc_dhcp_options.go:190:10: R001: ResourceData.Set() key argument should be string literal

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.