Fix and enable tfproviderlint S018 check: Use TypeList and MaxItems: 1

[ryndaniels]

Description

As per tfproviderlint check S018, we want to make sure that schemas use Type: TypeList and MaxItems: 1 if possible.

Failing example:

&schema.Schema{
    MaxItems: 1,
    Type:     schema.TypeSet,
}

Should become:

&schema.Schema{
    MaxItems: 1,
    Type:     schema.TypeList,
}

Affected Files

• GNUMakefile
• aws/provider.go
• aws/resource_aws_api_gateway_usage_plan.go
• aws/resource_aws_api_gateway_usage_plan_test.go
• aws/resource_aws_api_gateway_vpc_link.go
• aws/resource_aws_appmesh_virtual_node.go
• aws/resource_aws_appmesh_virtual_router.go
• aws/resource_aws_cloudfront_distribution.go
• aws/resource_aws_codebuild_project_test.go
• aws/resource_aws_ecs_service.go
• aws/resource_aws_eks_node_group.go
• aws/resource_aws_elastic_transcoder_pipeline.go
• aws/resource_aws_elastic_transcoder_preset.go
• aws/resource_aws_fsx_lustre_file_system.go
• aws/resource_aws_fsx_windows_file_system.go
• aws/resource_aws_kinesis_firehose_delivery_stream.go
• aws/resource_aws_s3_bucket.go
• aws/resource_aws_s3_bucket_test.go
• aws/resource_aws_ses_event_destination.go
• aws/resource_aws_vpc_peering_connection.go
• aws/resource_aws_vpc_peering_connection_test.go
• aws/resource_aws_waf_sql_injection_match_set.go
• aws/resource_aws_waf_sql_injection_match_set_test.go
• aws/resource_aws_waf_web_acl.go
• aws/resource_aws_waf_web_acl_test.go
• aws/waf_helpers.go
• aws/resource_aws_waf_byte_match_set.go
• aws/resource_aws_waf_byte_match_set_test.go

Definition of Done

• In GNUmakefile, add -S018 to tfproviderlint command under lint target and have TravisCI testing pass

[ewbankkit]

Related:

• resource/aws_codebuild_project: Migrate Attributes From TypeSet to TypeList #6427

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!