service/waf: update to using typelist

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9956

Release note for CHANGELOG:

service/waf: correct typeset usage with typelist in cases where max_items is 1

Output from acceptance testing:

--- PASS: TestAccAWSWafWebAcl_disappears (11.24s)
--- PASS: TestAccAWSWafSqlInjectionMatchSet_noTuples (14.08s)
--- PASS: TestAccAWSWafSqlInjectionMatchSet_basic (21.40s)
--- PASS: TestAccAWSWafWebAcl_DefaultAction (29.06s)
--- PASS: TestAccAWSWafWebAcl_Tags (44.80s)
--- PASS: TestAccAWSWafWebAcl_changeNameForceNew (49.39s)
--- PASS: TestAccAWSWafSqlInjectionMatchSet_changeNameForceNew (72.47s)
--- PASS: TestAccAWSWafSqlInjectionMatchSet_disappears (78.67s)
--- FAIL: TestAccAWSWafWebAcl_Rules (94.17s) --- seems to be common error: Error deleting WAF Rule: WAFReferencedItemException: This entity is still referenced by other entities.
--- PASS: TestAccAWSWafSqlInjectionMatchSet_changeTuples (98.38s)
--- PASS: TestAccAWSWafWebAcl_basic (112.18s)
--- PASS: TestAccAWSWafWebAcl_LoggingConfiguration (138.36s)

[bflad]

Other than keeping the two aws_waf_sql_injection_match_set tests with DisableBinaryTesting: true, looks good! 🚀

Output from acceptance testing (test failure unrelated):

--- PASS: TestAccAWSWafSqlInjectionMatchSet_disappears (20.47s)
--- PASS: TestAccAWSWafWebAcl_basic (22.43s)
--- PASS: TestAccAWSWafSqlInjectionMatchSet_changeTuples (28.73s)
--- PASS: TestAccAWSWafWebAcl_changeNameForceNew (30.32s)
--- PASS: TestAccAWSWafSqlInjectionMatchSet_basic (46.22s)
--- PASS: TestAccAWSWafWebAcl_DefaultAction (59.33s)
--- PASS: TestAccAWSWafWebAcl_Tags (74.55s)
--- FAIL: TestAccAWSWafWebAcl_Rules (81.65s)
--- PASS: TestAccAWSWafSqlInjectionMatchSet_changeNameForceNew (84.53s)
--- PASS: TestAccAWSWafWebAcl_disappears (86.64s)
--- PASS: TestAccAWSWafSqlInjectionMatchSet_noTuples (98.11s)
--- PASS: TestAccAWSWafWebAcl_LoggingConfiguration (142.32s)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!