Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/kinesis: update to using typelist #13343

Merged
merged 1 commit into from
May 19, 2020
Merged

service/kinesis: update to using typelist #13343

merged 1 commit into from
May 19, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented May 15, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9956

Release note for CHANGELOG:

service/kinesis: correct typeset usage with typelist in cases where max_items is 1

Output from acceptance testing:

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/firehose Issues and PRs that pertain to the firehose service. labels May 15, 2020
@anGie44 anGie44 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label May 15, 2020
@anGie44 anGie44 changed the title resource/kinesis_firehose: update to using typelist service/kinesis: update to using typelist May 15, 2020
@anGie44 anGie44 marked this pull request as ready for review May 18, 2020 21:34
@anGie44 anGie44 requested a review from a team May 18, 2020 21:34
@anGie44 anGie44 marked this pull request as draft May 18, 2020 21:48
bflad
bflad approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource (92.34s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic (97.26s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging (108.51s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_ParquetSerDe_Empty (110.47s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Serializer_Update (115.12s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_basic (117.37s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basic (118.33s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OpenXJsonSerDe_Empty (121.25s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ExternalUpdate (125.27s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3KmsKeyArn (125.95s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ProcessingConfiguration_Empty (126.56s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Enabled (143.06s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3Updates (143.73s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Deserializer_Update (145.12s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OrcSerDe_Empty (145.86s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_HiveJsonSerDe_Empty (145.83s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ErrorOutputPrefix (146.60s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithTags (188.20s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates (199.42s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_SplunkConfigUpdates (130.79s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration (119.18s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithSSE (239.34s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates (431.18s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates (912.74s)

@bflad bflad self-assigned this May 19, 2020
@anGie44 anGie44 marked this pull request as ready for review May 19, 2020 14:31
@anGie44 anGie44 merged commit d9d386a into master May 19, 2020
@anGie44 anGie44 deleted the ap_typelist_kinesis branch May 19, 2020 21:45
@ghost
Copy link

ghost commented Jun 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/firehose Issues and PRs that pertain to the firehose service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @bflad