Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/waf_byte_match_set: update typeset with maxitems of 1 to typelist #13599

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jun 3, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9956

Release note for CHANGELOG:

resource/waf_byte_match_set: update field_to_match attribute to a list and use AWS SDK conversion/constants

Output from acceptance testing:

--- PASS: TestAccAWSWafByteMatchSet_noTuples (18.92s)
--- PASS: TestAccAWSWafByteMatchSet_disappears (21.36s)
--- PASS: TestAccAWSWafByteMatchSet_basic (24.64s)
--- PASS: TestAccAWSWafByteMatchSet_changeNameForceNew (36.21s)
--- PASS: TestAccAWSWafByteMatchSet_changeTuples (37.42s)

@anGie44 anGie44 requested a review from a team June 3, 2020 20:16
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 3, 2020
@anGie44 anGie44 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Jun 3, 2020
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSWafByteMatchSet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSWafByteMatchSet_ -timeout 120m
=== RUN   TestAccAWSWafByteMatchSet_basic
=== PAUSE TestAccAWSWafByteMatchSet_basic
=== RUN   TestAccAWSWafByteMatchSet_changeNameForceNew
=== PAUSE TestAccAWSWafByteMatchSet_changeNameForceNew
=== RUN   TestAccAWSWafByteMatchSet_changeTuples
=== PAUSE TestAccAWSWafByteMatchSet_changeTuples
=== RUN   TestAccAWSWafByteMatchSet_noTuples
=== PAUSE TestAccAWSWafByteMatchSet_noTuples
=== RUN   TestAccAWSWafByteMatchSet_disappears
=== PAUSE TestAccAWSWafByteMatchSet_disappears
=== CONT  TestAccAWSWafByteMatchSet_basic
=== CONT  TestAccAWSWafByteMatchSet_noTuples
=== CONT  TestAccAWSWafByteMatchSet_disappears
=== CONT  TestAccAWSWafByteMatchSet_changeTuples
=== CONT  TestAccAWSWafByteMatchSet_changeNameForceNew
--- PASS: TestAccAWSWafByteMatchSet_basic (23.52s)
--- PASS: TestAccAWSWafByteMatchSet_noTuples (24.13s)
--- PASS: TestAccAWSWafByteMatchSet_disappears (26.16s)
--- PASS: TestAccAWSWafByteMatchSet_changeTuples (42.59s)
--- PASS: TestAccAWSWafByteMatchSet_changeNameForceNew (43.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	43.715s

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccAWSWafByteMatchSet_changeTuples (29.63s)
--- PASS: TestAccAWSWafByteMatchSet_noTuples (31.60s)
--- PASS: TestAccAWSWafByteMatchSet_changeNameForceNew (35.58s)
--- PASS: TestAccAWSWafByteMatchSet_disappears (36.28s)
--- PASS: TestAccAWSWafByteMatchSet_basic (40.00s)

@anGie44 anGie44 merged commit 6bc1f0c into master Jun 5, 2020
@anGie44 anGie44 deleted the ap_S018_waf_byte_match_set_list branch June 5, 2020 18:55
@ghost
Copy link

ghost commented Jul 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/waf Issues and PRs that pertain to the waf service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants