-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service/rds: Remove deprecated (helper/schema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() #12477
Conversation
… and (helper/schema.ResourceData).SetPartial() Reference: #12083 Reference: #12087 Previously: ``` aws/resource_aws_db_cluster_snapshot.go:197:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:239:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_event_subscription.go:296:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:297:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:298:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:299:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:309:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:351:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_event_subscription.go:354:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_instance.go:1473:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_instance.go:1480:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1488:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1489:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1495:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1501:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1506:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1511:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1516:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1521:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1526:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1531:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1537:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1542:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1547:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1561:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1566:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1571:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1576:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1585:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1591:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1597:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1617:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1623:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1628:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1634:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1645:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1646:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1653:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1657:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1662:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1732:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_instance.go:1735:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_option_group.go:288:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_option_group.go:299:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_parameter_group.go:116:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_parameter_group.go:117:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_parameter_group.go:118:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_parameter_group.go:119:2: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_parameter_group.go:120:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_parameter_group.go:249:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_parameter_group.go:331:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_parameter_group.go:334:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_security_group.go:199:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_security_group.go:208:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_security_group.go:246:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_db_snapshot.go:224:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_db_subnet_group.go:199:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster.go:1121:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster.go:1137:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster.go:1143:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster.go:1149:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster.go:1246:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:493:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:499:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:503:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:511:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:517:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:523:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:529:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:535:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:541:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:547:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_instance.go:553:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_parameter_group.go:185:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_rds_cluster_parameter_group.go:274:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_rds_cluster_parameter_group.go:277:2: R007: deprecated (schema.ResourceData).Partial ``` Output from acceptance testing (test failures present on master): ``` --- PASS: TestAccAWSDBClusterSnapshot_basic (161.83s) --- PASS: TestAccAWSDBClusterSnapshot_Tags (208.14s) --- PASS: TestAccAWSDBEventSubscription_basicUpdate (127.65s) --- PASS: TestAccAWSDBEventSubscription_categoryUpdate (125.24s) --- PASS: TestAccAWSDBEventSubscription_disappears (78.82s) --- PASS: TestAccAWSDBEventSubscription_withPrefix (81.72s) --- PASS: TestAccAWSDBEventSubscription_withSourceIds (101.26s) --- FAIL: TestAccAWSDBInstance_S3Import (671.95s) --- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (443.80s) --- PASS: TestAccAWSDBInstance_basic (566.04s) --- PASS: TestAccAWSDBInstance_CACertificateIdentifier (623.72s) --- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (530.77s) --- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfigurationUpdate (956.15s) --- PASS: TestAccAWSDBInstance_DeletionProtection (584.27s) --- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (698.62s) --- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (760.80s) --- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (623.55s) --- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (813.02s) --- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (742.11s) --- PASS: TestAccAWSDBInstance_generatedName (473.76s) --- PASS: TestAccAWSDBInstance_iamAuth (423.49s) --- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (539.38s) --- PASS: TestAccAWSDBInstance_kmsKey (462.25s) --- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (625.94s) --- PASS: TestAccAWSDBInstance_MinorVersion (496.98s) --- PASS: TestAccAWSDBInstance_MonitoringInterval (1038.16s) --- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (795.78s) --- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (804.57s) --- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (822.91s) --- PASS: TestAccAWSDBInstance_MSSQL_Domain (3671.81s) --- PASS: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (2811.43s) --- PASS: TestAccAWSDBInstance_MSSQL_TZ (1625.50s) --- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1902.87s) --- PASS: TestAccAWSDBInstance_namePrefix (485.32s) --- PASS: TestAccAWSDBInstance_NoDeleteAutomatedBackups (654.56s) --- PASS: TestAccAWSDBInstance_optionGroup (499.87s) --- PASS: TestAccAWSDBInstance_Password (574.56s) --- PASS: TestAccAWSDBInstance_portUpdate (504.62s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1527.99s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1476.93s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1370.52s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1482.23s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1824.62s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1598.16s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (1454.94s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1538.08s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1582.77s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1594.36s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1753.26s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (2145.53s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1695.43s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (1860.48s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1448.57s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1540.51s) --- PASS: TestAccAWSDBInstance_separate_iops_update (781.70s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1327.39s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1519.07s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (2303.64s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1187.05s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1298.15s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1644.94s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1704.80s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1307.64s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1235.72s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1295.56s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1804.10s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1324.91s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1118.39s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1256.49s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (1893.83s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (3726.44s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1341.16s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (1369.24s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1241.65s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1180.23s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1150.78s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1127.44s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1305.53s) --- PASS: TestAccAWSDBInstance_subnetGroup (1056.41s) --- PASS: TestAccAWSDBOptionGroup_basic (20.09s) --- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (505.73s) --- PASS: TestAccAWSDBOptionGroup_generatedName (25.87s) --- PASS: TestAccAWSDBOptionGroup_multipleOptions (36.35s) --- PASS: TestAccAWSDBOptionGroup_namePrefix (40.96s) --- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings (120.52s) --- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_IAMRole (62.67s) --- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_MultipleNonDefault (67.17s) --- PASS: TestAccAWSDBOptionGroup_OracleOptionsUpdate (110.44s) --- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (82.61s) --- PASS: TestAccAWSDBOptionGroup_Tags (65.48s) --- PASS: TestAccAWSDBOptionGroup_Tags_WithOptions (65.91s) --- PASS: TestAccAWSDBOptionGroup_timeoutBlock (26.29s) --- PASS: TestAccAWSDBParameterGroup_basic (113.24s) --- PASS: TestAccAWSDBParameterGroup_Disappears (17.07s) --- PASS: TestAccAWSDBParameterGroup_generatedName (41.36s) --- PASS: TestAccAWSDBParameterGroup_limit (84.28s) --- PASS: TestAccAWSDBParameterGroup_MatchDefault (61.75s) --- PASS: TestAccAWSDBParameterGroup_namePrefix (48.96s) --- PASS: TestAccAWSDBParameterGroup_Only (39.17s) --- PASS: TestAccAWSDBParameterGroup_withApplyMethod (51.68s) --- PASS: TestAccAWSDBSecurityGroup_basic (13.66s) --- PASS: TestAccAWSDBSnapshot_basic (755.49s) --- PASS: TestAccAWSDBSnapshot_disappears (617.74s) --- PASS: TestAccAWSDBSnapshot_tags (651.91s) --- PASS: TestAccAWSDBSubnetGroup_basic (35.79s) --- PASS: TestAccAWSDBSubnetGroup_generatedName (35.00s) --- PASS: TestAccAWSDBSubnetGroup_namePrefix (35.59s) --- PASS: TestAccAWSDBSubnetGroup_updateDescription (61.68s) --- PASS: TestAccAWSDBSubnetGroup_withUndocumentedCharacters (42.07s) --- FAIL: TestAccAWSRDSCluster_s3Restore (1624.16s) --- PASS: TestAccAWSRDSCluster_AvailabilityZones (240.79s) --- PASS: TestAccAWSRDSCluster_BacktrackWindow (248.08s) --- PASS: TestAccAWSRDSCluster_backupsUpdate (183.26s) --- PASS: TestAccAWSRDSCluster_basic (236.10s) --- PASS: TestAccAWSRDSCluster_ClusterIdentifierPrefix (123.32s) --- PASS: TestAccAWSRDSCluster_copyTagsToSnapshot (224.31s) --- PASS: TestAccAWSRDSCluster_DbSubnetGroupName (214.54s) --- PASS: TestAccAWSRDSCluster_DeletionProtection (164.87s) --- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports (446.46s) --- PASS: TestAccAWSRDSCluster_EnableHttpEndpoint (311.62s) --- PASS: TestAccAWSRDSCluster_encrypted (122.89s) --- PASS: TestAccAWSRDSCluster_EncryptedCrossRegionReplication (1804.90s) --- PASS: TestAccAWSRDSCluster_EngineMode (414.68s) --- PASS: TestAccAWSRDSCluster_EngineMode_Global (132.28s) --- PASS: TestAccAWSRDSCluster_EngineMode_Multimaster (212.05s) --- PASS: TestAccAWSRDSCluster_EngineMode_ParallelQuery (225.62s) --- PASS: TestAccAWSRDSCluster_EngineVersion (136.38s) --- PASS: TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance (1114.96s) --- PASS: TestAccAWSRDSCluster_generatedName (131.15s) --- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier (203.57s) --- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Add (231.16s) --- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Remove (215.27s) --- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Update (210.72s) --- PASS: TestAccAWSRDSCluster_iamAuth (131.99s) --- PASS: TestAccAWSRDSCluster_kmsKey (150.06s) --- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (7.08s) --- PASS: TestAccAWSRDSCluster_Port (362.74s) --- PASS: TestAccAWSRDSCluster_ScalingConfiguration (410.44s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier (419.84s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection (411.50s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore (352.20s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery (455.74s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned (393.86s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different (373.62s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal (373.42s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword (459.57s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername (433.11s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow (407.91s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow (371.35s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_Tags (374.56s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds (414.24s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags (404.15s) --- PASS: TestAccAWSRDSCluster_Tags (152.46s) --- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (152.36s) --- PASS: TestAccAWSRDSCluster_updateIamRoles (173.37s) --- FAIL: TestAccAWSRDSClusterInstance_CACertificateIdentifier (819.09s) --- PASS: TestAccAWSRDSClusterInstance_az (745.73s) --- PASS: TestAccAWSRDSClusterInstance_basic (1460.33s) --- PASS: TestAccAWSRDSClusterInstance_CopyTagsToSnapshot (693.56s) --- PASS: TestAccAWSRDSClusterInstance_disappears (696.91s) --- PASS: TestAccAWSRDSClusterInstance_generatedName (720.86s) --- PASS: TestAccAWSRDSClusterInstance_isAlreadyBeingDeleted (708.46s) --- PASS: TestAccAWSRDSClusterInstance_kmsKey (1376.64s) --- PASS: TestAccAWSRDSClusterInstance_MonitoringInterval (1298.65s) --- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled (941.01s) --- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved (965.68s) --- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled (841.84s) --- PASS: TestAccAWSRDSClusterInstance_namePrefix (1063.96s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1 (858.33s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2 (804.60s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql (794.16s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1 (817.10s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey (764.17s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2 (850.24s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey (847.01s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql (786.92s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey (753.94s) --- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (762.33s) ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
--- PASS: TestAccAWSDBEventSubscription_withPrefix (70.81s)
--- PASS: TestAccAWSDBEventSubscription_disappears (70.81s)
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (77.79s)
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (106.67s)
--- PASS: TestAccAWSDBEventSubscription_basicUpdate (106.80s)
--- PASS: TestAccAWSDBClusterSnapshot_Tags (156.02s)
--- PASS: TestAccAWSDBClusterSnapshot_basic (202.76s)
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (446.38s)
--- PASS: TestAccAWSDBInstance_kmsKey (464.06s)
--- SKIP: TestAccAWSDBInstance_ReplicateSourceDb_DeletionProtection (0.00s)
--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (490.17s)
--- PASS: TestAccAWSDBInstance_iamAuth (494.78s)
--- PASS: TestAccAWSDBInstance_basic (505.95s)
--- PASS: TestAccAWSDBInstance_namePrefix (515.63s)
--- PASS: TestAccAWSDBInstance_generatedName (515.73s)
--- PASS: TestAccAWSDBInstance_optionGroup (516.16s)
--- PASS: TestAccAWSDBInstance_DeletionProtection (551.45s)
--- PASS: TestAccAWSDBInstance_Password (525.82s)
--- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (622.56s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (828.98s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (971.10s)
--- PASS: TestAccAWSDBInstance_subnetGroup (971.42s)
--- FAIL: TestAccAWSDBInstance_S3Import (681.51s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1493.92s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1493.73s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1595.62s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1637.52s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1665.92s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1807.43s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1403.86s)
--- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_RamShared (0.78s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1079.31s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1463.63s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1584.94s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (1443.41s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1596.71s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1557.44s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1625.37s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1637.23s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1736.43s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1452.76s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (1979.16s)
--- SKIP: TestAccAWSDBInstance_SnapshotIdentifier_Tags_Unset (0.00s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1796.12s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1292.28s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1301.50s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName (1092.52s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_VpcSecurityGroupIds (1081.91s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1170.57s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1156.39s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1190.61s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1452.23s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1130.28s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1250.85s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (2029.35s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1251.18s)
--- SKIP: TestAccAWSDBInstance_ec2Classic (1.20s)
--- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1642.58s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1200.87s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1455.17s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1119.98s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (717.52s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (660.92s)
--- PASS: TestAccAWSDBInstance_portUpdate (599.59s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1212.83s)
--- PASS: TestAccAWSDBInstance_separate_iops_update (710.55s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (774.45s)
--- PASS: TestAccAWSDBInstance_MinorVersion (431.64s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (963.26s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (578.20s)
--- PASS: TestAccAWSDBOptionGroup_basic (8.17s)
--- PASS: TestAccAWSDBOptionGroup_timeoutBlock (7.61s)
--- PASS: TestAccAWSDBOptionGroup_namePrefix (7.78s)
--- PASS: TestAccAWSDBOptionGroup_generatedName (7.90s)
--- PASS: TestAccAWSDBOptionGroupConfig_OptionGroupDescription (7.72s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (1917.89s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1262.77s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings (13.73s)
--- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (12.75s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_IAMRole (26.56s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (523.65s)
--- PASS: TestAccAWSDBOptionGroup_OracleOptionsUpdate (14.83s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_MultipleNonDefault (12.96s)
--- PASS: TestAccAWSDBOptionGroup_multipleOptions (7.66s)
--- PASS: TestAccAWSDBOptionGroup_Tags (17.32s)
--- PASS: TestAccAWSDBOptionGroup_Tags_WithOptions (18.23s)
--- PASS: TestAccAWSDBParameterGroup_Disappears (6.83s)
--- PASS: TestAccAWSDBParameterGroup_basic (20.64s)
--- PASS: TestAccAWSDBParameterGroup_namePrefix (7.77s)
--- PASS: TestAccAWSDBParameterGroup_limit (17.56s)
--- PASS: TestAccAWSDBParameterGroup_generatedName (7.87s)
--- PASS: TestAccAWSDBParameterGroup_Only (8.04s)
--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (8.67s)
--- PASS: TestAccAWSDBParameterGroup_MatchDefault (8.43s)
--- FAIL: TestAccAWSDBSecurityGroup_basic (8.51s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (685.62s)
--- PASS: TestAccAWSDBSubnetGroup_basic (11.64s)
--- PASS: TestAccAWSDBSubnetGroup_namePrefix (11.76s)
--- PASS: TestAccAWSDBSubnetGroup_generatedName (11.84s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfigurationUpdate (748.68s)
--- PASS: TestAccAWSDBSubnetGroup_withUndocumentedCharacters (12.04s)
--- PASS: TestAccAWSDBSubnetGroup_updateDescription (18.63s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (756.28s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsEnabled_DisabledToEnabled (711.01s)
--- PASS: TestAccAWSDBInstance_NoDeleteAutomatedBackups (765.32s)
--- FAIL: TestAccAWSDBInstance_CACertificateIdentifier (600.94s)
--- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (483.26s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsEnabled_EnabledToDisabled (882.38s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsRetentionPeriod (913.12s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsKmsKeyId (977.80s)
--- PASS: TestAccAWSDBSnapshot_basic (622.97s)
--- PASS: TestAccAWSDBSnapshot_disappears (713.24s)
--- PASS: TestAccAWSDBSnapshot_tags (738.35s)
--- PASS: TestAccAWSDBInstance_MSSQL_TZ (1765.53s)
--- PASS: TestAccAWSRDSClusterInstance_namePrefix (628.75s)
--- PASS: TestAccAWSRDSClusterInstance_generatedName (608.40s)
--- PASS: TestAccAWSRDSClusterInstance_az (697.13s)
--- PASS: TestAccAWSRDSClusterInstance_kmsKey (685.33s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (1422.34s)
--- PASS: TestAccAWSRDSClusterInstance_disappears (710.92s)
--- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (702.19s)
--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1978.32s)
--- PASS: TestAccAWSRDSClusterInstance_CopyTagsToSnapshot (682.38s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (1715.67s)
--- FAIL: TestAccAWSRDSClusterInstance_MonitoringInterval (810.01s)
--- PASS: TestAccAWSRDSCluster_basic (99.68s)
--- PASS: TestAccAWSRDSCluster_AvailabilityZones (130.70s)
--- PASS: TestAccAWSRDSClusterInstance_isAlreadyBeingDeleted (1423.20s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1 (777.36s)
--- PASS: TestAccAWSRDSCluster_BacktrackWindow (144.92s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2 (757.13s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved (906.35s)
--- PASS: TestAccAWSRDSCluster_DbSubnetGroupName (113.96s)
--- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (3.61s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql (757.07s)
--- PASS: TestAccAWSRDSCluster_ClusterIdentifierPrefix (129.81s)
--- PASS: TestAccAWSRDSCluster_generatedName (119.46s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey (709.97s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1 (868.15s)
--- PASS: TestAccAWSRDSCluster_Tags (129.63s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled (1150.02s)
--- PASS: TestAccAWSRDSCluster_kmsKey (128.46s)
--- PASS: TestAccAWSRDSCluster_updateIamRoles (135.85s)
--- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (150.11s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (3786.78s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql (686.80s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2 (748.62s)
--- FAIL: TestAccAWSRDSClusterInstance_CACertificateIdentifier (602.25s)
--- PASS: TestAccAWSRDSCluster_encrypted (119.51s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey (750.32s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey (720.86s)
--- PASS: TestAccAWSRDSCluster_iamAuth (109.66s)
--- PASS: TestAccAWSRDSCluster_EngineMode_Global (120.01s)
--- PASS: TestAccAWSRDSCluster_DeletionProtection (144.61s)
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports (286.64s)
--- PASS: TestAccAWSRDSCluster_copyTagsToSnapshot (180.63s)
--- PASS: TestAccAWSRDSCluster_EngineVersion (101.78s)
--- PASS: TestAccAWSRDSCluster_backupsUpdate (174.87s)
--- PASS: TestAccAWSRDSCluster_EngineMode_Multimaster (123.63s)
--- SKIP: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Serverless (0.00s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Add (114.82s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier (125.05s)
--- PASS: TestAccAWSRDSCluster_EngineMode_ParallelQuery (159.69s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Remove (129.47s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Update (127.08s)
--- PASS: TestAccAWSRDSClusterInstance_basic (1944.46s)
--- PASS: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (2990.15s)
--- PASS: TestAccAWSRDSCluster_Port (236.48s)
--- PASS: TestAccAWSRDSCluster_EngineMode (460.54s)
--- PASS: TestAccAWSDBInstance_MSSQL_Domain (3238.68s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned (318.15s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier (357.53s)
--- PASS: TestAccAWSRDSCluster_ScalingConfiguration (369.57s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection (373.63s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different (357.05s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal (357.69s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_Tags (317.12s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow (327.15s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername (357.44s)
--- FAIL: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow (333.69s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword (377.65s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery (418.03s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds (379.44s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags (329.05s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled (1784.36s)
--- PASS: TestAccAWSRDSCluster_EnableHttpEndpoint (318.61s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore (377.89s)
--- PASS: TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance (1094.63s)
--- FAIL: TestAccAWSRDSCluster_s3Restore (1471.81s)
--- PASS: TestAccAWSRDSCluster_EncryptedCrossRegionReplication (1755.49s)
The 10 test failures are unrelated to this change:
TestAccAWSDBInstance_S3Import
TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_RamShared
TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds
TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset
TestAccAWSDBSecurityGroup_basic
TestAccAWSDBInstance_CACertificateIdentifier
TestAccAWSRDSClusterInstance_MonitoringInterval
TestAccAWSRDSClusterInstance_CACertificateIdentifier
TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow
TestAccAWSRDSCluster_s3Restore
This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Reference: #12083
Reference: #12087
Release note for CHANGELOG:
Previously:
Output from acceptance testing (test failures present on master):