Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "operation_name" on the aws_api_gateway_method resource #13232

Closed
wperron opened this issue May 8, 2020 · 3 comments · Fixed by #13282
Closed

Add support for "operation_name" on the aws_api_gateway_method resource #13232

wperron opened this issue May 8, 2020 · 3 comments · Fixed by #13282
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service.
Milestone

Comments

@wperron
Copy link
Contributor

wperron commented May 8, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

To make it more convenient to use API Gateway's generated SDK with APIs created via Terraform, it would be interesting to add support for the "operation_name" option on the aws_api_gateway_method resource. The option is already supported by the putMethod and updateMethod actions on the API Gateway API so this is probably a very simple change to implement

New or Affected Resource(s)

  • aws_api_gateway_method

Potential Terraform Configuration

resource "aws_api_gateway_method" "list_foo" {
  authorization  = "NONE"
  http_method    = "GET"
  resource_id    = aws_api_gateway_rest_api.my_api.foo
  rest_api_id    = aws_api_gateway_rest_api.my_api.id
  operation_name = "listFoos"
}
@wperron wperron added the enhancement Requests to existing resources that expand the functionality or scope. label May 8, 2020
@ghost ghost added the service/apigateway Issues and PRs that pertain to the apigateway service. label May 8, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 8, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jan 13, 2021
@bflad bflad self-assigned this Jan 13, 2021
@bflad bflad added this to the v3.24.0 milestone Jan 13, 2021
@bflad bflad closed this as completed in d283ae5 Jan 13, 2021
bflad added a commit that referenced this issue Jan 13, 2021
@bflad
Copy link
Contributor

bflad commented Jan 13, 2021

Support for this functionality has been merged and will release with version 3.24.0 of the Terraform AWS Provider, later this week. Thank you to @wperron for the implementation. 👍

@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 12, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants