-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service/apigateway: added operation_name
attribute to API G. method
#13282
Conversation
d014343
to
bbb053b
Compare
0bff798
to
24070de
Compare
cb8484c
to
2539453
Compare
8608abe
to
1f2784d
Compare
This commit adds the `operation_name` attribute to the `aws_api_gateway_method` resource. This attribute allows users to specify a custom function name to be used when using API Gateway to generate an SDK. The attribute is already supported by the AWS API and SDKs so there was really no reason not to include it. It also made it a pretty straight forward change. This commit also includes: * test cases for the new attribute * updated documentation for the resource Closes hashicorp#13232
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting this, @wperron. After fixing up the merge conflict, looks good to me. 🚀
Output from acceptance testing:
--- PASS: TestAccAWSAPIGatewayMethod_disappears (14.37s)
--- PASS: TestAccAWSAPIGatewayMethod_cognitoauthorizer (47.44s)
--- PASS: TestAccAWSAPIGatewayMethod_customrequestvalidator (75.51s)
--- PASS: TestAccAWSAPIGatewayMethod_customauthorizer (108.34s)
--- PASS: TestAccAWSAPIGatewayMethod_customoperationname (223.20s)
--- PASS: TestAccAWSAPIGatewayMethod_basic (419.16s)
This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
This commit adds the
operation_name
attribute to theaws_api_gateway_method
resource. This attribute allows users to specify a custom function name to be
used when using API Gateway to generate an SDK. The attribute is already
supported by the AWS API and SDKs so there was really no reason not to include
it. It also made it a pretty straight forward change. This commit also includes:
Closes #13232
Community Note
Release note for CHANGELOG:
Output from acceptance testing: