provider: Introduce tag resource generator, new aws_dynamodb_tag and aws_ecs_tag resources #13783

bflad · 2020-06-17T04:47:30Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #6859
Closes #9061
Closes #11951
Closes #13725

Release note for CHANGELOG:

* **New Resource:** `aws_dynamodb_tag`
* **New Resource:** `aws_ecs_tag`

Output from acceptance testing:

--- PASS: TestAccAWSDynamodbTag_disappears (27.18s)
--- PASS: TestAccAWSDynamodbTag_basic (31.00s)
--- PASS: TestAccAWSDynamodbTag_Value (42.71s)
--- PASS: TestAccAWSDynamodbTag_ResourceArn_TableReplica (159.24s)

--- PASS: TestAccAWSEc2Tag_disappears (429.66s)
--- PASS: TestAccAWSEc2Tag_Value (530.85s)
--- PASS: TestAccAWSEc2Tag_basic (537.38s)

--- PASS: TestAccAWSEcsTag_disappears (29.26s)
--- PASS: TestAccAWSEcsTag_basic (31.50s)
--- PASS: TestAccAWSEcsTag_Value (42.11s)
--- PASS: TestAccAWSEcsTag_ResourceArn_BatchComputeEnvironment (46.40s)

DrFaust92 · 2020-06-17T07:51:15Z

Hey @bflad, is it possible to add asg_tag as well to this PR?
like proposed in #13643? or does it differ to much from this logic

bflad · 2020-06-17T14:37:46Z

@DrFaust92 unfortunately Auto Scaling service tags differ from other services since they contain an extra PropagateAtLaunch field, which cannot be handled in the keyvaluetags package at the moment and subsequently this generator. I'll write up a separate issue since we would like to tackle Auto Scaling tags more holistically.

gdavison · 2021-02-16T20:57:23Z

@bflad, can you please rebase this?

gdavison

I have a few comments, otherwise looks good. I'll complete the review once this PR has been rebased

aws/resource_aws_dynamodb_tag_gen.go

aws/resource_aws_dynamodb_tag_gen_test.go

aws/resource_aws_ec2_tag_gen_test.go

docs/contributing/contribution-checklists.md

bflad · 2021-03-25T00:37:14Z

Alrighty -- everything has been rebased and modernized.

Latest output from acceptance testing:

--- PASS: TestAccAWSDynamodbTag_basic (37.69s)
--- PASS: TestAccAWSDynamodbTag_disappears (41.74s)
--- PASS: TestAccAWSDynamodbTag_ResourceArn_TableReplica (259.64s)
--- PASS: TestAccAWSDynamodbTag_Value (53.88s)

--- PASS: TestAccAWSEc2Tag_basic (592.92s)
--- PASS: TestAccAWSEc2Tag_disappears (576.53s)
--- PASS: TestAccAWSEc2Tag_Value (714.84s)

--- PASS: TestAccAWSEcsTag_basic (41.02s)
--- PASS: TestAccAWSEcsTag_disappears (40.40s)
--- PASS: TestAccAWSEcsTag_ResourceArn_BatchComputeEnvironment (54.92s)
--- PASS: TestAccAWSEcsTag_Value (50.42s)

bflad · 2021-04-21T17:45:26Z

@gdavison is there anything else that needs to be done?

ewbankkit · 2021-04-26T11:56:44Z

Not reviewing any specific details of this PR, more a general comment:
Would collapsing the err and exists return values from the keyvaluetags.<Service>GetTag function so that a resourceNotFoundError is equivalent to !exists be more consistent with where we are thinking of going with resource-not-found error handling (#15945)?

Reference: #6859 Reference: #13725 Output from acceptance testing: ``` --- PASS: TestAccAWSDynamodbTag_disappears (27.18s) --- PASS: TestAccAWSDynamodbTag_basic (31.00s) --- PASS: TestAccAWSDynamodbTag_Value (42.71s) --- PASS: TestAccAWSDynamodbTag_ResourceArn_TableReplica (159.24s) ```

Reference: #9061

…rorCheck in tests

… ensure errors are properly returned

…ation for Terraform Plugin SDK v2 Output from acceptance testing: ``` --- PASS: TestAccAWSDynamodbTag_basic (37.69s) --- PASS: TestAccAWSDynamodbTag_disappears (41.74s) --- PASS: TestAccAWSDynamodbTag_ResourceArn_TableReplica (259.64s) --- PASS: TestAccAWSDynamodbTag_Value (53.88s) --- PASS: TestAccAWSEc2Tag_basic (592.92s) --- PASS: TestAccAWSEc2Tag_disappears (576.53s) --- PASS: TestAccAWSEc2Tag_Value (714.84s) --- PASS: TestAccAWSEcsTag_basic (41.02s) --- PASS: TestAccAWSEcsTag_disappears (40.40s) --- PASS: TestAccAWSEcsTag_ResourceArn_BatchComputeEnvironment (54.92s) --- PASS: TestAccAWSEcsTag_Value (50.42s) ```

…s not found.

% make testacc TESTARGS='-run=TestAccAWSDynamodbTag_\|TestAccAWSEc2Tag_\|TestAccAWSEcsTag_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDynamodbTag_\|TestAccAWSEc2Tag_\|TestAccAWSEcsTag_ -timeout 180m === RUN TestAccAWSDynamodbTag_basic === PAUSE TestAccAWSDynamodbTag_basic === RUN TestAccAWSDynamodbTag_disappears === PAUSE TestAccAWSDynamodbTag_disappears === RUN TestAccAWSDynamodbTag_ResourceArn_TableReplica === PAUSE TestAccAWSDynamodbTag_ResourceArn_TableReplica === RUN TestAccAWSDynamodbTag_Value === PAUSE TestAccAWSDynamodbTag_Value === RUN TestAccAWSEc2Tag_basic === PAUSE TestAccAWSEc2Tag_basic === RUN TestAccAWSEc2Tag_disappears === PAUSE TestAccAWSEc2Tag_disappears === RUN TestAccAWSEc2Tag_Value === PAUSE TestAccAWSEc2Tag_Value === RUN TestAccAWSEcsTag_basic === PAUSE TestAccAWSEcsTag_basic === RUN TestAccAWSEcsTag_disappears === PAUSE TestAccAWSEcsTag_disappears === RUN TestAccAWSEcsTag_ResourceArn_BatchComputeEnvironment === PAUSE TestAccAWSEcsTag_ResourceArn_BatchComputeEnvironment === RUN TestAccAWSEcsTag_Value === PAUSE TestAccAWSEcsTag_Value === CONT TestAccAWSDynamodbTag_basic === CONT TestAccAWSEc2Tag_Value === CONT TestAccAWSDynamodbTag_disappears === CONT TestAccAWSEcsTag_basic === CONT TestAccAWSDynamodbTag_Value === CONT TestAccAWSEc2Tag_disappears === CONT TestAccAWSEc2Tag_basic === CONT TestAccAWSEcsTag_ResourceArn_BatchComputeEnvironment === CONT TestAccAWSDynamodbTag_ResourceArn_TableReplica === CONT TestAccAWSEcsTag_Value === CONT TestAccAWSEcsTag_disappears --- PASS: TestAccAWSDynamodbTag_disappears (27.72s) --- PASS: TestAccAWSDynamodbTag_basic (30.17s) --- PASS: TestAccAWSEcsTag_disappears (30.37s) --- PASS: TestAccAWSEcsTag_basic (33.00s) --- PASS: TestAccAWSEcsTag_ResourceArn_BatchComputeEnvironment (40.65s) --- PASS: TestAccAWSEcsTag_Value (43.02s) --- PASS: TestAccAWSDynamodbTag_Value (47.20s) --- PASS: TestAccAWSDynamodbTag_ResourceArn_TableReplica (235.23s) --- PASS: TestAccAWSEc2Tag_disappears (587.96s) --- PASS: TestAccAWSEc2Tag_basic (642.95s) --- PASS: TestAccAWSEc2Tag_Value (723.77s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 727.053s

Acceptance test output: % make testacc TESTARGS='-run=TestAccAWSEc2Tag_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2Tag_basic -timeout 180m === RUN TestAccAWSEc2Tag_basic === PAUSE TestAccAWSEc2Tag_basic === CONT TestAccAWSEc2Tag_basic --- PASS: TestAccAWSEc2Tag_basic (643.11s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 646.359s

ewbankkit

LGTM 🚀.

github-actions · 2021-08-31T17:15:29Z

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-06-23T02:36:47Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

bflad added the new-resource Introduces a new resource. label Jun 17, 2020

bflad requested a review from a team June 17, 2020 04:47

anGie44 force-pushed the master branch from 54db70d to 48ba2f7 Compare July 21, 2020 18:26

ewbankkit mentioned this pull request Nov 18, 2020

aws_lambda_function_tag resource to tag lambdas #16273

Closed

Base automatically changed from master to main January 23, 2021 00:58

breathingdust requested a review from a team as a code owner January 23, 2021 00:58

gdavison self-assigned this Feb 16, 2021

gdavison reviewed Feb 16, 2021

View reviewed changes

bflad added a commit that referenced this pull request Mar 24, 2021

Update CHANGELOG for #13783

ff96a32

bflad force-pushed the f-tagresource-generator branch from 5aabc58 to 2f777f6 Compare March 24, 2021 23:38

ewbankkit mentioned this pull request Jun 30, 2021

r/aws_autoscaling_group_tag: new resource for tagging existing ASGs #20009

Closed

ewbankkit added 5 commits August 19, 2021 11:25

Add 'namevaluesfilters' package.

e766fe8

Add namevaluesfilters code generation.

0b010df

Delete unused 'testNameValuesFiltersVerifyNames'.

af91aa9

NameValuesFilters.Map eliminates duplicates removes empty values.

97fa902

Additional AWS services.

3ee1fb4

bflad and others added 19 commits August 19, 2021 12:10

docs/resource/aws_ecs_tag: Show better real world example

819627f

docs/resource/aws_ecs_tag: Fix resource type in example

5096374

docs/provider: Add New Tag Resource section to Contributing Guide

ddca357

Reference: #9061

internal/tagresource: Fix typo in testing

cb53bf7

Update CHANGELOG for #13783

487648a

provider: Update tag generation to Terraform Plugin SDK v2 and add Er…

c968998

…rorCheck in tests

docs/provider: tfproviderdocs modernization for new tag resources

83c615e

docs/contributing: Modernize New Tag Resource section

8b81518

provider: Use ServiceID constant in generated tag resource errors and…

51c03bc

… ensure errors are properly returned

docs/provider: Modernize tag resource example configurations

b989ec0

make gen

882dff2

Add 'ErrorCheck' to acceptance tests.

98b76e8

Return 'NotFoundError' when a tag is not found.

68cf07f

Return 'NotFoundError' from list tags function when parent resource i…

0adfe92

…s not found.

Simplify CreateTags generation.

5689893

ewbankkit force-pushed the f-tagresource-generator branch from 245ae8c to 49cc3e2 Compare August 20, 2021 19:05

github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Aug 20, 2021

ewbankkit approved these changes Aug 20, 2021

View reviewed changes

ewbankkit merged commit 24b31c5 into main Aug 20, 2021

ewbankkit deleted the f-tagresource-generator branch August 20, 2021 19:25

github-actions bot added this to the v3.56.0 milestone Aug 20, 2021

github-actions bot pushed a commit that referenced this pull request Aug 20, 2021

Update CHANGELOG.md for #13783

ee2e043

ewbankkit mentioned this pull request Apr 28, 2022

DynamoDB Global Table Version 2 Replicas don't propagate tags to replica #13281

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provider: Introduce tag resource generator, new aws_dynamodb_tag and aws_ecs_tag resources #13783

provider: Introduce tag resource generator, new aws_dynamodb_tag and aws_ecs_tag resources #13783

bflad commented Jun 17, 2020

DrFaust92 commented Jun 17, 2020

bflad commented Jun 17, 2020

gdavison commented Feb 16, 2021

gdavison left a comment

bflad commented Mar 25, 2021

bflad commented Apr 21, 2021

ewbankkit commented Apr 26, 2021

ewbankkit left a comment

github-actions bot commented Aug 31, 2021

github-actions bot commented Jun 23, 2022

provider: Introduce tag resource generator, new aws_dynamodb_tag and aws_ecs_tag resources #13783

provider: Introduce tag resource generator, new aws_dynamodb_tag and aws_ecs_tag resources #13783

Conversation

bflad commented Jun 17, 2020

Community Note

DrFaust92 commented Jun 17, 2020

bflad commented Jun 17, 2020

gdavison commented Feb 16, 2021

gdavison left a comment

Choose a reason for hiding this comment

bflad commented Mar 25, 2021

bflad commented Apr 21, 2021

ewbankkit commented Apr 26, 2021

ewbankkit left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 31, 2021

github-actions bot commented Jun 23, 2022