Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Introduce tag resource generator, new aws_dynamodb_tag and aws_ecs_tag resources #13783

Merged
merged 41 commits into from
Aug 20, 2021

Commits on Aug 19, 2021

  1. Configuration menu
    Copy the full SHA
    e766fe8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0b010df View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af91aa9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    97fa902 View commit details
    Browse the repository at this point in the history
  5. Additional AWS services.

    ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    3ee1fb4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c788eec View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c48fbde View commit details
    Browse the repository at this point in the history
  8. Update documentation.

    ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    e3a3027 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    624ac04 View commit details
    Browse the repository at this point in the history
  10. d/aws_vpc: Use 'namevaluefilters'.

    Acceptance test output:
    
    $ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsVpc_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccDataSourceAwsVpc_ -timeout 120m
    === RUN   TestAccDataSourceAwsVpc_basic
    === PAUSE TestAccDataSourceAwsVpc_basic
    === RUN   TestAccDataSourceAwsVpc_ipv6Associated
    === PAUSE TestAccDataSourceAwsVpc_ipv6Associated
    === RUN   TestAccDataSourceAwsVpc_multipleCidr
    === PAUSE TestAccDataSourceAwsVpc_multipleCidr
    === CONT  TestAccDataSourceAwsVpc_basic
    === CONT  TestAccDataSourceAwsVpc_multipleCidr
    --- PASS: TestAccDataSourceAwsVpc_basic (40.39s)
    === CONT  TestAccDataSourceAwsVpc_ipv6Associated
    --- PASS: TestAccDataSourceAwsVpc_multipleCidr (64.11s)
    --- PASS: TestAccDataSourceAwsVpc_ipv6Associated (40.41s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	80.853s
    ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    2487452 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3e0088c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    de2c3cf View commit details
    Browse the repository at this point in the history
  13. Additional AWS services.

    ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    b6696b1 View commit details
    Browse the repository at this point in the history
  14. Run 'make gen'.

    ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    c0af1e7 View commit details
    Browse the repository at this point in the history
  15. Replace 'Merge' by 'Add'.

    Acceptance test output:
    
    $ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsVpc_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsVpc_ -timeout 120m
    === RUN   TestAccDataSourceAwsVpc_basic
    === PAUSE TestAccDataSourceAwsVpc_basic
    === RUN   TestAccDataSourceAwsVpc_ipv6Associated
    === PAUSE TestAccDataSourceAwsVpc_ipv6Associated
    === RUN   TestAccDataSourceAwsVpc_multipleCidr
    === PAUSE TestAccDataSourceAwsVpc_multipleCidr
    === CONT  TestAccDataSourceAwsVpc_basic
    === CONT  TestAccDataSourceAwsVpc_multipleCidr
    === CONT  TestAccDataSourceAwsVpc_ipv6Associated
    --- PASS: TestAccDataSourceAwsVpc_basic (29.13s)
    --- PASS: TestAccDataSourceAwsVpc_ipv6Associated (29.44s)
    --- PASS: TestAccDataSourceAwsVpc_multipleCidr (52.13s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	52.183s
    $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAutoscalingGroups_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAutoscalingGroups_ -timeout 120m
    === RUN   TestAccAWSAutoscalingGroups_basic
    === PAUSE TestAccAWSAutoscalingGroups_basic
    === CONT  TestAccAWSAutoscalingGroups_basic
    --- PASS: TestAccAWSAutoscalingGroups_basic (66.92s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.972s
    $ TEST=./aws SWEEP=us-west-2,us-east-1 SWEEPARGS=-sweep-run=aws_db_cluster_snapshot make sweep
    WARNING: This will destroy infrastructure. Use only in development accounts.
    go test ./aws -v -sweep=us-west-2,us-east-1 -sweep-run=aws_db_cluster_snapshot -timeout 60m
    2020/10/24 17:18:59 [DEBUG] Running Sweepers for region (us-west-2):
    2020/10/24 17:18:59 [DEBUG] Running Sweeper (aws_db_cluster_snapshot) in region (us-west-2)
    2020/10/24 17:18:59 [INFO] AWS Auth provider used: "EnvProvider"
    2020/10/24 17:18:59 [DEBUG] Trying to get account information via sts:GetCallerIdentity
    2020/10/24 17:18:59 [DEBUG] Trying to get account information via sts:GetCallerIdentity
    2020/10/24 17:19:00 Sweeper Tests ran successfully:
    	- aws_db_cluster_snapshot
    2020/10/24 17:19:00 [DEBUG] Running Sweepers for region (us-east-1):
    2020/10/24 17:19:00 [DEBUG] Running Sweeper (aws_db_cluster_snapshot) in region (us-east-1)
    2020/10/24 17:19:00 [INFO] AWS Auth provider used: "EnvProvider"
    2020/10/24 17:19:00 [DEBUG] Trying to get account information via sts:GetCallerIdentity
    2020/10/24 17:19:00 [DEBUG] Trying to get account information via sts:GetCallerIdentity
    2020/10/24 17:19:01 Sweeper Tests ran successfully:
    	- aws_db_cluster_snapshot
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	1.803s
    ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    75dac12 View commit details
    Browse the repository at this point in the history
  16. Allow 'namevaluesfilters' internal package to implement functionality…

    … for multiple AWS services.
    ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    a76445b View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    c2a121d View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    87e866d View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    2388347 View commit details
    Browse the repository at this point in the history
  20. Fix typo.

    ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    2dbfb60 View commit details
    Browse the repository at this point in the history
  21. internal/tagresource: Initial generator for individual tag resources,…

    … switch aws_ec2_tag implementation
    
    Reference: #9061
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSEc2Tag_disappears (429.66s)
    --- PASS: TestAccAWSEc2Tag_Value (530.85s)
    --- PASS: TestAccAWSEc2Tag_basic (537.38s)
    ```
    bflad authored and ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    d03884f View commit details
    Browse the repository at this point in the history
  22. New Resource: aws_ecs_tag

    Reference: #11951
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSEcsTag_disappears (29.26s)
    --- PASS: TestAccAWSEcsTag_basic (31.50s)
    --- PASS: TestAccAWSEcsTag_Value (42.11s)
    --- PASS: TestAccAWSEcsTag_ResourceArn_BatchComputeEnvironment (46.40s)
    ```
    bflad authored and ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    4ae3b73 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    819627f View commit details
    Browse the repository at this point in the history
  24. New Resource: aws_dynamodb_tag

    Reference: #6859
    Reference: #13725
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSDynamodbTag_disappears (27.18s)
    --- PASS: TestAccAWSDynamodbTag_basic (31.00s)
    --- PASS: TestAccAWSDynamodbTag_Value (42.71s)
    --- PASS: TestAccAWSDynamodbTag_ResourceArn_TableReplica (159.24s)
    ```
    bflad authored and ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    64fc37a View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    5096374 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    ddca357 View commit details
    Browse the repository at this point in the history
  27. internal/tagresource: Fix typo in testing

    bflad authored and ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    cb53bf7 View commit details
    Browse the repository at this point in the history
  28. Update CHANGELOG for #13783

    bflad authored and ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    487648a View commit details
    Browse the repository at this point in the history
  29. provider: Update tag generation to Terraform Plugin SDK v2 and add Er…

    …rorCheck in tests
    bflad authored and ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    c968998 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    83c615e View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    8b81518 View commit details
    Browse the repository at this point in the history
  32. provider: Use ServiceID constant in generated tag resource errors and…

    … ensure errors are properly returned
    bflad authored and ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    51c03bc View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    b989ec0 View commit details
    Browse the repository at this point in the history
  34. tests/resource/aws_dynamodb_tag: Modernize cross-region test configur…

    …ation for Terraform Plugin SDK v2
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSDynamodbTag_basic (37.69s)
    --- PASS: TestAccAWSDynamodbTag_disappears (41.74s)
    --- PASS: TestAccAWSDynamodbTag_ResourceArn_TableReplica (259.64s)
    --- PASS: TestAccAWSDynamodbTag_Value (53.88s)
    
    --- PASS: TestAccAWSEc2Tag_basic (592.92s)
    --- PASS: TestAccAWSEc2Tag_disappears (576.53s)
    --- PASS: TestAccAWSEc2Tag_Value (714.84s)
    
    --- PASS: TestAccAWSEcsTag_basic (41.02s)
    --- PASS: TestAccAWSEcsTag_disappears (40.40s)
    --- PASS: TestAccAWSEcsTag_ResourceArn_BatchComputeEnvironment (54.92s)
    --- PASS: TestAccAWSEcsTag_Value (50.42s)
    ```
    bflad authored and ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    d598f5a View commit details
    Browse the repository at this point in the history
  35. make gen

    bflad authored and ewbankkit committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    882dff2 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Configuration menu
    Copy the full SHA
    98b76e8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    68cf07f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0adfe92 View commit details
    Browse the repository at this point in the history
  4. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccAWSDynamodbTag_\|TestAccAWSEc2Tag_\|TestAccAWSEcsTag_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDynamodbTag_\|TestAccAWSEc2Tag_\|TestAccAWSEcsTag_ -timeout 180m
    === RUN   TestAccAWSDynamodbTag_basic
    === PAUSE TestAccAWSDynamodbTag_basic
    === RUN   TestAccAWSDynamodbTag_disappears
    === PAUSE TestAccAWSDynamodbTag_disappears
    === RUN   TestAccAWSDynamodbTag_ResourceArn_TableReplica
    === PAUSE TestAccAWSDynamodbTag_ResourceArn_TableReplica
    === RUN   TestAccAWSDynamodbTag_Value
    === PAUSE TestAccAWSDynamodbTag_Value
    === RUN   TestAccAWSEc2Tag_basic
    === PAUSE TestAccAWSEc2Tag_basic
    === RUN   TestAccAWSEc2Tag_disappears
    === PAUSE TestAccAWSEc2Tag_disappears
    === RUN   TestAccAWSEc2Tag_Value
    === PAUSE TestAccAWSEc2Tag_Value
    === RUN   TestAccAWSEcsTag_basic
    === PAUSE TestAccAWSEcsTag_basic
    === RUN   TestAccAWSEcsTag_disappears
    === PAUSE TestAccAWSEcsTag_disappears
    === RUN   TestAccAWSEcsTag_ResourceArn_BatchComputeEnvironment
    === PAUSE TestAccAWSEcsTag_ResourceArn_BatchComputeEnvironment
    === RUN   TestAccAWSEcsTag_Value
    === PAUSE TestAccAWSEcsTag_Value
    === CONT  TestAccAWSDynamodbTag_basic
    === CONT  TestAccAWSEc2Tag_Value
    === CONT  TestAccAWSDynamodbTag_disappears
    === CONT  TestAccAWSEcsTag_basic
    === CONT  TestAccAWSDynamodbTag_Value
    === CONT  TestAccAWSEc2Tag_disappears
    === CONT  TestAccAWSEc2Tag_basic
    === CONT  TestAccAWSEcsTag_ResourceArn_BatchComputeEnvironment
    === CONT  TestAccAWSDynamodbTag_ResourceArn_TableReplica
    === CONT  TestAccAWSEcsTag_Value
    === CONT  TestAccAWSEcsTag_disappears
    --- PASS: TestAccAWSDynamodbTag_disappears (27.72s)
    --- PASS: TestAccAWSDynamodbTag_basic (30.17s)
    --- PASS: TestAccAWSEcsTag_disappears (30.37s)
    --- PASS: TestAccAWSEcsTag_basic (33.00s)
    --- PASS: TestAccAWSEcsTag_ResourceArn_BatchComputeEnvironment (40.65s)
    --- PASS: TestAccAWSEcsTag_Value (43.02s)
    --- PASS: TestAccAWSDynamodbTag_Value (47.20s)
    --- PASS: TestAccAWSDynamodbTag_ResourceArn_TableReplica (235.23s)
    --- PASS: TestAccAWSEc2Tag_disappears (587.96s)
    --- PASS: TestAccAWSEc2Tag_basic (642.95s)
    --- PASS: TestAccAWSEc2Tag_Value (723.77s)
    PASS
    ok      github.com/terraform-providers/terraform-provider-aws/aws       727.053s
    ewbankkit committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    454c2dd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5689893 View commit details
    Browse the repository at this point in the history
  6. Use 'tfresource.RetryWhenNotFound' in CreateTags.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccAWSEc2Tag_basic'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2Tag_basic -timeout 180m
    === RUN   TestAccAWSEc2Tag_basic
    === PAUSE TestAccAWSEc2Tag_basic
    === CONT  TestAccAWSEc2Tag_basic
    --- PASS: TestAccAWSEc2Tag_basic (643.11s)
    PASS
    ok      github.com/terraform-providers/terraform-provider-aws/aws       646.359s
    ewbankkit committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    49cc3e2 View commit details
    Browse the repository at this point in the history