Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Sqs Queue not setting visibility_timeout_seconds = 0 on create #14166

Closed
ysb33r opened this issue Jul 13, 2020 · 2 comments · Fixed by #19639
Closed

AWS Sqs Queue not setting visibility_timeout_seconds = 0 on create #14166

ysb33r opened this issue Jul 13, 2020 · 2 comments · Fixed by #19639
Labels
bug Addresses a defect in current functionality. service/sqs Issues and PRs that pertain to the sqs service.
Milestone

Comments

@ysb33r
Copy link

ysb33r commented Jul 13, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.12.4

Affected Resource(s)

aws_sqs_queue

Terraform Configuration Files

resource  "aws_sqs_queue" "queue_dead" {
  name                       = "example-sqstest-dead"
  delay_seconds              = 0
  message_retention_seconds  = 1209600
  visibility_timeout_seconds = 0
  receive_wait_time_seconds  = 20
}

Expected Behavior

Queue should be created with visibility timeout of 0s.

Actual Behavior

Queue gets created with default of 30s.

Steps to Reproduce

terraform apply 
terraform show # Visibility timeout is 30s
terraform apply
terraform show # Visibility timeout is 0s

Notes

The issue is probably around this area: https://github.com/terraform-providers/terraform-provider-aws/blob/be67f5e0bfb5a4219a0a371543f037e29e7bd064/aws/resource_aws_sqs_queue.go#L184

It needs a special case for the value being 0, rather than relying on the behaviour of d.getOk.

References

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 13, 2020
@ewbankkit ewbankkit added service/sqs Issues and PRs that pertain to the sqs service. bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 15, 2020
ewbankkit added a commit to roberth-k/terraform-provider-aws that referenced this issue Jun 7, 2021
@github-actions github-actions bot added this to the v3.45.0 milestone Jun 7, 2021
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/sqs Issues and PRs that pertain to the sqs service.
Projects
None yet
2 participants