Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support zero visibility_timeout_seconds on create #14213

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14166

Release note for CHANGELOG:

Features:
- resource/resource_aws_sqs_queue: add support zero value for visibility_timeout_seconds on create

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSQSQueue_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSQSQueue_ -timeout 120m
=== RUN   TestAccAWSSQSQueue_basic
=== PAUSE TestAccAWSSQSQueue_basic
=== RUN   TestAccAWSSQSQueue_tags
=== PAUSE TestAccAWSSQSQueue_tags
=== RUN   TestAccAWSSQSQueue_namePrefix
=== PAUSE TestAccAWSSQSQueue_namePrefix
=== RUN   TestAccAWSSQSQueue_namePrefix_fifo
=== PAUSE TestAccAWSSQSQueue_namePrefix_fifo
=== RUN   TestAccAWSSQSQueue_policy
=== PAUSE TestAccAWSSQSQueue_policy
=== RUN   TestAccAWSSQSQueue_queueDeletedRecently
=== PAUSE TestAccAWSSQSQueue_queueDeletedRecently
=== RUN   TestAccAWSSQSQueue_redrivePolicy
=== PAUSE TestAccAWSSQSQueue_redrivePolicy
=== RUN   TestAccAWSSQSQueue_Policybasic
=== PAUSE TestAccAWSSQSQueue_Policybasic
=== RUN   TestAccAWSSQSQueue_FIFO
=== PAUSE TestAccAWSSQSQueue_FIFO
=== RUN   TestAccAWSSQSQueue_FIFOExpectNameError
=== PAUSE TestAccAWSSQSQueue_FIFOExpectNameError
=== RUN   TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication
=== PAUSE TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication
=== RUN   TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError
=== PAUSE TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError
=== RUN   TestAccAWSSQSQueue_Encryption
=== PAUSE TestAccAWSSQSQueue_Encryption
=== RUN   TestAccAWSSQSQueue_WithVisibilityTimeoutSecondsZero
=== PAUSE TestAccAWSSQSQueue_WithVisibilityTimeoutSecondsZero
=== CONT  TestAccAWSSQSQueue_basic
=== CONT  TestAccAWSSQSQueue_FIFO
=== CONT  TestAccAWSSQSQueue_policy
=== CONT  TestAccAWSSQSQueue_Policybasic
=== CONT  TestAccAWSSQSQueue_redrivePolicy
=== CONT  TestAccAWSSQSQueue_Encryption
=== CONT  TestAccAWSSQSQueue_queueDeletedRecently
=== CONT  TestAccAWSSQSQueue_namePrefix
=== CONT  TestAccAWSSQSQueue_namePrefix_fifo
=== CONT  TestAccAWSSQSQueue_WithVisibilityTimeoutSecondsZero
=== CONT  TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication
=== CONT  TestAccAWSSQSQueue_FIFOExpectNameError
=== CONT  TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError
=== CONT  TestAccAWSSQSQueue_tags
--- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (9.98s)
--- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (11.02s)
--- PASS: TestAccAWSSQSQueue_namePrefix (26.21s)
--- PASS: TestAccAWSSQSQueue_FIFO (26.46s)
--- PASS: TestAccAWSSQSQueue_Encryption (26.57s)
--- PASS: TestAccAWSSQSQueue_WithVisibilityTimeoutSecondsZero (26.83s)
--- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (27.03s)
--- PASS: TestAccAWSSQSQueue_namePrefix_fifo (27.47s)
--- PASS: TestAccAWSSQSQueue_redrivePolicy (31.28s)
--- PASS: TestAccAWSSQSQueue_Policybasic (34.67s)
--- PASS: TestAccAWSSQSQueue_policy (35.71s)
--- PASS: TestAccAWSSQSQueue_basic (59.54s)
--- PASS: TestAccAWSSQSQueue_tags (60.12s)
--- PASS: TestAccAWSSQSQueue_queueDeletedRecently (103.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	104.711s

@teraken0509 teraken0509 requested a review from a team July 16, 2020 16:55
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/sqs Issues and PRs that pertain to the sqs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 16, 2020
Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 7, 2021
@ewbankkit
Copy link
Contributor

@teraken0509 Thanks for the contribution 🎉 👏.
I have included the relevant changes in #19639.

@ewbankkit ewbankkit closed this Jun 7, 2021
@github-actions
Copy link

github-actions bot commented Jul 8, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/sqs Issues and PRs that pertain to the sqs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Sqs Queue not setting visibility_timeout_seconds = 0 on create
2 participants