Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS App Mesh: Gateway Route: add exact and regex path to http2 route #24415

Closed
gurudatta-carbon opened this issue Apr 26, 2022 · 4 comments · Fixed by #29064
Closed

AWS App Mesh: Gateway Route: add exact and regex path to http2 route #24415

gurudatta-carbon opened this issue Apr 26, 2022 · 4 comments · Fixed by #29064
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.

Comments

@gurudatta-carbon
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

  • Add Exact and Regex match type to app mesh gateway route terraform provider for http2 spec.
  • Currently it supports only prefix match

image

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.
resource "aws_appmesh_gateway_route" "example" {
  name                 = "test-route"
  mesh_name            = "test"
  virtual_gateway_name = "gateway"

  spec {
    http2_route {
      action {
        target {
          virtual_service {
            virtual_service_name = ""
          }
        }
      }
      match {
        prefix = ""
        // missing
        exact  = ""
        // missing
        regex  = ""
      }
    }
  }

  tags = {
    Environment = "test"
  }
}

References

  • #0000
@gurudatta-carbon gurudatta-carbon added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 26, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/appmesh Issues and PRs that pertain to the appmesh service. labels Apr 26, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Apr 26, 2022
@ewbankkit
Copy link
Contributor

Related: #23041.

@mkielar
Copy link
Contributor

mkielar commented Dec 30, 2022

This is supported by AWS for both http2_route and http_route. And very much needed in both. @ewbankkit would you rather have a separate ticket for http_route, or can we count both cases to be implemented within this one?

@mkielar
Copy link
Contributor

mkielar commented Dec 30, 2022

Also, since AWS API uses dedicated Path section for this, I'd like to suggest slightly different syntax to what @gurudatta-carbon originally proposed. See below:

  http_route {
    match {
      # The old way
      # prefix = "/users"

      # The new way
      path {
        # exact = "/users"
        regex = "/users/(\d+)/change-password"
      } 
    }
  }

  http2_route {
    match {
      # The old way
      # prefix = "/users"

      # The new way
      path {
        # exact = "/users"
        regex = "/users/(\d+)/change-password"
      } 
    }
  }

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants