Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: AWS App Mesh: Route: add exact and regex path to http and http2 routes #28614

Closed
mkielar opened this issue Dec 30, 2022 · 2 comments · Fixed by #29064
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.

Comments

@mkielar
Copy link
Contributor

mkielar commented Dec 30, 2022

Description

Add Path match type to app mesh route terraform provider for http_route and http2_route spec.
Currently it supports only prefix match.

Affected Resource(s) and/or Data Source(s)

  • aws_appmesh_route

Potential Terraform Configuration

resource "aws_appmesh_route" {
  # ... 

  http_route {
    match {
      # The old way
      # prefix = "/users"

      # The new way
      path {
        # exact = "/users"
        regex = "/users/(\d+)/change-password"
      } 
    }
  }

  http2_route {
    match {
      # The old way
      # prefix = "/users"

      # The new way
      path {
        # exact = "/users"
        regex = "/users/(\d+)/change-password"
      } 
    }
  }

  # ... 
}

References

Would you like to implement a fix?

None

@mkielar mkielar added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Dec 30, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/appmesh Issues and PRs that pertain to the appmesh service. label Dec 30, 2022
@mkielar mkielar changed the title [Enhancement]: AWS App Mesh: Route: add exact and regex path to http2 route [Enhancement]: AWS App Mesh: Route: add exact and regex path to http and http2 routes Dec 30, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 3, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants