Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add headers match support to aws_appmesh_gateway_route #30026

Closed
frosty-taussig opened this issue Mar 15, 2023 · 2 comments · Fixed by #29064
Closed

[Enhancement]: Add headers match support to aws_appmesh_gateway_route #30026

frosty-taussig opened this issue Mar 15, 2023 · 2 comments · Fixed by #29064
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.

Comments

@frosty-taussig
Copy link

frosty-taussig commented Mar 15, 2023

Description

Hello,

AWS AppMesh supports match on http header and this is missing in the provider.

Let's have headers match in the provider.

Regards,
Roman.

Affected Resource(s) and/or Data Source(s)

  • aws_appmesh_gateway_route

Potential Terraform Configuration

resource "aws_appmesh_gateway_route" "id" {
  // ...
  spec {
    http_route {
      // ...
      match {
        header {
          name = string
          invert = bool
          method = "exact|perfix|regex|range|sufix"
          values = string
        }
      }
    }
  }
  // ...
}

References

Vendor's docs

aws/aws-app-mesh-roadmap#232

https://docs.aws.amazon.com/app-mesh/latest/userguide/routes.html

Related issues

#28614

#24415

Would you like to implement a fix?

None

@frosty-taussig frosty-taussig added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Mar 15, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/appmesh Issues and PRs that pertain to the appmesh service. label Mar 15, 2023
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 24, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants