aws_appstream_image_builder throws error with empty domain_join_info

[jhancock93]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v1.2.1
on darwin_amd64

• provider registry.terraform.io/hashicorp/aws v4.29.0
• provider registry.terraform.io/hashicorp/external v2.2.2
• provider registry.terraform.io/hashicorp/local v2.2.3
• provider registry.terraform.io/hashicorp/null v3.1.1
• provider registry.terraform.io/hashicorp/random v3.4.2
• provider registry.terraform.io/hashicorp/time v0.8.0

Affected Resource(s)

• aws_appstream_image_builder

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

resource "aws_appstream_image_builder" "image_builder" {
  # Image Builder only needs to be created in nonprod and the created image can be shared with prod account
  count                          = var.create_appstream_image_builder ? 1 : 0
  name                           = "My-Image-Builder"
  description                    = "AppStream Image Builder"
  display_name                   = "AppStream Image Builder"
  enable_default_internet_access = false
  image_name                     = "My Image Builder"
  instance_type                  = "stream.standard.medium"

  vpc_config {
    security_group_ids = [module.appstream_sg.security_group_id]
    subnet_ids         = [local.primary_private_subnet_ids[0]]
  }
}

Debug Output

│ Error: error setting domain_join_info for AppStream ImageBuilder (My-Image-Builder): domain_join_info: '': source data must be an array or slice, got map
│
│ with module.persistent.aws_appstream_image_builder.image_builder[0],
│ on ../../modules/persistent/appstream.tf line 6, in resource "aws_appstream_image_builder" "image_builder":
│ 6: resource "aws_appstream_image_builder" "image_builder" {

Panic Output

Expected Behavior

AppStream Image Builder should be created without errors

Actual Behavior

AppStream image builder resource fails during terraform plan phase with:
error domain_join_info: '': source data must be an array or slice, got map

Steps to Reproduce

1. terraform plan

Important Factoids

This error did not occur with hashicorp aws provider version v4.20.0

References

• #0000

[justinretzolk]

Similar to #24798, which was fixed by #26454.

[jhancock93]

Similar to #24798, which was fixed by #26454.

This still doesn't seem to be resolved with latest provider version (v4.32.0)

[iamperson347]

We are having the same issue when testing 4.36.1. However, our domain_join_info is NOT empty (confirmed by the last applied state file).

[justinretzolk]

Hey @jhancock93 👋 Thank you for following up. I see my mistake now in that the linked issue/PR were for the aws_appstream_fleet resource, despite the issue referencing aws_appstream_image_builder. Since you mentioned you didn't run into this with version 4.20.0, I'll mark this as a regression as well.

[braun1928]

@justinretzolk I created a branch with small changes that fix this, if you want to check out the diff.

I was attempting to create a test for it as well, but my AWS access is very limited and I can't create the necessary resources to complete it.

[PatriQ1414]

I am still facing this error in v4.39.0
Any workaround?

[PatriQ1414]

I am still facing this error in v4.39.0 Any workaround?

Downgraded to 4.28 and still getting the same error

[nngabriel]

I'm experiencing the same issue with v4.41.0.

[pureiboi]

I'm experiencing the same issue with 4.45.0

[matiassilverorh]

Any workaround? Because even downgrading to previous versions doesn't work.

[tjames-stig]

I've identified 4d802fe as the commit which might have introduced the regression, which would mean that downgrading to before v4.28.0 might be a workaround for this bug.

[pureiboi]

I have identified this section of code is causing the issue,

the method in image_builder.go

func resourceImageBuilderRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {

	if err = d.Set("domain_join_info", flattenDomainInfo(imageBuilder.DomainJoinInfo)); err != nil {
		return diag.FromErr(fmt.Errorf("error setting `%s` for AppStream ImageBuilder (%s): %w", "domain_join_info", d.Id(), err))
	}

	if err = d.Set("vpc_config", flattenVPCConfig(imageBuilder.VpcConfig)); err != nil {
		return diag.FromErr(fmt.Errorf("error setting `%s` for AppStream ImageBuilder (%s): %w", "vpc_config", d.Id(), err))
	}

both domain_join_info and vpc_config is throwing error:

after the section of code setting domain_join_info is removed, below will surface for vpc_config.

│ Error: error setting vpc_config for AppStream ImageBuilder (linux-image-builder-test-tf): vpc_config: '': source data must be an array or slice, got map

I may be able to help, however with limited knowledge on golang and code structure, need more time on this.

[tjames-stig]

I see exactly how this regression occurred. When #26454 was submitted, an acceptance test for appstream_fleet was performed, however, code in internal/services/appstream/fleet.go is also referenced in internal/services/appstream/image_builder.go, and that code was broken by the mentioned PR, and it was not detected because the acceptance tests for appstream_image_builder were not run.

[pureiboi]

anyone looking into the PR, whether is it ok to go forward?

[liamraeAL]

Any update on this? Still blocking our development.

[nngabriel]

Is there a way to push this? or collaborate to make it happen?

[tjames-stig]

I've got a PR up (#28195) and linked to this, with all the appropriate acceptance testing performed. I would be happy to help out and do whatever is needed to make my PR viable for merging.

[github-actions]

This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.