Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appstream_fleet: Fix empty domain_join bug #26454

Merged
merged 8 commits into from
Aug 23, 2022
Merged

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 23, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24798

Output from acceptance testing:

% make testacc TESTS=TestAccAppStreamFleet PKG=appstream
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamFleet'  -timeout 180m
=== RUN   TestAccAppStreamFleetStackAssociation_basic
=== PAUSE TestAccAppStreamFleetStackAssociation_basic
=== RUN   TestAccAppStreamFleetStackAssociation_disappears
=== PAUSE TestAccAppStreamFleetStackAssociation_disappears
=== RUN   TestAccAppStreamFleet_basic
=== PAUSE TestAccAppStreamFleet_basic
=== RUN   TestAccAppStreamFleet_disappears
=== PAUSE TestAccAppStreamFleet_disappears
=== RUN   TestAccAppStreamFleet_completeWithStop
=== PAUSE TestAccAppStreamFleet_completeWithStop
=== RUN   TestAccAppStreamFleet_completeWithoutStop
=== PAUSE TestAccAppStreamFleet_completeWithoutStop
=== RUN   TestAccAppStreamFleet_withTags
=== PAUSE TestAccAppStreamFleet_withTags
=== RUN   TestAccAppStreamFleet_emptyDomainJoin
=== PAUSE TestAccAppStreamFleet_emptyDomainJoin
=== CONT  TestAccAppStreamFleetStackAssociation_basic
=== CONT  TestAccAppStreamFleet_completeWithStop
=== CONT  TestAccAppStreamFleet_withTags
=== CONT  TestAccAppStreamFleet_completeWithoutStop
=== CONT  TestAccAppStreamFleet_basic
=== CONT  TestAccAppStreamFleet_emptyDomainJoin
=== CONT  TestAccAppStreamFleet_disappears
=== CONT  TestAccAppStreamFleetStackAssociation_disappears
--- PASS: TestAccAppStreamFleetStackAssociation_disappears (889.77s)
--- PASS: TestAccAppStreamFleet_disappears (891.87s)
--- PASS: TestAccAppStreamFleetStackAssociation_basic (936.04s)
--- PASS: TestAccAppStreamFleet_emptyDomainJoin (944.70s)
--- PASS: TestAccAppStreamFleet_basic (978.95s)
--- PASS: TestAccAppStreamFleet_completeWithoutStop (987.97s)
--- PASS: TestAccAppStreamFleet_withTags (1095.04s)
--- PASS: TestAccAppStreamFleet_completeWithStop (1774.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	1775.730s

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/appstream Issues and PRs that pertain to the appstream service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 23, 2022
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. labels Aug 23, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Aug 23, 2022
@YakDriver YakDriver merged commit 37732c8 into main Aug 23, 2022
@YakDriver YakDriver deleted the b-appstream-fleet-crash branch August 23, 2022 22:15
@github-actions github-actions bot added this to the v4.28.0 milestone Aug 23, 2022
github-actions bot pushed a commit that referenced this pull request Aug 23, 2022
@github-actions
Copy link

This functionality has been released in v4.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/appstream Issues and PRs that pertain to the appstream service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin crash when using aws_appstream_fleet resource with undefined
1 participant