Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct aws_ecs_task_execution data source container_overrides expander #32793

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

justinretzolk
Copy link
Member

Description

This PR corrects an issue where the container_overrides expander of the aws_ecs_task_execution data source incorrectly set the value of memory_reservation to the value of memory.

Relations

Closes #32785

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccECSTaskExecutionDataSource PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskExecutionDataSource'  -timeout 180m
=== RUN   TestAccECSTaskExecutionDataSource_basic
=== PAUSE TestAccECSTaskExecutionDataSource_basic
=== RUN   TestAccECSTaskExecutionDataSource_overrides
=== PAUSE TestAccECSTaskExecutionDataSource_overrides
=== RUN   TestAccECSTaskExecutionDataSource_tags
=== PAUSE TestAccECSTaskExecutionDataSource_tags
=== CONT  TestAccECSTaskExecutionDataSource_basic
=== CONT  TestAccECSTaskExecutionDataSource_tags
=== CONT  TestAccECSTaskExecutionDataSource_overrides
--- PASS: TestAccECSTaskExecutionDataSource_basic (291.62s)
--- PASS: TestAccECSTaskExecutionDataSource_tags (294.08s)
--- PASS: TestAccECSTaskExecutionDataSource_overrides (294.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        297.653s

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 1, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc TESTS=TestAccECSTaskExecutionDataSource PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskExecutionDataSource'  -timeout 180m

--- PASS: TestAccECSTaskExecutionDataSource_tags (292.26s)
--- PASS: TestAccECSTaskExecutionDataSource_basic (294.95s)
--- PASS: TestAccECSTaskExecutionDataSource_overrides (294.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        298.007s

@justinretzolk justinretzolk merged commit f3af920 into main Aug 1, 2023
@justinretzolk justinretzolk deleted the b-ecs_task_execution-data-source branch August 1, 2023 18:59
@github-actions github-actions bot added this to the v5.11.0 milestone Aug 1, 2023
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong argument mapping
2 participants