-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_elasticache_reserved_cache_node: fix start_time
schema type
#40090
Conversation
Community NoteVoting for Prioritization
For Submitters
|
The `StartTime` value returned from AWS is a `time.Time` type, so the corresponding Terraform schema should use a custom `timetypes.RFC3339` type for AutoFlex to function properly. This change should prevent `Provider returned invalid result object after apply` errors during creation.
69e2c4a
to
2a09a76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
I will test this once v5.76.0 is released. |
Awesome - thank you @pshen! |
This functionality has been released in v5.76.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I've just tested creating new reserved cache node with v5.76.0. This PR worked perfectly without error in the output. |
Thank you for the quick feedback! Much appreciated. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The
StartTime
value returned from AWS is atime.Time
type, so the corresponding Terraform schema should use a customtimetypes.RFC3339
type for AutoFlex to function properly. This change should preventProvider returned invalid result object after apply
errors during creation.Relations
Closes #40058
Relates #39945
Relates #39451
Relates #29832
Output from Acceptance Testing
We are unable to acceptance test this resource as removal of the reserved cache node requires contacting AWS support. As such, this fix is a best effort implementation and we ask for community feedback on the change. Please link any new bug reports to this PR. Thank you!