Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_elasticache_reserved_cache_node: fix start_time schema type #40090

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Nov 11, 2024

Description

The StartTime value returned from AWS is a time.Time type, so the corresponding Terraform schema should use a custom timetypes.RFC3339 type for AutoFlex to function properly. This change should prevent Provider returned invalid result object after apply errors during creation.

Relations

Closes #40058
Relates #39945
Relates #39451
Relates #29832

Output from Acceptance Testing

We are unable to acceptance test this resource as removal of the reserved cache node requires contacting AWS support. As such, this fix is a best effort implementation and we ask for community feedback on the change. Please link any new bug reports to this PR. Thank you!

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/elasticache Issues and PRs that pertain to the elasticache service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 11, 2024
The `StartTime` value returned from AWS is a `time.Time` type, so the corresponding Terraform schema should use a custom `timetypes.RFC3339` type for AutoFlex to function properly. This change should prevent `Provider returned invalid result object after apply` errors during creation.
@jar-b jar-b force-pushed the b-start_time-invalid-result branch from 69e2c4a to 2a09a76 Compare November 11, 2024 21:45
@jar-b jar-b marked this pull request as ready for review November 11, 2024 21:56
@jar-b jar-b requested a review from a team as a code owner November 11, 2024 21:56
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jar-b jar-b merged commit 8cb9f86 into main Nov 12, 2024
38 checks passed
@jar-b jar-b deleted the b-start_time-invalid-result branch November 12, 2024 15:21
@github-actions github-actions bot added this to the v5.76.0 milestone Nov 12, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Nov 12, 2024
@pshen
Copy link

pshen commented Nov 12, 2024

I will test this once v5.76.0 is released.

@jar-b
Copy link
Member Author

jar-b commented Nov 12, 2024

Awesome - thank you @pshen!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 14, 2024
Copy link

This functionality has been released in v5.76.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@pshen
Copy link

pshen commented Nov 15, 2024

I've just tested creating new reserved cache node with v5.76.0. This PR worked perfectly without error in the output.

@jar-b
Copy link
Member Author

jar-b commented Nov 15, 2024

Thank you for the quick feedback! Much appreciated.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Provider returned invalid result object after apply for aws_elasticache_reserved_cache_node
3 participants