Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kinesis Firehose Data Transformation #513

Closed
hashibot opened this issue Jun 13, 2017 · 20 comments · Fixed by #4251
Closed

Support Kinesis Firehose Data Transformation #513

hashibot opened this issue Jun 13, 2017 · 20 comments · Fixed by #4251
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Milestone

Comments

@hashibot
Copy link

This issue was originally opened by @mlimaloureiro as hashicorp/terraform#11723. It was migrated here as part of the provider split. The original body of the issue is below.


Hi Guys,

I would like to request Terraform to support Kinesis Firehose data transformation.

More info here

https://aws.amazon.com/about-aws/whats-new/2016/12/amazon-kinesis-firehose-can-now-prepare-and-transform-streaming-data-before-loading-it-to-data-stores/

Thanks!

@hashibot hashibot added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 13, 2017
@saiaman
Copy link

saiaman commented Aug 22, 2017

Even with extended_s3_configuration, we shall have processing_configuration in each destination possibility ( elasticsearch / redshift / s3 ) .

http://docs.aws.amazon.com/firehose/latest/APIReference/API_CreateDeliveryStream.html

@CannibalVox
Copy link

This is kind of messed up atm because redshift doesn't support extended_s3_configuration, only s3_configuration.

@joeig
Copy link
Contributor

joeig commented Sep 11, 2017

The Elasticsearch destination requires the legacy s3_configuration as well.
Compared with the AWS CLI's "aws firehose describe-delivery-stream", the processing configuration should apply to the delivery stream instead of the "extended_s3_configuration".

@cgarvis
Copy link
Contributor

cgarvis commented Sep 25, 2017

Would love to have this for my ElasticSearch firehose.

@kchristensen
Copy link

Having to manually enable data transformation on our redshift firehoses is a bummer, I'd love to see support for extended_s3_configuration in Redshift firehoses.

@ligustah
Copy link

ligustah commented Oct 20, 2017

I'd also like to see this for redshift. From the API it appears to be set on the redshift destination configuration, so it should be completely independent of any s3 config.

@jseiser
Copy link
Contributor

jseiser commented Nov 8, 2017

I'm reading through the docs, and this issue, and I'm still not clear. I have an elastic search firehose, that I need to recreate with terraform that uses a lambda to convert syslogs to json.

Is there no way to do this in terraform?

@jseiser
Copy link
Contributor

jseiser commented Nov 8, 2017

OK, confirming that this doesnt work.

When destination is elasticsearch, s3_configuration is required

@lhsoeren
Copy link

Hi, is there a way (with Terraform) to configure Firehose in such a way, that I can have my data streamed into a bucket and simultaneously have a lambda function parse the data and get the data stored in a secound bucket? I can't seem to make it work.

@ghost
Copy link

ghost commented Dec 8, 2017

Just landed here after having a conflict between extended_s3_configuration and s3_configuration to try with elasticsearch:

Error: aws_kinesis_firehose_delivery_stream.test_stream: "extended_s3_configuration": conflicts with s3_configuration ([]map[string]interface {}{map[string]interface {}{"compression_format":"GZIP", "role_arn":"${aws_iam_role.main.arn}", "bucket_arn":"arn:aws:s3:::somebucket/folder", "buffer_size":10, "buffer_interval":400}})

@mkamlesh
Copy link

We have also stumbled upon this issue while trying to configure Firehose Delivery stream to transform data before pushing it to Redshift cluster. When does Terraform plan to support this extended_s3_configuration for Redshift destination?

@radeksimko radeksimko added the service/firehose Issues and PRs that pertain to the firehose service. label Jan 15, 2018
@parthshahva
Copy link

Is there someone who is available to confirm I'm looking in the correct places in the code? I'd like to add support for this

jamesrenfro added a commit to jamesrenfro/terraform-provider-aws that referenced this issue Mar 5, 2018
This is a partial fix for the issue listed below. The problem currently is
that you can add an extended_s3_configuration to the
aws_kinesis_firehose_delivery_stream and set the destionation to 'extended_s3'
if you want data transformation to be enabled for S3, but you can't do the
same if your destination is 'elastisearch' - this commit fixes that.

Support Kinesis Firehose Data Transformation hashicorp#513
hashicorp#513
jamesrenfro added a commit to jamesrenfro/terraform-provider-aws that referenced this issue Mar 5, 2018
This is a partial fix for the issue listed below. The problem currently is
that you can add an extended_s3_configuration to the
aws_kinesis_firehose_delivery_stream and set the destionation to 'extended_s3'
if you want data transformation to be enabled for S3, but you can't do the
same if your destination is 'elastisearch' - this commit fixes that.

Support Kinesis Firehose Data Transformation hashicorp#513
hashicorp#513
@jamesrenfro
Copy link
Contributor

Is there anything else that we can provide on the commits above (e.g. #3621) that would help to get them reviewed and hopefully merged?

@bflad
Copy link
Contributor

bflad commented Apr 4, 2018

Elasticsearch and Splunk processing configuration support is now merged in and will release with v1.14.0, likely before the end of the week. I need to get a crash prevention PR in for #4033, but can also submit the PR for Redshift afterwards.

@bflad
Copy link
Contributor

bflad commented Apr 6, 2018

Elasticsearch and Splunk processing configuration support has been released in version 1.14.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@scorsi
Copy link

scorsi commented Apr 16, 2018

Hi,
Is processing configuration planned for Redshift destination ?

@bflad
Copy link
Contributor

bflad commented Apr 18, 2018

Redshift PR submitted: #4251

@bflad bflad added this to the v1.16.0 milestone Apr 23, 2018
@bflad
Copy link
Contributor

bflad commented Apr 23, 2018

Redshift support for processing_configuration has been merged and will release with v1.16.0 of the AWS provider, likely in a few days. Thanks everyone!

@bflad
Copy link
Contributor

bflad commented Apr 25, 2018

The last bits to support Redshift have been released in version 1.16.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet