-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding processing_configuration to elasticsearch section #3621
Conversation
This is a partial fix for the issue listed below. The problem currently is that you can add an extended_s3_configuration to the aws_kinesis_firehose_delivery_stream and set the destionation to 'extended_s3' if you want data transformation to be enabled for S3, but you can't do the same if your destination is 'elastisearch' - this commit fixes that. Support Kinesis Firehose Data Transformation hashicorp#513 hashicorp#513
This is a partial fix for the issue listed below. The problem currently is that you can add an extended_s3_configuration to the aws_kinesis_firehose_delivery_stream and set the destionation to 'extended_s3' if you want data transformation to be enabled for S3, but you can't do the same if your destination is 'elastisearch' - this commit fixes that. Support Kinesis Firehose Data Transformation hashicorp#513 hashicorp#513
…icsearch destination
Adding processing_configuration to elasticsearch section hashicorp#3621
Can you please add an acceptance test that exercises this new code? You can take a look at #3944 for inspiration |
Actually do not worry about the acceptance testing, I will add it before I merge, as I would like to submit a followup PR to prevent some crashes that will interfere with the implementation of this PR as-is. |
Ok - thanks very much! |
This has been released in version 1.14.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
This is a partial fix for the issue listed below. The problem currently is
that you can add an extended_s3_configuration to the
aws_kinesis_firehose_delivery_stream and set the destination to 'extended_s3'
if you want data transformation to be enabled for S3, but you can't do the
same if your destination is 'elastisearch' - this commit fixes that.
Support Kinesis Firehose Data Transformation #513
#513