Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding processing_configuration to elasticsearch section #3621

Merged
merged 4 commits into from
Apr 4, 2018

Conversation

jamesrenfro
Copy link
Contributor

This is a partial fix for the issue listed below. The problem currently is
that you can add an extended_s3_configuration to the
aws_kinesis_firehose_delivery_stream and set the destination to 'extended_s3'
if you want data transformation to be enabled for S3, but you can't do the
same if your destination is 'elastisearch' - this commit fixes that.

Support Kinesis Firehose Data Transformation #513
#513

This is a partial fix for the issue listed below. The problem currently is
that you can add an extended_s3_configuration to the
aws_kinesis_firehose_delivery_stream and set the destionation to 'extended_s3'
if you want data transformation to be enabled for S3, but you can't do the
same if your destination is 'elastisearch' - this commit fixes that.

Support Kinesis Firehose Data Transformation hashicorp#513
hashicorp#513
This is a partial fix for the issue listed below. The problem currently is
that you can add an extended_s3_configuration to the
aws_kinesis_firehose_delivery_stream and set the destionation to 'extended_s3'
if you want data transformation to be enabled for S3, but you can't do the
same if your destination is 'elastisearch' - this commit fixes that.

Support Kinesis Firehose Data Transformation hashicorp#513
hashicorp#513
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Mar 5, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service. labels Mar 6, 2018
igorshapiro added a commit to WiserSolutions/terraform-provider-aws that referenced this pull request Mar 10, 2018
Adding processing_configuration to elasticsearch section hashicorp#3621
@bflad
Copy link
Contributor

bflad commented Apr 4, 2018

Can you please add an acceptance test that exercises this new code? You can take a look at #3944 for inspiration

@bflad bflad added waiting-response Maintainers are waiting on response from community or contributor. and removed waiting-response Maintainers are waiting on response from community or contributor. labels Apr 4, 2018
@bflad bflad added this to the v1.14.0 milestone Apr 4, 2018
@bflad
Copy link
Contributor

bflad commented Apr 4, 2018

Actually do not worry about the acceptance testing, I will add it before I merge, as I would like to submit a followup PR to prevent some crashes that will interfere with the implementation of this PR as-is.

@bflad bflad merged commit 20f3476 into hashicorp:master Apr 4, 2018
bflad added a commit that referenced this pull request Apr 4, 2018
@jamesrenfro
Copy link
Contributor Author

Ok - thanks very much!

@bflad
Copy link
Contributor

bflad commented Apr 6, 2018

This has been released in version 1.14.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants