Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Version 2 Release] resource/aws_api_gateway_integration: Remove deprecated request_parameters_in_json argument #7678

Closed
bflad opened this issue Feb 24, 2019 · 2 comments · Fixed by #7699
Closed

[Version 2 Release] resource/aws_api_gateway_integration: Remove deprecated request_parameters_in_json argument #7678

bflad opened this issue Feb 24, 2019 · 2 comments · Fixed by #7699
Labels
service/apigateway Issues and PRs that pertain to the apigateway service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone
v2.0.0

Comments

@bflad
Copy link
Contributor

bflad commented Feb 24, 2019

Description

Tracking issue for: https://www.terraform.io/docs/providers/aws/guides/version-2-upgrade.html#resource-aws_api_gateway_integration

request_parameters_in_json Argument Removal

Switch your Terraform configuration to the request_parameters argument instead.

For example, given this previous configuration:

resource "aws_api_gateway_integration" "example" {
  # ... other configuration ...

  request_parameters_in_json = <<PARAMS
{
    "integration.request.header.X-Authorization": "'static'"
}
PARAMS
}

An updated configuration:

resource "aws_api_gateway_integration" "example" {
  # ... other configuration ...

  request_parameters = {
    "integration.request.header.X-Authorization" = "'static'"
  }
}
@bflad bflad added service/apigateway Issues and PRs that pertain to the apigateway service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Feb 24, 2019
@bflad bflad added this to the v2.0.0 milestone Feb 24, 2019
bflad added a commit that referenced this issue Feb 24, 2019
@bflad
resource/aws_api_gateway_integration: Remove deprecated request_param…
d6b5e3b 
…eters_in_json argument

Reference: #7678

Changes:

* Remove deprecated `request_parameters_in_json` argument
* Remove extraneous `resource.Retry()` usage during resource deletion
* Return any error from setting `request_parameters` in Terraform state

Output from acceptance testing:

```
--- PASS: TestAccAWSAPIGatewayIntegration_cache_key_parameters (13.95s)
--- PASS: TestAccAWSAPIGatewayIntegration_basic (44.82s)
--- PASS: TestAccAWSAPIGatewayIntegration_contentHandling (79.71s)
--- PASS: TestAccAWSAPIGatewayIntegration_integrationType (703.80s)
```
@bflad bflad mentioned this issue Feb 24, 2019
Merged
@bflad
Copy link
Contributor Author

bflad commented Feb 24, 2019

Pull request submitted: #7699

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
service/apigateway Issues and PRs that pertain to the apigateway service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.0.0
1 participant
@bflad