Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_api_gateway_integration: Remove deprecated request_parameters_in_json argument #7699

Merged
merged 1 commit into from
Feb 27, 2019
Merged

resource/aws_api_gateway_integration: Remove deprecated request_parameters_in_json argument #7699

merged 1 commit into from
Feb 27, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 24, 2019

Closes #7678

Changes:

  • Remove deprecated request_parameters_in_json argument
  • Remove extraneous resource.Retry() usage during resource deletion
  • Return any error from setting request_parameters in Terraform state

Output from acceptance testing:

--- PASS: TestAccAWSAPIGatewayIntegration_cache_key_parameters (13.95s)
--- PASS: TestAccAWSAPIGatewayIntegration_basic (44.82s)
--- PASS: TestAccAWSAPIGatewayIntegration_contentHandling (79.71s)
--- PASS: TestAccAWSAPIGatewayIntegration_integrationType (703.80s)

@bflad
resource/aws_api_gateway_integration: Remove deprecated request_param…
d6b5e3b 
…eters_in_json argument

Reference: #7678

Changes:

* Remove deprecated `request_parameters_in_json` argument
* Remove extraneous `resource.Retry()` usage during resource deletion
* Return any error from setting `request_parameters` in Terraform state

Output from acceptance testing:

```
--- PASS: TestAccAWSAPIGatewayIntegration_cache_key_parameters (13.95s)
--- PASS: TestAccAWSAPIGatewayIntegration_basic (44.82s)
--- PASS: TestAccAWSAPIGatewayIntegration_contentHandling (79.71s)
--- PASS: TestAccAWSAPIGatewayIntegration_integrationType (703.80s)
```
@bflad bflad added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/apigateway Issues and PRs that pertain to the apigateway service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Feb 24, 2019
@bflad bflad added this to the v2.0.0 milestone Feb 24, 2019
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Feb 24, 2019
@bflad bflad mentioned this pull request Feb 24, 2019
Closed
@bflad bflad requested a review from a team February 26, 2019 15:41
paultyng
paultyng approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bflad why do you no longer need to retry here? Was it just never necessary?

@bflad
Copy link
Contributor Author

bflad commented Feb 27, 2019

@bflad why do you no longer need to retry here? Was it just never necessary?

We chatted about this out of band, but the answer is that it was never necessary since it does not return resource.RetryableError() and prevents the AWS Go SDK configuration of MaxRetries from being used correctly in this situation. When we implement StopContext, we can correctly stop the automatic AWS Go SDK retries. 👍

@bflad bflad merged commit 8f943f2 into master Feb 27, 2019
@bflad bflad deleted the td-aws_api_gateway_integration-remove-deprecated branch February 27, 2019 00:33
bflad added a commit that referenced this pull request Feb 27, 2019
@bflad
Update CHANGELOG for #7699 and #7700
3e15c40
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.0.0
2 participants
@bflad @paultyng