Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing subject_alternative_names parameter doesn't force a new certificate #8755

Closed
tomelliff opened this issue May 23, 2019 · 4 comments · Fixed by #13513
Closed

Removing subject_alternative_names parameter doesn't force a new certificate #8755

tomelliff opened this issue May 23, 2019 · 4 comments · Fixed by #13513
Assignees
Labels
documentation Introduces or discusses updates to documentation. service/acm Issues and PRs that pertain to the acm service.
Milestone

Comments

@tomelliff
Copy link
Contributor

tomelliff commented May 23, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v0.11.14

  • provider.aws v2.11.0

Affected Resource(s)

  • aws_acm_certificate

Removing subject_alternative_names from aws_acm_certificate resource doesn't force a new certificate to be created.

Terraform Configuration Files

resource "aws_acm_certificate" "certificate" {
  domain_name = "foo.example.com"

  subject_alternative_names = [
    "bar.example.com",
    "baz.example.com",
  ]

  validation_method = "DNS"
}

Then remove the subject_alternative_names parameter:

resource "aws_acm_certificate" "certificate" {
  domain_name = "foo.example.com"

  validation_method = "DNS"
}

And run a plan to see that Terraform doesn't want to do anything.

Expected Behavior

Should want to recreate the certificate without any SANs.

Actual Behavior

Terraform plan shows no changes.

Steps to Reproduce

  1. terraform apply first config
  2. terraform plan second config
@tomelliff tomelliff changed the title Removing Removing subject_alternative_names parameter doesn't force a new certificate May 23, 2019
@aeschright aeschright added the needs-triage Waiting for first response or review from a maintainer. label Jun 19, 2019
@aeschright aeschright added the service/acm Issues and PRs that pertain to the acm service. label Jul 2, 2019
@dekimsey
Copy link
Contributor

I'm also running into the reverse situation. Adding a subject_alternative_names = ['foo.com'] attribute to my existing aws_acm_certificate resource does not trigger a change. (And apparently nor does tainting it!) So I'm unable to add the validation record resources.

Error: Invalid index

  on example.tf line 10, in resource "aws_route53_record" "example_san1":
 178:   name    = aws_acm_certificate.example.domain_validation_options.1.resource_record_name
    |----------------
    | aws_acm_certificate.example.domain_validation_options is list of object with 1 element

The given key does not identify an element in this collection value.

@bflad bflad added documentation Introduces or discusses updates to documentation. and removed needs-triage Waiting for first response or review from a maintainer. labels May 27, 2020
@bflad bflad self-assigned this May 27, 2020
bflad added a commit that referenced this issue May 27, 2020
Reference: #3855
Reference: #6082
Reference: #8755
Reference: #12075
Reference: #13053

Notable changes:

```
ENHANCEMENTS:

* resource/aws_acm_certificate: Add `status` attribute

BUG FIXES:

* resource/aws_acm_certificate: Detect `AMAZON_ISSUED` type `validation_method` value directly from API response instead of custom logic
* resource/aws_acm_certificate: Increase deletion retries from 10 minutes to 20 minutes (better support API Gateway Custom Domain deletion)
```

Other changes:

- Documents `subject_alternative_names` argument removal procedures
- Improves potentially confusing error message during asynchronous ACM validation assignment

Output from acceptance testing:

```
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (36.64s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (37.74s)
--- PASS: TestAccAWSAcmCertificate_wildcard (38.86s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (39.08s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (39.11s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (39.35s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (39.62s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (41.62s)
--- PASS: TestAccAWSAcmCertificate_san_single (41.93s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (42.00s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (42.05s)
--- PASS: TestAccAWSAcmCertificate_root (42.07s)
--- PASS: TestAccAWSAcmCertificate_privateCert (47.46s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (54.51s)
--- PASS: TestAccAWSAcmCertificate_tags (85.67s)
```
@bflad bflad added this to the v2.65.0 milestone Jun 4, 2020
@bflad
Copy link
Contributor

bflad commented Jun 4, 2020

A documentation update has been merged and will deploy when version 2.65.0 of the Terraform AWS Provider is released, likely later today. 👍

@ghost
Copy link

ghost commented Jun 5, 2020

This has been released in version 2.65.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/acm Issues and PRs that pertain to the acm service.
Projects
None yet
4 participants